Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5d40e92b-2e7b-addf-d03b-3bc6da7895be@intel.com>
Date:   Wed, 19 Apr 2023 11:13:54 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH V3 10/10] vfio/pci: Clear VFIO_IRQ_INFO_NORESIZE for MSI-X
Content-Language: en-US
To:     Alex Williamson <alex.williamson@redhat.com>
CC:     <jgg@nvidia.com>, <yishaih@nvidia.com>,
        <shameerali.kolothum.thodi@huawei.com>, <kevin.tian@intel.com>,
        <tglx@linutronix.de>, <darwi@linutronix.de>, <kvm@vger.kernel.org>,
        <dave.jiang@intel.com>, <jing2.liu@intel.com>,
        <ashok.raj@intel.com>, <fenghua.yu@intel.com>,
        <tom.zanussi@linux.intel.com>, <linux-kernel@vger.kernel.org>
References: <cover.1681837892.git.reinette.chatre@intel.com>
 <6c057618833a180da2147bffadb98e07cb73e045.1681837892.git.reinette.chatre@intel.com>
 <20230418163843.7b4c0366.alex.williamson@redhat.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230418163843.7b4c0366.alex.williamson@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWFhOU9OaHpZNGVmeFlnNXZiWHBvRjlrZnBsUVp2VGdORzVVV1Eza2IwRDNQ?=
 =?utf-8?B?ZE13Ull6TzkyMW5kN2VmbFFqcUtzM0ZjNFRMS2VaRjU2MlRJaGJZeFF1dlRD?=
 =?utf-8?B?Zk1hQ01jS1czaWFkeGhMV3N4YWRYZ0wrR2IzK3BNWjF5ZFZyV3JwMlZjYnRB?=
 =?utf-8?B?a2k1eTU1R25Za0trTFRISzRzQkdLaThvd09qck4xeU9ZdmRybElxSmJxVlUw?=
 =?utf-8?B?dmhXOW1iSnVac2NkRkRvTFB5Q1RtT0xhbnVqNzF3dkYwTllOOUtEcjZ1cWJX?=
 =?utf-8?B?bm5ybnBpWHVLdGVqaDh3UXZ0dFBlbG9CZ3NhdWdzanZGQWZ2V0xmRWgvTUN5?=
 =?utf-8?B?RTZqbFd3ajNIZXQwNkROczVyYitHa3p3eG4rZ25qT0ZtOHdYNi9XbDk2Mlpp?=
 =?utf-8?B?L0k2WHM2R1BOc1VqYk80cVVsditwNDBWQzV3aDdNL0MrSzBKSTBPUnJsR1pI?=
 =?utf-8?B?ZnQzNUtQemJrbC92eHoxbUhXYW55UGJJMU52N08yUmF3MldPVGxpVThzTjlZ?=
 =?utf-8?B?NWxNT1ozS2NqTlRRMTlGNTRqRTg5bEQ3TnJOSFNZZEJwOWVlSWhFaVJnTVRY?=
 =?utf-8?B?eEh3cVlCVFFzS3p2QXJvcDJhZjNPRnQrSjVhVnpzcy9tQUFhaHdDRVlpUUxD?=
 =?utf-8?B?ZjhnckNVQ3NIL0lnaXAxb09ZM0RQdFdudFMyaFpHZGo4UHRjWk5GL3ArNndl?=
 =?utf-8?B?cTY2OXhic2VhcFVYVTZta0hLUTNNSkQyTTBCYjQzaTFWY3loeUREMjN3dW1P?=
 =?utf-8?B?a0VNQ0JqbjNrMkl4ZGNkaldyZEQvLzduRGNvcmhCaFcxYmJ3TUhRVTkvMkc5?=
 =?utf-8?B?akxjMWhMejN4UjdzaVd6a3BYdnA4N1RvVmZnOXB6c3JhTVRjaEVQM0NWZGhG?=
 =?utf-8?B?dUdmTWE5a1BMZUJnSmZ1NCtNblJqOEhoV2FncUVDK3A3QTNTZW5BejdFcTRh?=
 =?utf-8?B?Uk5QS0FtQW4wSFBVRGtleUV0U1hETDdRa2xCQzRrRFBmYnRWeC83aXNkRWhi?=
 =?utf-8?B?VVpmbS9PN3JxRkxudmlTY0V0R2hSVXpKanpPQmpTZDlQTGptTDZWeGdxczJn?=
 =?utf-8?B?WmhuN1FHREU4eG1hcERFTVFNWStUNTJIK3pydWlqaGhJOUVSamRvNi9qRktu?=
 =?utf-8?B?KzlDREdVVllNOElPdUNJKzVtZ1plZFBIc0Eybzl6OTJZTGI5QjgxRHJTVkRQ?=
 =?utf-8?B?REZOU0FsTjRVTU1yWUpUSjR6NWVNY2FuZm1vRndsdmIrYTNEOVNBN24zQWVE?=
 =?utf-8?B?alNCQUtEeDJvZk9OcmxUOXpNSVBHUmlNM3A0VVk3cHBKRU9ERUJ4ellOT2hw?=
 =?utf-8?B?YVE5RmpzVlhYQm5pSHVOTzBNVWsvemlFUGNuSmcra3VLcjU4WTN3N3NnSk1R?=
 =?utf-8?B?LzFqY3Q1R3VnVVF6ZE4rYkxDaFZYVU8wY0wyTnVFd2NvRUZFR1dCRjhqSi9z?=
 =?utf-8?B?ZDNjb1F3bVRsME1tTWcrUFpXR0VmUGZMUm1IRkRZT0d5OU11WWJXSk9jSlJZ?=
 =?utf-8?B?OFJEcm5IdVgzRDA5d0ZHSVJncDBCMGhUc0ZMZnB5QVkwcXM2K25QbktmZlFn?=
 =?utf-8?B?SFJoU0NHUkNsSHdKWVZZMytKQTB2dFRwWmtwNG9Vb043QmFFVHJlS1dpYXhD?=
 =?utf-8?B?K0xxaENLUldaMGwvaUphYjlwc1BsV2RrL2lBam5vVzUxZm9nM0pnSFpQYVM4?=
 =?utf-8?B?R0tkSFFQYlpBMXpTOW5wRWMrbTdRdlFFRzA4RlpPZUd4YUtFblVFOXorcmZa?=
 =?utf-8?B?SEd4alFRUHgzRDE4U0lZVGdNVFFYTkkvMHR5SWFYS3hLQm1qQjNXTW13UU5R?=
 =?utf-8?B?eWZBQ25SR3VDa0FpZ1dPc29NWFo4Qjk4SEsxSy9ZQmw1bmxXUHR5SDB6WGNy?=
 =?utf-8?B?aHFqOWhHWnd4Y3p4VjlTbUZHRjBuTldZMy9XZld4a0VIRTVyNm1MS0V0U1NE?=
 =?utf-8?B?WStqRGZocFR1ZmY3MTlRbkZhMkN1NVJXanYrdWhGeFNwb04xeDdaUjdZeVJh?=
 =?utf-8?B?RFhKNDhqeDhGM250MDhyQ0RxSnpPVnZ6bHh6SnhRcVcvZEs2NXZNczViaHEr?=
 =?utf-8?B?cmQ1dTljcUtWZmZ4WUZPVHJiNFZnNHpZM0xQa0dJeXRsS2Y2ZzNaYVEyK1Ra?=
 =?utf-8?B?N0JvS3prSlRyeThjbXBvVmpSU2VVVW1OUHRVYnFQa1c5TFpHWHVTdHhWdmZ5?=
 =?utf-8?B?U3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 15afd9d8-10b2-41a0-14c0-08db4101d838
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2023 18:13:58.4143
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SNdialU2M5qIYVoJjefglKW6BUqASWdjx9Uvl/YqYm3k0L1ExQ6pZPXeDTnGKuIw1UtpyGMbRZZ3aV0hwQAPFFANGaXlnb+O8u8KEC9qhKc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5614
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Alex,

On 4/18/2023 3:38 PM, Alex Williamson wrote:
> On Tue, 18 Apr 2023 10:29:21 -0700
> Reinette Chatre <reinette.chatre@intel.com> wrote:
> 

...

>> diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
>> index a3635a8e54c8..4050ad3388c2 100644
>> --- a/drivers/vfio/pci/vfio_pci_core.c
>> +++ b/drivers/vfio/pci/vfio_pci_core.c
>> @@ -1114,7 +1114,9 @@ static int vfio_pci_ioctl_get_irq_info(struct vfio_pci_core_device *vdev,
>>  	if (info.index == VFIO_PCI_INTX_IRQ_INDEX)
>>  		info.flags |=
>>  			(VFIO_IRQ_INFO_MASKABLE | VFIO_IRQ_INFO_AUTOMASKED);
>> -	else
>> +	else if ((info.index != VFIO_PCI_MSIX_IRQ_INDEX) ||
>> +		 (info.index == VFIO_PCI_MSIX_IRQ_INDEX &&
>> +		  !vdev->has_dyn_msix))
> 
> Isn't this the same as:
> 
> 	(info.index != VFIO_PCI_MSIX_IRQ_INDEX || !vdev->has_dyn_msix)
> 

Yes, it is. Will fix. Thank you very much.

Reinette