Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp784324rwr; Wed, 19 Apr 2023 13:04:47 -0700 (PDT) X-Google-Smtp-Source: AKy350ZDc9LGWqYwkVmTQGeCfcyhEKAkMZrarJlqBY01DOCbKp59OLzq8VME9HguztLV3F9hAz+L X-Received: by 2002:a17:90a:1b69:b0:246:f70e:e2ff with SMTP id q96-20020a17090a1b6900b00246f70ee2ffmr4051339pjq.0.1681934687030; Wed, 19 Apr 2023 13:04:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681934687; cv=none; d=google.com; s=arc-20160816; b=JCY+H9NWJCq1KQXPXkTtBFbKkGa6X3bqUVDm4hCJMB37sPgFogwAez3DBT037CjF+U WzN3OTFMTAJyRFkvwy6GvSnzMxOTbhS9GDCAenDZcB6Y0Ri3BFHE+V6beI+JVNu9yMdu zGHkMm84JrM8YV4D4zMhNDKHMMhhhhKfRTJGg0yGECWLGp990VktfFGDNfLldZvTac2s n26YucJAEFjS+1Y55To21w+yIUVOf5C0r5mtGTfjaImvwElZ4p7n4PWUOqnImLg2YDDm CugjcMuq0JN6vC2Db5Hm9O6J0b54GBiWSBo1R5ayyiNCOEGTJNka0Iywxe1gJJdtSMrS r3cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:importance:content-transfer-encoding :mime-version:user-agent:cc:to:from:subject:date:references :in-reply-to:message-id:dkim-signature; bh=aG2oyidO/3m2kDZYbXNhq4HhXe3dEkszPNvOsprHRiY=; b=VONyVzyg7On9jNHapIM6yHGtrASeQ8Oba4nt4slrNp1spusoQqPVImFuxc7bEK6kjt Cl/3MKft3vWaGVSRDXrnR2VQJ6rWBVT+LIYf9lI661hqIM2tGH0njUWE1OP5GHmTUnC0 MWdP8+ca4ZQeDTctIx7Qgn70QdnrG+RWQllH++EOQm0MW6KaV584iGPp/mchq5zMLCe0 UcK927IpsornIPIZsJ+VJf/Ei6GTYVDQsIh8wSD6Lz390ZrwXN6CiePstc4qEUFoo/LZ QI3rjxUPH5ic+X7sF8dccm2Ei6Nlkp+DwykfN5DK78Ti6sh1gaeMCebCqE8NlrYbKxtR qHvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@panix.com header.s=panix header.b=fbBVOXff; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=panix.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s2-20020a17090a440200b0023f9cb51eaesi2300428pjg.84.2023.04.19.13.04.35; Wed, 19 Apr 2023 13:04:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@panix.com header.s=panix header.b=fbBVOXff; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=panix.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229664AbjDST4e (ORCPT + 99 others); Wed, 19 Apr 2023 15:56:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229894AbjDST4d (ORCPT ); Wed, 19 Apr 2023 15:56:33 -0400 Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7D96526C for ; Wed, 19 Apr 2023 12:56:30 -0700 (PDT) Received: from mail.panix.com (localhost [127.0.0.1]) by mailbackend.panix.com (Postfix) with ESMTPA id 4Q1s4D5cR2z48Rj; Wed, 19 Apr 2023 15:56:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=panix.com; s=panix; t=1681934189; bh=+fFGEN80heOFvMCfA1mGu8Lh0yeXbVFuWYiQrtdEiBI=; h=In-Reply-To:References:Date:Subject:From:To:Cc; b=fbBVOXffQL4DH5rHXTQjy+kN0stC8gnZWluumsN5sDK9enf/B8NFDB6Y3pqzJcPL6 LxjhVUNWX5afQJJwb/NI7BE7EeXDzN6+Z76UxAV2QzdEtqPJtTkDpxxwXaqYyE1srj ijBcSPgbHJpqMcx5TvF5vb6dWCZI1tszBIBE2sAg= X-Panix-Received: from 166.84.1.1 (SquirrelMail authenticated user pa@panix.com) by mail.panix.com with HTTP; Wed, 19 Apr 2023 15:56:29 -0400 Message-ID: In-Reply-To: <87bkjki8p8.fsf@minerva.mail-host-address-is-not-set> References: <20230419044834.10816-1-pa@panix.com> <87bkjki8p8.fsf@minerva.mail-host-address-is-not-set> Date: Wed, 19 Apr 2023 15:56:29 -0400 Subject: Re: [PATCH v2] firmware/sysfb: Fix VESA format selection From: "Pierre Asselin" To: "Javier Martinez Canillas" Cc: "Pierre Asselin" , dri-devel@lists.freedesktop.org, "Thomas Zimmermann" , "Daniel Vetter" , "Ard Biesheuvel" , "Hans de Goede" , linux-kernel@vger.kernel.org User-Agent: SquirrelMail/1.4.23-p1 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Javier Martinez Canillas writes: > Pierre Asselin writes: >> Fixes: f35cd3fa7729 [firmware/sysfb: Fix EFI/VESA format selection] > > The convention is f35cd3fa7729 ("firmware/sysfb: Fix EFI/VESA format > selection") >> + bits_per_pixel= max(bits_per_pixel, (u32)si->lfb_depth); > > You are missing a space here. OK. I'll fix that. Thanks. --PA