Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <457244a7-9d28-a19d-40a5-8d45861b709d@rocketmail.com>
Date:   Thu, 20 Apr 2023 00:41:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2 9/9] dt-bindings: Add documentation for rt5033 mfd,
 regulator and charger
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Sebastian Reichel <sre@kernel.org>, Lee Jones <lee@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Beomho Seo <beomho.seo@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Stephan Gerhold <stephan@gerhold.net>,
        Raymond Hackley <raymondhackley@protonmail.com>,
        Pavel Machek <pavel@ucw.cz>, Axel Lin <axel.lin@ingics.com>,
        ChiYuan Huang <cy_huang@richtek.com>, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
References: <cover.1681646904.git.jahau@rocketmail.com>
 <9275af790e6e21b5cf661a2444effe4caf2be02e.1681646904.git.jahau@rocketmail.com>
 <5b41b54c-88d0-3666-9db2-9cbb90ba8183@linaro.org>
 <acb209ce-7cb6-9a07-c913-9931b980c8c7@rocketmail.com>
 <a638055a-97c2-49ce-f301-45d0ce897df4@linaro.org>
Content-Language: en-US
From:   Jakob Hauser <jahau@rocketmail.com>
In-Reply-To: <a638055a-97c2-49ce-f301-45d0ce897df4@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Krzysztof,

On 19.04.23 10:42, Krzysztof Kozlowski wrote:
> On 18/04/2023 23:37, Jakob Hauser wrote:
> 
>>>> +properties:
>>>> +  compatible:
>>>> +    const: richtek,rt5033-charger
>>>> +
>>>> +  richtek,pre-microamp:
>>>> +    description:
>>>> +      Current of pre-charge mode. The pre-charge current levels are 350 mA to
>>>> +      650 mA programmed by I2C per 100 mA.
>>>
>>> minimum:
>>> maximum:
>>> multipleOf: 100
>>>
>>> Same for other cases.
>>
>> The "multipleOf: 100" doesn't seen appropriate to me when the choice is
>> 350, 450, 550, 650. Those are not multiples of 100. It's more of a step
>> size. I didn't find a general property for step size. Listing them as
>> "enum" would be another possibility, I guess, but not an elegant one.
>> Especially for property "richtek,const-microvolt" there are 30
>> possibilities.
> 
> Ahh, right. You can use enum here and min/max for other cases, where
> multipleOf cannot be used.
> 
>>>> +  richtek,eoc-microamp:
>>>> +    description:
>>>> +      This property is end of charge current. Its level ranges from 150 mA to
>>>> +      600 mA. Between 150 mA and 300 mA in 50 mA steps, between 300 mA and 600 mA
>>>> +      in 100 mA steps.
>>>> +    maxItems: 1
>>
>> Here are two different step sizes. The first few are 50 mA steps (150,
>> 200, 250, 300 mA) and then it changes to 100 mA steps (300, 400, 500,
>> 600 mA). How to deal with that? Again I guess "enum" would be a
>> possibility, but again not a nice one.
> 
> enum

Thanks for the reply. Looking through the properties, I get the 
following result.

   richtek,pre-microamp:
     description:
       Current of pre-charge mode. The pre-charge current levels are
       350 mA to 650 mA programmed by I2C per 100 mA.
     maxItems: 1
     enum: [350000, 450000, 550000, 650000]

   richtek,fast-microamp:
     description:
       Current of fast-charge mode. The fast-charge current levels are
       700 mA to 2000 mA programmed by I2C per 100 mA.
     maxItems: 1
     minimum: 700000
     maximum: 2000000
     multipleOf: 100000

   richtek,eoc-microamp:
     description:
       This property is end of charge current. Its level ranges from
       150 mA to 600 mA. Between 150 mA and 300 mA in 50 mA steps,
       between 300 mA and 600 mA in 100 mA steps.
     maxItems: 1
     enum: [150000, 200000, 250000, 300000, 400000, 500000, 600000]

   richtek,pre-threshold-microvolt:
     description:
       Voltage of pre-charge mode. If the battery voltage is below the
       pre-charge threshold voltage, the charger is in pre-charge mode
       with pre-charge current. Its levels are 2.3 V to 3.8 V programmed
       by I2C per 0.1 V.
     maxItems: 1
     minimum: 2300000
     maximum: 3800000
     multipleOf: 100000

   richtek,const-microvolt:
     description:
       Battery regulation voltage of constant voltage mode. This voltage
       levels from 3.65 V to 4.4 V by I2C per 0.025 V.
     maxItems: 1
     minimum: 3650000
     maximum: 4400000
     multipleOf: 25000

Kind regards,
Jakob