Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp92645rwr; Wed, 19 Apr 2023 18:30:13 -0700 (PDT) X-Google-Smtp-Source: AKy350ayt3c6vamQ+gXXa0gaXDIQ1x3M7X809IYzADNZ4XA6iLDDXH5OJ14E7wjLUICI9u9uiUvw X-Received: by 2002:a17:902:ea06:b0:1a6:f755:a4bb with SMTP id s6-20020a170902ea0600b001a6f755a4bbmr8500013plg.0.1681954213460; Wed, 19 Apr 2023 18:30:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681954213; cv=none; d=google.com; s=arc-20160816; b=VfwYqdAXONTQ9c/sxZ/mIvbtPDCWuYNFUWsmliqt/eCvaafK5WlMPaJetfddO0xJ+S KdOJV/PudgZwVj8kk1Vzc8OTJxmoL0pUVHy5AjZ3cTE2D/G97yvIrjElFmElXyWSgvi4 E0Gj2KjqIiEtzMCdfrQPlTc6inBMXGfjOLCpnGpjCo7ybjqltEY0IkiTAef6e0qenrv/ VIXV2E5oQ9S4EtauyzalE1lNWkggJf/WgW57fHn6QVT0CkMrm6bGTPX2txd3P7smYnPX cdFu0FKfELzK4Mac02z925mxTD6mrJ7bBu4NIFHy1ADkkHC9YXZCG25YA96FMBHQnKNJ 1AEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=1L0AZ1NKBslGoxerjSon1QK1hP9ccMa3ZTk8cZlumtk=; b=tGY5IA9jvX+GFe7ejnaLyKaPwJRnIwlOqdsJYt5k6WKdy4f8SOI5pfKKrPrUkNsrLG WFeOQC29WL55NDjrOfeumnrWR1jlJea/e0NWrw60seetT/wBNNPjsD7X2HCoBQNfROAI 4Nobz9szQ3fZ72/j0bDN4vgX3+BgoNK76z7+zcQ+ZYXB20w9LVO0SE9YTbSelqRWFWqD e/+4NIqoEt2nK3FWmnoBJPnkw3MQJSNSr2HWWSjeQavSYTztUHEwhd/44vPrcNsj3bCx h76CNbLXcc9mR+ZlP989KrDAF8P1qnNjeTAzZqVBIYPVWQ60l2/jqTiUNKquIpXTnvW1 acBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KT1yIXD0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c7-20020a17090ad90700b002473c0c9fe9si2981455pjv.50.2023.04.19.18.30.00; Wed, 19 Apr 2023 18:30:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KT1yIXD0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230217AbjDTB1S (ORCPT + 99 others); Wed, 19 Apr 2023 21:27:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229687AbjDTB1Q (ORCPT ); Wed, 19 Apr 2023 21:27:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D59D919B5; Wed, 19 Apr 2023 18:27:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 710E7641B5; Thu, 20 Apr 2023 01:27:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69C98C433EF; Thu, 20 Apr 2023 01:27:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681954034; bh=JAFjUrJMnv8cikWR/XW1+hs4l0JVb3ksyTOqOw/X9yY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KT1yIXD0TsWdMUwAWO810zqLOGwa/eC1gQfBFYG2sWNAKlo7kpSw+p5jkBp8dIlp/ 1DdQCrayVVgacux4G0csT2Esb8jz/72Wnr1FR9dUjOJ732B6KW3mYuslNhXms6Hld4 49i3s+h/TKiY1eCzXZ4N+UZbUpWN0j3jB1fS0YXESatS5wErF1C56xv/Pr4u7ZABWA nMp9tIFPZe7rAe29dS7LETt823H6jK9do3B92EAQX6eDzDniSH/kxLI3OakN1HenbH 0H7OYPSv4BDyogIt/fpCglo9nvuxx1kQxqMu4JhkxNFs18dNFw7aLoGitkgUV0q960 J2PJ+BtO2jTyA== Date: Wed, 19 Apr 2023 18:27:13 -0700 From: Jakub Kicinski To: Yajun Deng Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sched: print jiffies when transmit queue time out Message-ID: <20230419182713.2cd1f81b@kernel.org> In-Reply-To: <20230419115632.738730-1-yajun.deng@linux.dev> References: <20230419115632.738730-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Apr 2023 19:56:32 +0800 Yajun Deng wrote: > Although there is watchdog_timeo to let users know when the transmit queue > begin stall, but dev_watchdog() is called with an interval. The jiffies > will always be greater than watchdog_timeo. > > To let users know the exact time the stall started, print jiffies when > the transmit queue time out. Please add an explanation of how this information is useful in practice.