Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp119989rwr; Wed, 19 Apr 2023 19:01:56 -0700 (PDT) X-Google-Smtp-Source: AKy350b+6NVseAsm1OXoP+UPurALYzmMQIvQLqgShcYDbQgirdMvCBVVE61fhNEeLoajBD0Wd1EN X-Received: by 2002:a05:6a20:438c:b0:f0:4f05:69d6 with SMTP id i12-20020a056a20438c00b000f04f0569d6mr798119pzl.24.1681956116275; Wed, 19 Apr 2023 19:01:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681956116; cv=none; d=google.com; s=arc-20160816; b=NaPWWP2ockojbEJNxImcmKwS0lVfQqJk958J7rGSY2yuYjKwzw8qBuniZ0DR043dEv BjUSsMPuF7y4z2ry+TnB9vyyd6wmw4ANfcbJ+xymsocAWaISzCYlIqm+ouooa+Fr3827 TrfgiYcUQyHp2PzFH/lD7Lg4bQyOTKGcLufq2hxclkSRQmgtQ89i133BhkEFCKXpwPGf GPwa7d36Fr9JDQWo0bgk39lcysEsc83yVDt/zX+ASL7wK1Tw/8YvAN+pMlmOzj+giwzu KA6ACwcZ6uxJgAAAvYsWzqzJL1WuNfXpMJCpTFRDJkCN/4xiWZDyOIcIj5MBErhSHgMr B0rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=uRHcymisTbjiBf6eWzZPbcaSHTQevSe81zNyL32cDvU=; b=nfqXtW6Yry+7xKZRIz7EG4KIK9sfirnx3FGCK8VdX3nENwSr+VGUZHXbHNVEfe7I6T N/ze88cvQVARRX9M0lLZg/M7X5IXSQYIMmWjaQN3R98X4Onl2IjJrGdrIX41rR875HB2 L0jxBkhnyVvDzQ4ftDq/Krm01VNAv5d5f3Onhu+pe2Q9XNr+sLJaNWLb/8qj0Reo/H1u DHmCKY3zsOLutkzosYXKm3KYLEofoYU4RPxoOUPVDRTuc4m9va0Vaqja4YRUBZpxlD/K 0VAmcKW+hgy7gW2uIesjp799ib7RoIs6xHVvPCkQ6pZ2ilyKTkGZYMNYcXUNl0x+WpnV e/PQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=krhyCaDJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j23-20020a63cf17000000b0051384f6edf2si166897pgg.640.2023.04.19.19.01.20; Wed, 19 Apr 2023 19:01:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=krhyCaDJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231241AbjDTB7W (ORCPT + 99 others); Wed, 19 Apr 2023 21:59:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230081AbjDTB7V (ORCPT ); Wed, 19 Apr 2023 21:59:21 -0400 Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5895170A; Wed, 19 Apr 2023 18:59:19 -0700 (PDT) Received: from localhost.localdomain (unknown [10.101.196.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 916A741ABE; Thu, 20 Apr 2023 01:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1681955958; bh=uRHcymisTbjiBf6eWzZPbcaSHTQevSe81zNyL32cDvU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=krhyCaDJJrOGxSCNeq+hJJTpAxyQFFwUMA2ajAcje1eWMWOYGhKUx8gX0DFmexjgQ eu+Ev/aQ722WUrCSYAWPcJmMDQT2X4LivX+s29pQ3+B9iHmVTAOae+vSMdna+auxxk 8JoqAKfLAzo0U47lVkqVO4coAIC9iLP1+2tvGKhZzkiyEhsnzlGIAjeSQ1CsCBFIYZ 1RRzty+DF0uQxrcNatimBPx6ZOCbUxgjMSG2KmDV6w48G/C0zWLHRLkzwmHKsfidYl yCxpIPknuP76Kjy5xnZmJbIZ/tTNVMd1zzFvWTddHNCRdT0L22eFHwE+vpZPJ7ctkQ BTdaSqoDLunxw== From: Kai-Heng Feng To: bhelgaas@google.com Cc: mika.westerberg@linux.intel.com, koba.ko@canonical.com, sathyanarayanan.kuppuswamy@linux.intel.com, Kai-Heng Feng , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/4] PCI: Keep AER status in pci_restore_state() Date: Thu, 20 Apr 2023 09:58:27 +0800 Message-Id: <20230420015830.309845-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When AER is using the same IRQ as PME, AER interrupt is treated as a wakeup event and it can disrupt system suspend process. If that happens, the system will report it's woken up by PME IRQ without indicating any AER error since AER status is cleared on resume. So keep the AER status so users can know the system is woken up by AER instead of PME. Signed-off-by: Kai-Heng Feng --- v2: - New patch. drivers/pci/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 7a67611dc5f4..71aead00fc20 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -1778,7 +1778,6 @@ void pci_restore_state(struct pci_dev *dev) pci_restore_dpc_state(dev); pci_restore_ptm_state(dev); - pci_aer_clear_status(dev); pci_restore_aer_state(dev); pci_restore_config_space(dev); -- 2.34.1