From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Andy Whitcroft <apw@shadowen.org>
Subject: Re: [PATCH] update checkpatch.pl to version 0.10
Date: Fri, 28 Sep 2007 12:46:45 +0200
User-Agent: KMail/1.9.7
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>,
       Randy Dunlap <rdunlap@xenotime.net>,
       Joel Schopp <jschopp@austin.ibm.com>, linux-kernel@vger.kernel.org
References: <bf97f66cfc0696c8574921d53eaafcb7@pinky> <20070928093902.GA28455@elte.hu> <20070928100024.GB18163@shadowen.org>
In-Reply-To: <20070928100024.GB18163@shadowen.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200709281246.45546.borntraeger@de.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1440
Lines: 36

Am Freitag, 28. September 2007 schrieb Andy Whitcroft:
> > And this is not about any particular false positive. I dont mind an 
> > "advanced mode" non-default opt-in option for the script, if someone is 
> > interested in borderline or hard to judge warnings too, but these 
> > default false positives are _lethal_ for a tool like this. (and i made 
> > this point before.) This is a _fundamental_ thing, and i'm still not 
> > sure whether you accept and understand that point. This is very basic 
> > and very important, and this isnt the first (or second) time i raised 
> > this.
> 
> You are striving for a level of perfection that is simply not achieveable.

I dont think Ingo is looking for perfection. Its about a different 
optimization goals.

Let me put it this way:

checkpatch in advanced mode:
- I want to be able to see as many possible problems (this is the optimization 
goal)
- I accept that I get false positives
- not useful for git and mail traffic

checkpatch in safe mode:
- I never want a false positive (different optimization goal!)
- I accept that I will miss several real bugs because several tricky tests are 
disabled
- useful for git and mail traffic


Christian
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/