Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org
Cc:     chao@kernel.org, frank.li@vivo.com,
        linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        mhiramat@kernel.org, rostedt@goodmis.org
Subject: Re: [PATCH v4 1/2] f2fs: refactor struct iostat_lat_info
Date:   Thu, 20 Apr 2023 11:30:39 +0800
Message-Id: <20230420033039.72746-1-frank.li@vivo.com>
In-Reply-To: <ZEBPwz4fJATKs22g@google.com>
References: <ZEBPwz4fJATKs22g@google.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gUkyuIDFl2niyfCQUzx25bHPxB1EqfB8JeDSGuGgIGCxUO6NWyrnk9d4lgrz?=
 =?us-ascii?Q?l3975q6xEYJCkKEVIXHrApz9g2ErXLmIMyhjimaLs8wOzkHlai7ENifTdSNE?=
 =?us-ascii?Q?QgKcb9nP7rFRRu8bewMgBMlL1OWD0SDnfJeIoVRHtqRMVpMmnEJBu2jWVaA1?=
 =?us-ascii?Q?+Jw4yYDhfRG99/sYKQ7it5SDhSv9ro6W4tyBqc3w4XsqjMPvU6Uenb8btz98?=
 =?us-ascii?Q?FmsfMY8X2jWwGdp6Hs2onnhU0GAPAnZRZLFrOI7MX/3l8uoIq66mPyziDsOW?=
 =?us-ascii?Q?vDgSx3QzlIsKixllmyuxJiStvptrNcPFZFxgoPeh1sRrR09TdyDwcDNP+Um/?=
 =?us-ascii?Q?VVRasDY/soaZroGbGUx3qCde3A9SzgDMncHbWFkEK8w7IUYDuJ6qvRDOGtuy?=
 =?us-ascii?Q?3RT73Ur/pivmSCmuB+ZcZiNFIt9wkdACDTiEuJwizaLEa26SB5f8kZGpe3if?=
 =?us-ascii?Q?VQbzWTblP8BRMsXMpzvuTok1emLERLY+xYOjrW43xgMwRXz7cK7NcnA5hNMS?=
 =?us-ascii?Q?B6TmesEfU/OpaoDgN3z982EKZS7XyvvVofLg1e0USu3OVZQf+R3DvY4jSxDd?=
 =?us-ascii?Q?XZSl95hwcw+PRYFIsePdcafZ1xRqUe+5C25YdYoUnChP8vkaB5tKMmHmwPIj?=
 =?us-ascii?Q?KEFxpIfpLzE/2E+RgHCtmbK10QxWDtChT679cS1tzUu2G0QW5olZACzt+0ui?=
 =?us-ascii?Q?5wsE2glBldeSxscv2KB1JJQ0IRaT4FcyXMY+8oOdLlNJ/45Z3W9cyWksgekA?=
 =?us-ascii?Q?Go6NVdr0lfd4SFf5efz71My1YSmgwrY0Ry1VX/ojQtu+M9o0mtX7yb+c2deY?=
 =?us-ascii?Q?QCN697e+ms8xDWm3D8MNy674YPLm7ICA8V4TTEsOhB0loivgHxKOE3jxWTkO?=
 =?us-ascii?Q?Gg655jo6wzTT3vLPblgUUyZ6xJCzhvPe3Rw/RaUGtI+1DJzcUUdnCX/4L5iw?=
 =?us-ascii?Q?VxXfIzbDsrn+0enWDWA54OCwU38f8K201RRIyx3LYHiH0GopG30Wh2PwHR2d?=
 =?us-ascii?Q?VUUOIoPCzNOvXYxVVAQ390+SPVzywOorwr0Ba8gTl6UaH+xTAl0Mf7siqRQH?=
 =?us-ascii?Q?F5qXMQ7aPrUckUs//H04NLOT4nnH9946Nw2/HbXqOObU5V4YKYlKWhSySpdO?=
 =?us-ascii?Q?TUUU6F8UkqLf7NrNvIxy7l/kPkE+0XECmd2ANegSQBPAu77zXCyo4Pvbdeo2?=
 =?us-ascii?Q?Ns/9MG3GeKBNLJmFGKkRvU02I1KkVuTHefKIODpwdh4w4lXHwzSAV4O7WF/J?=
 =?us-ascii?Q?bz7fCVeMw1um31Q8uGxFrsESQMzPOlPBr8jnp3A/VU/B7522XjOIJzFsB74w?=
 =?us-ascii?Q?TVmStyYgYf1jt0sKZdNaqXXSgPCjnjEAMePsFO15hWA3RmUA+FxH8CJ9r/Qi?=
 =?us-ascii?Q?aFUX4ehDxaBEIL94rK5aYi2c4mquyXSBJH6mczKB5HFVMG2k+Mz+vE0xMSA1?=
 =?us-ascii?Q?O4hbGNblCX4c4Gikz+7VQKJ99tDvBwogvMiy/b2MOoo+vyhSFTcdL7x5iZfp?=
 =?us-ascii?Q?XC2Xb4kYuWBCKXZ5dfu8+tBnDU4PpIOZkdqBdLNu1PwODu8MvFkZ29K6eUzm?=
 =?us-ascii?Q?UQ3j9n676yGn9PzjxMPFE+CtwCMBHEpPPk3G2MGc?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a06ceded-6131-4005-e21e-08db414fa24c
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2023 03:30:48.6700
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BYyjqd2JmhRfD/tpBl+NERMhpz/f6oWTOmS2hHZco6fRXfu5yj0u3Zj2GlA5seztZtrmPG4kwSc8zLZXR3d3Dw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4139
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +		ctx = iostat_get_bio_private(bio);
>
> This ctx is not used for iostat.

Considering that the next patch needs to store the discard_cmd pointer
in bio_iostat_ctx, there is no need to add a new variable.
We just need to rename post_read_ctx to data.
Change bio_iostat_ctx->post_read_ctx to bio_iostat_ctx->data?

Following the above logic, should get_post_read_ctx be changed to iostat_get_bio_data?
Since the function is located in the iostat file, we added the iostat prefix.

Thx,
Yangtao