Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Apr 2023 09:23:12 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "Hans J. Schultz" <netdev@kapio-technology.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Ivan Vecera <ivecera@redhat.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net] net: bridge: switchdev: don't notify FDB entries
 with "master dynamic"
Message-ID: <ZEDaUOBZL05fIFp8@shredder>
References: <20230418155902.898627-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230418155902.898627-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8Vy4BHc1532HisbyFSQcYIJJ2rAJ1K82nfffgLT4Gykt3k5WE3jNBzZ1TmDs?=
 =?us-ascii?Q?UhLHp+By/2xPmj4wqMK3Ay3njtr3X+O3R2jJ81ER/RKpl5gw4uWG8uY0at/n?=
 =?us-ascii?Q?Cw4/bjtNs/Gq2ZAt4v2ZC5Ac7rtx9nCyCCqqZDnakMS5PediyU5KubGjqURg?=
 =?us-ascii?Q?KyUGBn5uhBg3/kGLzdlnReNNjEFcjKygV2k1nZDa3y7EDUDDB4IrKscZ1V6F?=
 =?us-ascii?Q?y3d+OK/ApKwN8AY5wp84+BdOYfdupXNAsFTvo2CZ+ikqEFmiX+QvntrrlwFk?=
 =?us-ascii?Q?i0NdlGFPtOwh6+K5txSpyLSWtgfy5Fme18QRMj8QhfhPam+lQjrW/xQYnkLK?=
 =?us-ascii?Q?sH+wstuaatUoavZW2DvrFTQ2FBr+mWVD40J5ul8ag3QTaNkRX93wrrQHNfAs?=
 =?us-ascii?Q?FdB5M6eoDQbQgIT33JVzLBk7vfbFC2EnlEHREWAWLSL7sGW1WojRyJDvaxOG?=
 =?us-ascii?Q?cMweiadhViRUetaBgrWHbC5ta1AiDQsOT2lpfzBZ86D9TTJ+/Enax4dt8zjx?=
 =?us-ascii?Q?aM20u8sXif/IZGcxPoQHEG9ikb2M0xFCebVdcsQj2ZTWGiUfILs2pMNkSAzb?=
 =?us-ascii?Q?ZlGT3ZAf6kYFtTNnmTbIlBM21d4iJw6I50mVeNMLKhvyPaLQOqrwmEW1zKlD?=
 =?us-ascii?Q?CdJXunMmwOyE3luO7HTDeyec3bSSrLdv1Lda0aYj/WQNqCJyaarfDZVcRNen?=
 =?us-ascii?Q?U/CCbs1bPnEwMbwV4UIm5x5y6QUzOHRwrd7JI5jvQ0kNGvLtdaTFOzHKhGiy?=
 =?us-ascii?Q?XhXl17ZCt/JdiUOT7re+pd9wFJNm0MsV9RCIyiVw0FdCHrOxDwfL86qIzS1z?=
 =?us-ascii?Q?dmFUsPM5Xxvu7jNfXani2cUnWz7Oe6psh2gXYsa5OIrJrj5gAIKYdpFP8w7y?=
 =?us-ascii?Q?qdyT4F+U0h9VWhXFWq2dAT/WYKHDItjD/LZSj2Nugl9It2fFe/C1X3b0Tuh6?=
 =?us-ascii?Q?qPvKqzAmajjYkgM1r75dH0ndI2JTFDui7usvAr4xSFtUKw7llocV9M+Hc9fe?=
 =?us-ascii?Q?PfiU1bIyAcDoMrCpQ7ETLAh9d1GETQpaIuOl6vNBeMxlf+IdtyMvv4tSx4Vk?=
 =?us-ascii?Q?ErHuV6PyZblIvDWbguta/E2r2v86WHrpx2EGr5wRjYSD0Vu4zNMfK9dWQ9ln?=
 =?us-ascii?Q?kyYq/ee6wcUuzkQGUv3YPAgE7tJ039x3ofBK31kjHYbPlr4Lyt1DzZKyfOea?=
 =?us-ascii?Q?A5Xk7opeutnC7Xlqrle8v8KOXINqBY+s7n2bUtXDZ0CDU45k/P3XXftMTWjt?=
 =?us-ascii?Q?Uhb3E70h39qvOpN+dgKCBEQlQh7tKLx5fTpHeuKQWUBTb+o+EyHj6Bl45Jqd?=
 =?us-ascii?Q?4J7/UuImMczETd4LHLP5eIfIQd3hpIkSUIjoOv8E6YBDRRTCFFVQa1p74XjL?=
 =?us-ascii?Q?xjER18TnkzYHpsADahz5OGfR7ExK+svLVRB7T2f/BiiQBzHgx2SfnnxQ1XZA?=
 =?us-ascii?Q?Aec2QnDzCITz2hyTJckE//PYMUSGQh1K1rVVErgqGY9gGRh3VUHF+5J3c1kB?=
 =?us-ascii?Q?xdQwRrrBe9KxLbQ+XkXU4jm11tY1u4PVoXSfmWc48BMhIJGHYMDw/l6USELL?=
 =?us-ascii?Q?W+AaZFMxxfrJzqkLB4l2hlgv6tYwCITzBkf+L6uq?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46254599-6327-4454-59ef-08db4167bbed
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2023 06:23:19.5747
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Am+OlPJTfPTPIg7pquXi+x3xDjYgHHpUnWVXjeMXTdfqcvTHKrwjCdE6+aS8eLV6mQNAlRRYYPJaJFF+TB7R2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6865
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 18, 2023 at 06:59:02PM +0300, Vladimir Oltean wrote:
> There is a structural problem in switchdev, where the flag bits in
> struct switchdev_notifier_fdb_info (added_by_user, is_local etc) only
> represent a simplified / denatured view of what's in struct
> net_bridge_fdb_entry :: flags (BR_FDB_ADDED_BY_USER, BR_FDB_LOCAL etc).
> Each time we want to pass more information about struct
> net_bridge_fdb_entry :: flags to struct switchdev_notifier_fdb_info
> (here, BR_FDB_STATIC), we find that FDB entries were already notified to
> switchdev with no regard to this flag, and thus, switchdev drivers had
> no indication whether the notified entries were static or not.

[...]

> Fixes: 6b26b51b1d13 ("net: bridge: Add support for notifying devices about FDB add/del")
> Link: https://lore.kernel.org/netdev/20230327115206.jk5q5l753aoelwus@skbuf/
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>