Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52028f1a-e7f4-0ffe-e359-d95fbbc86cf0@quicinc.com>
Date:   Thu, 20 Apr 2023 12:42:24 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH V6 0/3] rpmsg signaling/flowcontrol patches
To:     Sarannya S <quic_sarannya@quicinc.com>,
        <quic_bjorande@quicinc.com>, <arnaud.pouliquen@foss.st.com>,
        <swboyd@chromium.org>, <quic_clew@quicinc.com>,
        <mathieu.poirier@linaro.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-remoteproc@vger.kernel.org>
References: <1681971690-28858-1-git-send-email-quic_sarannya@quicinc.com>
Content-Language: en-US
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <1681971690-28858-1-git-send-email-quic_sarannya@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/20/2023 11:51 AM, Sarannya S wrote:
> Added new IOCTLS- RPMSG_GET_OUTGOING_FLOWCONTROL and RPMSG_SET_INCOMING_FLOWCONTROL
> to get/set the rpmsg char device's flow control signal.
> Updated the cmd name 'RPM_CMD_SIGNALS' to 'GLINK_CMD_SIGNALS'.
> Changed 'remote_flow' to bool type, and updated it's evaluation.
> Updated evaluation of 'set' in rpmsg_char as 'set = !!arg'.
> Add destination address of endpoint as parameter in rpmsg_set_flow_control.
> Addressed review comments to change variable names/descriptions.

Something to notice, you are not changing the version number as you have 
sent v6 here again.

Also maintain the changes happened from the last patch series properly.
Like

Changes in v6:
  - ..
  - ..

Change in v5: (a lore kernel link will be helpful here for reviewer to 
remind the conversation happened during last review)
  - ..
  - ..


--Mukesh

> 
> Chris Lew (2):
>    rpmsg: glink: Add support to handle signals command
>    rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support
> 
> Deepak Kumar Singh (1):
>    rpmsg: core: Add signal API support
> 
>   drivers/rpmsg/qcom_glink_native.c | 64 +++++++++++++++++++++++++++++++++++++++
>   drivers/rpmsg/rpmsg_char.c        | 49 ++++++++++++++++++++++++++----
>   drivers/rpmsg/rpmsg_core.c        | 21 +++++++++++++
>   drivers/rpmsg/rpmsg_internal.h    |  2 ++
>   include/linux/rpmsg.h             | 15 +++++++++
>   include/uapi/linux/rpmsg.h        | 11 ++++++-
>   6 files changed, 155 insertions(+), 7 deletions(-)
>