Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "leon@kernel.org" <leon@kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [net PATCH v3 10/10] octeontx2-pf: Disable packet I/O for
 graceful exit
Thread-Topic: [net PATCH v3 10/10] octeontx2-pf: Disable packet I/O for
 graceful exit
Thread-Index: AQHZc1i/gnFrwFaccUCAsSMTLCDfZA==
Date:   Thu, 20 Apr 2023 07:21:39 +0000
Message-ID: <BY3PR18MB4707BAD375592CB7441488B3A0639@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230419062018.286136-1-saikrishnag@marvell.com>
 <20230419062018.286136-11-saikrishnag@marvell.com>
 <ZD/KklR3coHRY580@corigine.com>
In-Reply-To: <ZD/KklR3coHRY580@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TlzSa/l1GZrIoWv/FDKJxzz1oUedfSWZ2BStT7x8yWRxQWAmqL7ryTUuKlOd?=
 =?us-ascii?Q?hZu5NXhcCdhvzCDT4fZrEaz/nggCVou3sWorWT76m/WkTCCbRiew20asPd6Q?=
 =?us-ascii?Q?9VnmPzqeptc/QGN3w220FPoesFfIjVip7N8TIcs5lryu6mdECUoEJLxSnKpA?=
 =?us-ascii?Q?YEaC8eUo+kyp01nRVl00IhIqmY7m+DIifEYlEo3eElEoOumMDQ+oWJBfHThH?=
 =?us-ascii?Q?UBQ/iBHH62d6YyGhyleFjPhml+WZkBEAN3CUZnUlx9rNangMbr8e5qOuKZcu?=
 =?us-ascii?Q?QVYzAutZTl6O4ZyfZCg6mcOw6wkQ+SoZT1SRFDMa1/NSg/MXfJndLvnW7Eji?=
 =?us-ascii?Q?9gbDv6B5brlF3SislXJ+9BFafM3BH5V7Vrtiqu2R6hkgyE+qY0k4kxg6+3P9?=
 =?us-ascii?Q?b22AxkOPpyQo52JtG5O8ap09rVyOOMWuhOuyKFFngF/Wlay848Q91IZ2VOdj?=
 =?us-ascii?Q?zz4WBoJYTDi4123Bq6w8YcPn6rcch3hTNBX1qRVFajwumgaFVdlilFyBGOpC?=
 =?us-ascii?Q?47F8LX8ZYoz4gi49hy4UuxlfqJJYFtqWRrvzg0xBtLKA488inf73Mh7QhoOa?=
 =?us-ascii?Q?2EeaVY3VBRfKhWQGfEE3ITesCeF0thIVp1qYCvAhos5lTAL+XrU+YG7CubZi?=
 =?us-ascii?Q?F71hVA3uc/yXXPJJKabJHcB3778MIDUgFzcVQXzEEKi9D8Hi4S1CjeWumsRr?=
 =?us-ascii?Q?Yva3IZPqceeEzsOro/BcNFx0wbzYhWYQmSXQRUpMwUqgcRIjtTThHD4kQd1L?=
 =?us-ascii?Q?auRK4kZog8PJ04xoD2HPTDi0g2t1Icr+pSbq2D8m/j9VjsdICIbxGtlWiIIs?=
 =?us-ascii?Q?t9uTZISpo6kPYDdCAT5kPGMegVKhYJjYL6T5Z9sMaCaJT7UM/U0MHgDHbMaE?=
 =?us-ascii?Q?GqcfmCE/QM8Rrz8YDWdZG3Cgi0ZaWpRMgOegMELm2Cgx0Ta4ByuVfvnaq0J2?=
 =?us-ascii?Q?rhNtPM8NFy0uV5A8sFxaagfnGfuaXb7NbVq1n2tQFaSkXRjJ4Qp+Ao2nX664?=
 =?us-ascii?Q?G7yh9HwUYz6KQYqg/0pAjMGIgNnhi4bHbjNb2qDxAZaaUhKy7HU4w3s5GN4T?=
 =?us-ascii?Q?o1OpNiQpFnYz42u7XCCwgjwM4Oc7AD064R5e1gbmxp13nE9jSKULMz9VK7Ep?=
 =?us-ascii?Q?oKFjIzdRCYVI3krEm/U3hH+ggH7cWHZMmtP4FM8soQbFc302oWX1Jm4mFmjD?=
 =?us-ascii?Q?cTPzM0xJcfECqI7Mwbev2TISLaBIsxb+ZkGL28L9zcgSAiBOx5iS+i8OcU/x?=
 =?us-ascii?Q?Dry67AyCN/w8TJXg0GU5OY5mPiYkNhvEXvzmb5wPPhKdr10yMXl3xPiyYeaY?=
 =?us-ascii?Q?mr7j1xIz8km9HBtCAKaVP0tsKJlbERiGijdRMwA9CNiXVgge9/BBU7g8F3Vh?=
 =?us-ascii?Q?cZwBAPD7s9Muo7nO5sZIDofGfq4ulcUOSQ5nwtss4hpeVYKGUB+ey/8gYE9Q?=
 =?us-ascii?Q?4Cm7GjwK1FIArF1jumKFI0L+pV5V0S1PHa5o+YptPOUPTCMLdUaBkEn5ec41?=
 =?us-ascii?Q?1DHFzLUkXQygLp/geg5+gDCEYBwc1SXdkeGhhFg3hQr7nxpJyfZcyKwE8aki?=
 =?us-ascii?Q?Yj6U7L6vqMsMfZcp78x19HO7cv7wHn+ukYz/5jCQ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d1039e7-a742-439f-3dfa-08db416fe283
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2023 07:21:39.9985
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ukGsTnAVKZZAJwyqAe35LCDo/x2nJWCrA5ylPiuz6+3qFrpxr2heahzFcwFpzwcrPeIgsb30+y7WHZ3tmYA3Tg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR18MB4291
X-Proofpoint-GUID: WCPzR3f_qly64L5sVJZigh6-FzVKP876
X-Proofpoint-ORIG-GUID: WCPzR3f_qly64L5sVJZigh6-FzVKP876
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-20_04,2023-04-18_01,2023-02-09_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Simon Horman <simon.horman@corigine.com>
> Sent: Wednesday, April 19, 2023 4:34 PM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; leon@kernel.org; Sunil Kovvuri Goutham
> <sgoutham@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>;
> Linu Cherian <lcherian@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
> Subject: Re: [net PATCH v3 10/10] octeontx2-pf: Disable packet I/O for
> graceful exit
>=20
> On Wed, Apr 19, 2023 at 11:50:18AM +0530, Sai Krishna wrote:
> > From: Subbaraya Sundeep <sbhatta@marvell.com>
> >
> > At the stage of enabling packet I/O in otx2_open, If mailbox timeout
> > occurs then interface ends up in down state where as hardware packet
> > I/O is enabled. Hence disable packet I/O also before bailing out.
> >
> > Fixes: 1ea0166da050 ("octeontx2-pf: Fix the device state on error")
> > Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
> > ---
> >  drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 11 ++++++++++-
> > drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c |  2 +-
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > index 179433d0a54a..52a57d2493dc 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > @@ -1835,13 +1835,22 @@ int otx2_open(struct net_device *netdev)
> >  		otx2_dmacflt_reinstall_flows(pf);
> >
> >  	err =3D otx2_rxtx_enable(pf, true);
> > -	if (err)
> > +	/* If a mbox communication error happens at this point then
> interface
> > +	 * will end up in a state such that it is in down state but hardware
> > +	 * mcam entries are enabled to receive the packets. Hence disable
> the
> > +	 * packet I/O.
> > +	 */
> > +	if (err =3D=3D EIO)
> > +		goto err_disable_rxtx;
> > +	else if (err)
> >  		goto err_tx_stop_queues;
> >
> >  	otx2_do_set_rx_mode(pf);
> >
> >  	return 0;
> >
> > +err_disable_rxtx:
> > +	otx2_rxtx_enable(pf, false);
> >  err_tx_stop_queues:
> >  	netif_tx_stop_all_queues(netdev);
> >  	netif_carrier_off(netdev);
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
> > index ab126f8706c7..53366dbfbf27 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
> > @@ -621,7 +621,7 @@ static int otx2vf_probe(struct pci_dev *pdev,
> > const struct pci_device_id *id)
> >
> >  	err =3D otx2vf_realloc_msix_vectors(vf);
> >  	if (err)
> > -		goto err_mbox_destroy;
> > +		goto err_detach_rsrc;
>=20
> I think it would be worth expanding on this part of the change in the com=
mit
> message. Because it's not obvious to me.
> And I do wonder if it is a separate fix.
>=20
We will expand on the commit message and explain about this in v4 patch.

Thanks,
Sai
> r
> >
> >  	err =3D otx2_set_real_num_queues(netdev, qcount, qcount);
> >  	if (err)
> > --
> > 2.25.1
> >