Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "leon@kernel.org" <leon@kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Ratheesh Kannoth <rkannoth@marvell.com>
Subject: Re: [net PATCH v3 02/10] octeontx2-af: Fix start and end bit for scan
 config
Thread-Topic: [net PATCH v3 02/10] octeontx2-af: Fix start and end bit for
 scan config
Thread-Index: AQHZc1pH8Fceaq+veUyx9OFpGBUhWA==
Date:   Thu, 20 Apr 2023 07:32:36 +0000
Message-ID: <BY3PR18MB470755330B9DF76944DD1493A0639@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230419062018.286136-1-saikrishnag@marvell.com>
 <20230419062018.286136-3-saikrishnag@marvell.com>
 <ZD/D7j+LPRIbP80J@corigine.com>
In-Reply-To: <ZD/D7j+LPRIbP80J@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?12NKMF/5kBKeF+nVR5vPJnX4fbZt4L8dB2fnPGqB/6b2YFE4m1Td++aMi0df?=
 =?us-ascii?Q?/3PQtjYWLwrYHe6NJeek5EYKymwLowzYKGrWtpwsHbdU14viZPwVTc1rpESg?=
 =?us-ascii?Q?/oHg/q2LszLPJKiOY3zVr0jZPF6BK571vzZD2xfHMR9OZ9Vwhy6cuQS/p07g?=
 =?us-ascii?Q?nkgjqfJhoyuO81h9SD0NCSH3SuyyQ2lK5+bQMUg28jG7MfhjnA+1lFnquwgH?=
 =?us-ascii?Q?EW0BRhzoE2xytR1VcMKWHaEEeHqpoFOFXB5jlkVwo6p2nvfIHJanhgqe5i2n?=
 =?us-ascii?Q?jdpH0BgDrfRZ7oxj9L7uyviqkI7LsFJGXC60ZLHnms8YXmPJvbLYwFS0MZBD?=
 =?us-ascii?Q?4uVQerSAYMGV8r5og8P/NNnTTyDRBJXSZH4WzJiD+Of2MQG1tXWsXn6OTOWX?=
 =?us-ascii?Q?5gktfaX0AY4rP6OAjh7XPGV/C8yOocloPfg026imXKH9oM/z6xyaAuOUT4OH?=
 =?us-ascii?Q?9b2hOKS53DkXW+juyvm+H7lSqLhzASRlPktke0nU9Wyt78QmM9Q9vCASS+Si?=
 =?us-ascii?Q?K5ZzfStG64VkfnZvN0Qpfycda5g2T4yAz92PRycA98uMgD0RnZowhg+u3DV8?=
 =?us-ascii?Q?2Ezu3sy035V61w3cmNGQuIqW6uqKZ/a3sItXiZBd+XgPucggCjzBvZS2RJ1t?=
 =?us-ascii?Q?OislAuLuNghidO/+5nXxJ5VBHzGhAe522sZuxzhIzHT3sXgvDcdjsy2oU9D9?=
 =?us-ascii?Q?oi9X9bwbjiyd0eeAU8m847uSKIxvo6fKoUDlVeasyjrXkRa5P03Keb1OAjjp?=
 =?us-ascii?Q?t86vMW2YXTWxT2kyhnkU2EUwamCFB8v3eC0cq+OLoKDEtYvITmIsDtMun45E?=
 =?us-ascii?Q?ZuHP3BQj3WaZ7tzWFcFsUFrkQJyR8VKTpTIMa9SMMh+LSxTP1u4mmv2w4XkE?=
 =?us-ascii?Q?4VD36N2Eo9r1auBhbWrDT8BLFxgFUL7Z3p5OTvl3yqaw5fXFkyVmlKJTVU5h?=
 =?us-ascii?Q?0o6qj1AAP1rtbqoONickgvPy7e+QYCK/Hdeut7rnluJhGm97kTSsiAw8FnhX?=
 =?us-ascii?Q?Cgow9WEzrX4puJDtzRFda1/0FczR285OgyB2sk+geUWsOggwaagQRNME+kgc?=
 =?us-ascii?Q?kV7OrNgyQAHEh+6t+FpDe1+jAUDltPXrd1CsJ3l8O4Up0f5QAmXknN3GbGIb?=
 =?us-ascii?Q?ixri2kHCQOmLkWit+yUgWYqP+Im6TzGXoSgKzNJ/rQELMjnBxqYTW+vSRHJk?=
 =?us-ascii?Q?AbuaEl4OcNdQZiSp3VttzizyasCPCBRA1mtuu4mXE4eR3qbc1hY6Ug8AedXK?=
 =?us-ascii?Q?HqrgNFl9g2q85MtFyGwGWv7ymTtZKsTBF3GSSIYklpdNOhnd14Z+ToHAUspy?=
 =?us-ascii?Q?yzggwcp0g5lNmg7mfr/+3k+n42/XAjUHTKEDRep3GTCYJwny5/vXYHB3vhFL?=
 =?us-ascii?Q?IjSTtELNjODpIt0jDZPSdOOu16v8EtWObX3MaveisvYkUbWP0QJhtVNmlNL/?=
 =?us-ascii?Q?OxfrwfuVmmeXsOqhRGSLzp8lOs2TQWjH9QxiI7UJud735GI3gO2gUIrxbr8K?=
 =?us-ascii?Q?fFdNfjnA8kK1HbYZYnGhmcqmQ63AWas6wMJEWnl8USGxHBNuexfKB0h8ZLa5?=
 =?us-ascii?Q?9eDTQRJb+rbfB7fv8HaBbwcBzXWOXVA35yMFWlUd?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f869c04-b893-4588-ba70-08db417169d8
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2023 07:32:36.5773
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /GtJ9S/LHh6f7dR9/LLz/yzfnyNPl0ilXUD2BDui9y70+syOuM5XYsVby8ofFc9IKjCrOnLvqpcLteh7md8w7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR18MB5107
X-Proofpoint-ORIG-GUID: CaLtHuHAYdp3G06zVaFquHaFXcv6XCqY
X-Proofpoint-GUID: CaLtHuHAYdp3G06zVaFquHaFXcv6XCqY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-20_04,2023-04-18_01,2023-02-09_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Simon Horman <simon.horman@corigine.com>
> Sent: Wednesday, April 19, 2023 4:05 PM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; leon@kernel.org; Sunil Kovvuri Goutham
> <sgoutham@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>;
> Linu Cherian <lcherian@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; Ratheesh Kannoth
> <rkannoth@marvell.com>
> Subject: Re: [net PATCH v3 02/10] octeontx2-af: Fix start and end bit for
> scan config
>=20
> On Wed, Apr 19, 2023 at 11:50:10AM +0530, Sai Krishna wrote:
> > From: Ratheesh Kannoth <rkannoth@marvell.com>
> >
> > Fix the NPC nibble start and end positions in the bit map.
> > for_each_set_bit_from() needs start bit as one bit prior and end bit
> > as one bit post position in the bit map
> >
> > Fixes: b747923afff8 ("octeontx2-af: Exact match support")
> > Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
>=20
> I think it would be nice to explain why, and what effect this has.
>=20
> Also, TBH, I'm unsure why the start needs to be one bit prior.
>=20
Will expand the commit message with explanation of why, what effect of fix =
in v4 patch.

> > ---
> >  drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> > index 006beb5cf98d..27603078689a 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> > @@ -593,9 +593,8 @@ static int npc_scan_kex(struct rvu *rvu, int blkadd=
r,
> u8 intf)
> >  	 * exact match code.
> >  	 */
> >  	masked_cfg =3D cfg & NPC_EXACT_NIBBLE;
> > -	bitnr =3D NPC_EXACT_NIBBLE_START;
> > -	for_each_set_bit_from(bitnr, (unsigned long *)&masked_cfg,
> > -			      NPC_EXACT_NIBBLE_START) {
> > +	bitnr =3D NPC_EXACT_NIBBLE_START - 1;
> > +	for_each_set_bit_from(bitnr, (unsigned long *)&masked_cfg,
> > +NPC_EXACT_NIBBLE_END + 1) {
> >  		npc_scan_exact_result(mcam, bitnr, key_nibble, intf);
> >  		key_nibble++;
> >  	}
> > --
> > 2.25.1
> >