Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <68d139bdc5c2cc267864b2136efb591948f61c91.camel@redhat.com>
Subject: Re: [PATCH v2] net: amd: Fix link leak when verifying config failed
From:   Paolo Abeni <pabeni@redhat.com>
To:     Gencen Gan <gangecen@hust.edu.cn>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     hust-os-kernel-patches@googlegroups.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Thu, 20 Apr 2023 10:40:09 +0200
In-Reply-To: <20230419065829.4077082-1-gangecen@hust.edu.cn>
References: <20230419065829.4077082-1-gangecen@hust.edu.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

Hi,

On Wed, 2023-04-19 at 14:58 +0800, Gencen Gan wrote:
> From: Gan Gecen <gangecen@hust.edu.cn>
>=20
> After failing to verify configuration, it returns directly without=20
> releasing link, which may cause memory leak.
>=20
> Signed-off-by: Gan Gecen <gangecen@hust.edu.cn>

Please include a suitable Fixes tag and specify the target tree in the
subj - see the documentation for the details.

More importantly, skimming over the relevant code I think that at least
a netdev is still leaked in the relevant error path.

Generally speaking the whole code of this driver is quite "suboptimal"
and looks unmainatained since at least ~15y, just receiving tree-wide
related changes.

I'm wondering if we could simply remove the whole driver?

Thanks

Paolo