Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f862ffc2fd06acf52b6625cfbf7bc7a3dc77e31c.camel@intel.com>
Subject: Re: [PATCH] uvc: Intel PID enabling UVC Metadata attributes
From:   Dmitry Perchanov <dmitry.perchanov@intel.com>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     linux-media@vger.kernel.org, mchehab@kernel.org,
        linux-kernel@vger.kernel.org, evgeni.raikhel@intel.com,
        demisrael@gmail.com
Date:   Thu, 20 Apr 2023 12:02:38 +0300
In-Reply-To: <20230420025027.GC631@pendragon.ideasonboard.com>
References: <9001ccdec3e3234253cf2f93ea39745ed6f525f1.camel@intel.com>
         <20230420025027.GC631@pendragon.ideasonboard.com>
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Laurent,
I will resend a patch as v3.

On Thu, 2023-04-20 at 05:50 +0300, Laurent Pinchart wrote:
> Hi Dmitry,
> =

> Thank you for the patch.
> =

> On Sun, Jan 29, 2023 at 03:43:38PM +0200, Dmitry Perchanov wrote:
> > Intel RealSense UVC cameras Metadata support.
> =

> The subject line should start with "media: uvcvideo:".
> =

> Both the subject line and the body of the commit message should use the
> imperative mood. For instance,
> =

> media: uvcvideo: Enable Intel RealSense metadata for 8 new devices
> =

> Intel RealSense UVC cameras produce metadata in a vendor-specific format
> that is already supported by the uvcvideo driver. Enable handling of
> this metadata for 8 additional RealSense devices.
> =

Done for v3

> > Co-developed-by: Yu MENG <yu1.meng@intel.com>
> > Co-developed-by: Evgeni Raikhel <evgeni.raikhel@intel.com>
> > Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
> > ---
> >  drivers/media/usb/uvc/uvc_driver.c | 72 ++++++++++++++++++++++++++++++
> >  1 file changed, 72 insertions(+)
> > =

> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc=
/uvc_driver.c
> > index e4bcb5011360..955f67d9a993 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -3000,6 +3000,78 @@ static const struct usb_device_id uvc_ids[] =3D {
> >  	  .bInterfaceSubClass	=3D 1,
> >  	  .bInterfaceProtocol	=3D 0,
> >  	  .driver_info		=3D UVC_INFO_META(V4L2_META_FMT_D4XX) },
> > +	/* Intel D410/ASR depth camera */
> > +	{ .match_flags		=3D USB_DEVICE_ID_MATCH_DEVICE
> > +				| USB_DEVICE_ID_MATCH_INT_INFO,
> > +	  .idVendor		=3D 0x8086,
> > +	  .idProduct		=3D 0x0ad2,
> =

> Please keep entries sorted by vendor and product ID in this list. The
> first four entries from this patch should go before 8086:0b03 that is
> already in the driver.
Done for v3.
> =

> > +	  .bInterfaceClass	=3D USB_CLASS_VIDEO,
> > +	  .bInterfaceSubClass	=3D 1,
> > +	  .bInterfaceProtocol	=3D 0,
> > +	  .driver_info		=3D UVC_INFO_META(V4L2_META_FMT_D4XX) },
> > +	/* Intel D415/ASRC depth camera */
> > +	{ .match_flags		=3D USB_DEVICE_ID_MATCH_DEVICE
> > +				| USB_DEVICE_ID_MATCH_INT_INFO,
> > +	  .idVendor		=3D 0x8086,
> > +	  .idProduct		=3D 0x0ad3,
> > +	  .bInterfaceClass	=3D USB_CLASS_VIDEO,
> > +	  .bInterfaceSubClass	=3D 1,
> > +	  .bInterfaceProtocol	=3D 0,
> > +	  .driver_info		=3D UVC_INFO_META(V4L2_META_FMT_D4XX) },
> > +	/* Intel D430/AWG depth camera */
> > +	{ .match_flags		=3D USB_DEVICE_ID_MATCH_DEVICE
> > +				| USB_DEVICE_ID_MATCH_INT_INFO,
> > +	  .idVendor		=3D 0x8086,
> > +	  .idProduct		=3D 0x0ad4,
> > +	  .bInterfaceClass	=3D USB_CLASS_VIDEO,
> > +	  .bInterfaceSubClass	=3D 1,
> > +	  .bInterfaceProtocol	=3D 0,
> > +	  .driver_info		=3D UVC_INFO_META(V4L2_META_FMT_D4XX) },
> > +	/* Intel Fallback USB2 Descriptor */
> =

> According to the descriptors you've provided (thank you for that), this
> camera is named "Depth Camera 430". How does it differ from the 0ad4
> device which you also name 430 right above ?
This descriptor, 0x0ad6, used to support old firmware.
That happened that I had this 430 module with outdated fw.
We notice users that their fw is outdated in SDK.
We decided to discard it, it still can have streams but w/o metadata.
Removed 0x0ad6 in v3.
> =

> > +	{ .match_flags		=3D USB_DEVICE_ID_MATCH_DEVICE
> > +				| USB_DEVICE_ID_MATCH_INT_INFO,
> > +	  .idVendor		=3D 0x8086,
> > +	  .idProduct		=3D 0x0ad6,
> > +	  .bInterfaceClass	=3D USB_CLASS_VIDEO,
> > +	  .bInterfaceSubClass	=3D 1,
> > +	  .bInterfaceProtocol	=3D 0,
> > +	  .driver_info		=3D UVC_INFO_META(V4L2_META_FMT_D4XX) },
> > +	/* Intel D435/AWGC depth camera */
> > +	{ .match_flags		=3D USB_DEVICE_ID_MATCH_DEVICE
> > +				| USB_DEVICE_ID_MATCH_INT_INFO,
> > +	  .idVendor		=3D 0x8086,
> > +	  .idProduct		=3D 0x0b07,
> > +	  .bInterfaceClass	=3D USB_CLASS_VIDEO,
> > +	  .bInterfaceSubClass	=3D 1,
> > +	  .bInterfaceProtocol	=3D 0,
> > +	  .driver_info		=3D UVC_INFO_META(V4L2_META_FMT_D4XX) },
> > +	/* Intel D435i depth camera */
> > +	{ .match_flags		=3D USB_DEVICE_ID_MATCH_DEVICE
> > +				| USB_DEVICE_ID_MATCH_INT_INFO,
> > +	  .idVendor		=3D 0x8086,
> > +	  .idProduct		=3D 0x0b3a,
> > +	  .bInterfaceClass	=3D USB_CLASS_VIDEO,
> > +	  .bInterfaceSubClass	=3D 1,
> > +	  .bInterfaceProtocol	=3D 0,
> > +	  .driver_info		=3D UVC_INFO_META(V4L2_META_FMT_D4XX) },
> > +	/* Intel D405 Depth Camera */
> > +	{ .match_flags		=3D USB_DEVICE_ID_MATCH_DEVICE
> > +				| USB_DEVICE_ID_MATCH_INT_INFO,
> > +	  .idVendor		=3D 0x8086,
> > +	  .idProduct		=3D 0x0b5b,
> > +	  .bInterfaceClass	=3D USB_CLASS_VIDEO,
> > +	  .bInterfaceSubClass	=3D 1,
> > +	  .bInterfaceProtocol	=3D 0,
> > +	  .driver_info		=3D UVC_INFO_META(V4L2_META_FMT_D4XX) },
> > +	/* Intel D455 Depth Camera */
> > +	{ .match_flags		=3D USB_DEVICE_ID_MATCH_DEVICE
> > +				| USB_DEVICE_ID_MATCH_INT_INFO,
> > +	  .idVendor		=3D 0x8086,
> > +	  .idProduct		=3D 0x0b5c,
> > +	  .bInterfaceClass	=3D USB_CLASS_VIDEO,
> > +	  .bInterfaceSubClass	=3D 1,
> > +	  .bInterfaceProtocol	=3D 0,
> > +	  .driver_info		=3D UVC_INFO_META(V4L2_META_FMT_D4XX) },
> >  	/* Generic USB Video Class */
> >  	{ USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, UVC_PC_PROTOCOL_UNDEFINED) },
> >  	{ USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, UVC_PC_PROTOCOL_15) },

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.