Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-372-g43825cb665-fm-20230411.003-g43825cb6
Mime-Version: 1.0
Message-Id: <acf525da-9a22-472f-abbb-6d1519be8d2a@app.fastmail.com>
In-Reply-To: <20230420090101.80812-2-pawell@cadence.com>
References: <20230420090101.80812-1-pawell@cadence.com>
 <20230420090101.80812-2-pawell@cadence.com>
Date:   Thu, 20 Apr 2023 11:17:43 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Pawel Laszczak" <pawell@cadence.com>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        Daisy.Barrera@siriusxm.com, Cliff.Holden@siriusxm.com,
        "Tony Lindgren" <tony@atomide.com>,
        "Jean Delvare" <jdelvare@suse.de>, neal_liu@aspeedtech.com,
        "Linus Walleij" <linus.walleij@linaro.org>, egtvedt@samfundet.no,
        "Biju Das" <biju.das.jz@bp.renesas.com>, herve.codina@bootlin.com
Subject: Re: [PATCH v2 1/4] usb: cdns2: Device side header file for CDNS2 driver
Content-Type: text/plain
Precedence: bulk

On Thu, Apr 20, 2023, at 11:00, Pawel Laszczak wrote:
> Patch defines macros, registers and structures used by
> Device side driver.
>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>

> +struct cdns2_ep0_regs {
> +	__u8 rxbc;
> +	__u8 txbc;
> +	__u8 cs;
> +	__u8 reserved1[4];
> +	__u8 fifo;
> +	__le32 reserved2[94];
> +	__u8 setupdat[8];
> +	__u8 reserved4[88];
> +	__u8 maxpack;
> +} __packed;

> +struct cdns2_epx_base {
> +	__le16 rxbc;
> +	__u8 rxcon;
> +	__u8 rxcs;
> +	__le16 txbc;
> +	__u8 txcon;
> +	__u8 txcs;
> +} __packed;

> +struct cdns2_epx_regs {
> +	__le32 reserved[2];
> +	struct cdns2_epx_base ep[15];
> +	__u8 reserved2[290];
> +	__u8 endprst;
> +	__u8 reserved3[41];
> +	__le16 isoautoarm;
> +	__u8 reserved4[10];
> +	__le16 isodctrl;
> +	__le16 reserved5;
> +	__le16 isoautodump;
> +	__le32 reserved6;
> +	__le16 rxmaxpack[15];
> +	__le32 reserved7[65];
> +	__le32 rxstaddr[15];
> +	__u8 reserved8[4];
> +	__le32 txstaddr[15];
> +	__u8 reserved9[98];
> +	__le16 txmaxpack[15];
> +} __packed;

Register structures should generally not be __packed, otherwise
any multi-byte registers will be accessed as individual bytes
on architectures that have no unaligned load/store.

If you are worried about struct packing on OABI arm, you can
mark it as both __packed and __aligned(4). Most drivers just
avoid the problem by not defining these as structures but instead
use macros with register offsets.

      Arnd