Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Apr 2023 11:23:30 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     "WeitaoWang-oc@zhaoxin.com" <WeitaoWang-oc@zhaoxin.com>
Cc:     stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, tonywwang@zhaoxin.com,
        weitaowang@zhaoxin.com
Subject: Re: [PATCH] =?utf-8?B?VUhDSe+8mmFkanVz?= =?utf-8?Q?t?= zhaoxin UHCI
 controllers OverCurrent bit value
Message-ID: <ZEEEkjpn_Wsf2hCG@kroah.com>
References: <20230420111445.5028-1-WeitaoWang-oc@zhaoxin.com>
 <ZEDyWC7GsbcEn7UK@kroah.com>
 <6a43e6aa-5609-ecd5-b040-010763a686ee@zhaoxin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6a43e6aa-5609-ecd5-b040-010763a686ee@zhaoxin.com>
Precedence: bulk

On Fri, Apr 21, 2023 at 01:14:46AM +0800, WeitaoWang-oc@zhaoxin.com wrote:
> On 2023/4/20 16:05, Greg KH wrote:
> > On Thu, Apr 20, 2023 at 07:14:45PM +0800, Weitao Wang wrote:
> > > Over Current condition is not standardized in the UHCI spec.
> > > Zhaoxin UHCI controllers report OverCurrent bit active off.
> > > Intel controllers report it active on, so we'll adjust the bit value.
> > > 
> > > Signed-off-by: Weitao Wang <WeitaoWang-oc@zhaoxin.com>
> > 
> > Note, your Subject: line has odd characters in it, can you rewrite it to
> > just use ascii?  I think it's the '：' character which should be ':',
> > right?Yes,you are right. it's my typo mistake. I'll rewrite this patch. Thanks!
> 
> > > ---
> > >   drivers/usb/host/uhci-pci.c | 4 ++++
> > >   1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/drivers/usb/host/uhci-pci.c b/drivers/usb/host/uhci-pci.c
> > > index 3592f757fe05..177e3c2aa287 100644
> > > --- a/drivers/usb/host/uhci-pci.c
> > > +++ b/drivers/usb/host/uhci-pci.c
> > > @@ -126,6 +126,10 @@ static int uhci_pci_init(struct usb_hcd *hcd)
> > >   	if (to_pci_dev(uhci_dev(uhci))->vendor == PCI_VENDOR_ID_VIA)
> > >   		uhci->oc_low = 1;
> > > +	/* ZHAOXIN controllers report OverCurrent bit active off. */
> > > +	if (to_pci_dev(uhci_dev(uhci))->vendor == PCI_VENDOR_ID_ZHAOXIN)
> > > +		uhci->oc_low = 1;
> > > +
> > 
> > This should also go to the stable kernels, right?
> > 
> > But a new UHCI controller?  And this affects all of them?
> All UHCI controller of zhaoxin have this issue, And Hope this
> patch go to stable kernel.Could I resubmit this patch with
> modify subject typo mistake?

Yes, please do so and add the needed cc: stable as is documented
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

thanks,

greg k-h