Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: rdE0lWEq9+TofNrozWjk06ulUBQ8VgH6Jg0K2Ekbeom1b9UFskhNm1kpxbmVLLOKdw8aCXqNoD
 fFh3Znqn0Xi5x45TYRRj5fkQi7sq6i51K9mSoyJOQJUAl05ULWLw32j2ouqPHvhQHGLUcx/M5V
 3tjCo1WICe8dP0YSZjJwFC0VHXn+FJjNvzImO9jpfKBGcWQtsnLM37D+MZc+G8qKoEm0aMFXL/
 NX5MoHHq0bkWsjC30u5rrAviiOiSkm9fBJehvu/4VfqvvGDbJ15Rwwy2OAI7sIzZ83VjjdQaU6
 9K8=
IronPort-SDR: ORsds7CtjxmB5wYxkvbO2BbKRBatGs09seFBUNJYG1SyomkUvbUDcKdrEjOtxAATob/67q+1Ww
 5kB1UgCufxRzQa8oDELgTy7DFmlpP+LWlQSRB6XzPFj5bm43lMxtFchbeZ7xDsT06ifPwT9xaK
 EffgDeF727Wi38xD++31niqoaO/IupmJe7nqsyEAT88DTmqJu7hiH6OAr2P/sa6ljxbzhWukBr
 UR6i9MtV8T+MsTbFdk8Enelh/yFFuCt8ZKYGkVZpENznXa/C/HH9Cs53QILh2sl/cQGeJkJamE
 XDM=
WDCIronportException: Internal
From:   Avri Altman <avri.altman@wdc.com>
To:     "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>
Cc:     Asutosh Das <quic_asutoshd@quicinc.com>, quic_cang@quicinc.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
        Bart Van Assche <bvanassche@acm.org>,
        John Garry <john.g.garry@oracle.com>,
        Avri Altman <avri.altman@wdc.com>,
        Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH v3] scsi: ufs: mcq: Limit the amount of inflight requests
Date:   Thu, 20 Apr 2023 13:11:16 +0300
Message-Id: <20230420101116.173-1-avri.altman@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

in UFS, each request is designated via the triplet <iid, lun, task tag>.

In UFS4.0 the Initiator ID field is 8 bits wide, comprised of the
EXT_IID and IID fields. Together with the task tag (single byte), they
limit the driver's hw queues capacity.

The purpose of this patch is to document the ufs spec restrictions.
practically, it impose no functional change because a) the current hw
supports much less (merely 64 requests), and b) since shost->host_tagset
is set - then the number of inflight IOs is limited by just the HW queue
depth.

---
v2 -> v3:
fix smatch warnings (Dan Carpenter)
elaborate commit log (John Garry)

v1 -> v2:
Attend Johannes's and Bart's comments

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Avri Altman <avri.altman@wdc.com>
---
 drivers/ufs/core/ufshcd.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 03c47f9a2750..9cebec6be35c 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -8468,6 +8468,12 @@ static int ufshcd_alloc_mcq(struct ufs_hba *hba)
 	if (ret)
 		goto err;
 
+	if (hba->nutrs * hba->nr_hw_queues > SZ_64K - 1) {
+		dev_info(hba->dev, "there can be at most 64K inflight requests\n");
+		ret = -EINVAL;
+		goto err;
+	}
+
 	/*
 	 * Previously allocated memory for nutrs may not be enough in MCQ mode.
 	 * Number of supported tags in MCQ mode may be larger than SDB mode.
-- 
2.17.1