Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757547AbXI1Nzg (ORCPT ); Fri, 28 Sep 2007 09:55:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753964AbXI1Nz2 (ORCPT ); Fri, 28 Sep 2007 09:55:28 -0400 Received: from an-out-0708.google.com ([209.85.132.248]:39111 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753851AbXI1Nz1 (ORCPT ); Fri, 28 Sep 2007 09:55:27 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=T8oMWXluFft4UF0H+3TGXn2uztaTbj8YyM5GpqMqiQzCwWT3d26esQyuhPdVqRv89MHNXSg/4no6quiU6aWh3+2gyCxI/l3YcQQHg8k7Mn09wttWc+qvbeaYxGpuzQ5u99xy/NQl0yPSXYPKflGr+D8yda54+c9hiHYuUrbL15w= Message-ID: <19f34abd0709280655g3dfb6b32vb4d1bf46757c845a@mail.gmail.com> Date: Fri, 28 Sep 2007 15:55:26 +0200 From: "Vegard Nossum" To: "Miguel Ojeda" Subject: Re: [RFC] New kernel-message logging API (take 2) Cc: LKML , "Kyle Moffett" , "Michael Holzheu" , "Joe Perches" , "Rob Landley" , "Dick Streefland" , "Geert Uytterhoeven" , "Jesse Barnes" , "Arnd Bergmann" , "Jan Engelhardt" , "Emil Medve" , "Stephen Hemminger" , "linux@horizon.com" In-Reply-To: <653402b90709280630t4168abc4rd114aaa5747adc09@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <19f34abd0709271418l471cf7b9gf24161190772fac@mail.gmail.com> <19f34abd0709280511h3f31681bh54c6af287a48c02f@mail.gmail.com> <653402b90709280630t4168abc4rd114aaa5747adc09@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1738 Lines: 36 On 9/28/07, Miguel Ojeda wrote: > On 9/28/07, Vegard Nossum wrote: > > reason we can't use KBUILD_MODNAME is that this is defined on the > > command line. The declaration inside the header would thus be horribly > > wrong. We can, however, use KBUILD_MODNAME as a default value for > > KPRINT_DRIVER, like: > > static const char *KPRINT_DRIVER = KBUILD_MODNAME; > > which would pre-process to something like: > > static const char *KPRINT_DRIVER = "bcm43xx"; > > > > This value can still be overridden using #define KPRINT_DRIVER "new > > name". In this case, it is possible that the original KPRINT_DRIVER > > symbol can cause an "unused variable"-warning. I guess this is fixable > > with the gcc "unused" variable attribute. > > Yep, then, in a year or two, we will be able to delete such attribute. Actually, no, since it will throw a warning only if a source file #defines KPRINT_SUBSYSTEM (i.e. overrides the constant variable (oxymoron!) with the same name). What you're hoping is that some time in the future, EVERY source file will come equipped with these definitions, and yes, at that point, the entire declaration can be removed, BUT I think that's... well. Yes. > Will there be a team to change main subsystems/drivers to the new API? No. First of all, this is a specification draft; there is no code yet. Also, very possibly, this is such a violent change that nobody really wants to use it anyway. But we can hope. ;-) Vegard - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/