Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp582741rwr; Thu, 20 Apr 2023 03:46:37 -0700 (PDT) X-Google-Smtp-Source: AKy350YbXDcfzYX1MM3qN/AVy6CADXECkjv+ITyYFND0u2XJztLhDxgpWlOIHttZ8bjANc0NTR/e X-Received: by 2002:a17:902:d583:b0:1a4:fcc9:ec61 with SMTP id k3-20020a170902d58300b001a4fcc9ec61mr1263595plh.5.1681987597642; Thu, 20 Apr 2023 03:46:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681987597; cv=none; d=google.com; s=arc-20160816; b=VCpQM/SrzETA3onvoP3mjClexWTwJlbyywz1iGD7S12hSOP0CoX1v+cexPV/oEkdGH BAGsPhHwif70LYBrMLwzE+lUccOiyjkoScOIVAUVUYraq13PH0hB2OX0oBGlmFns8MEt 7YrZym/2dyfwAlswTOtSbLMsyZ4btvRKw3BTGpoRuESL1+EP/8fRsWqiqCUfJfTOr5YT tEKFdg1RQ7KpKQtpZm/T2TEnOmjCY16ESC+iN4JCSrFf61WtWnDbpfdEo67KcSmkC4Ac 8AsLXXDANOBhZyHONOhJRbLOnycWCv3VmUCLs0fkcUiP2nfgilcrTsy+WTblAXM8cohk 5qng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aU66+TBbleha6H43jUHnD5UwkYGmlQDbV3Eu+lkkePE=; b=hbADtE7RP66B6GcAHn86Xfqn+2z6sp3z2DZooiCADvxBeqUIkOf6xpuNXMRnxOAk+y 3nmjWLVW4kVplQxc6hYTRTCqL2EVUxL5fYrZuL9u5wW7q27n5qH2pQeZl7RIcSQRNNAt Sv9XGsD1O1iAXimpqGJD3fa7ccSF/JpQ0vgjR6bSvYDJ9nxv8GWaQJVgle3UvmBsqbxZ vZu/oJhToicpEavIXHzJdnn/Gkmqa66GKFc/LUZ7smX2WqjeFHit0Ybk65KyKkO2NsrB 65LLTAtk048IZgBWkv+QHYSHcSGhiAF4aXCBd6oIJoGNjfa1AochXXajGi23fC/cOUiE AzUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nic.cz header.s=default header.b=K1KqBMaK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=nic.cz Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i10-20020a17090332ca00b001a6b273fef3si1499107plr.442.2023.04.20.03.46.20; Thu, 20 Apr 2023 03:46:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nic.cz header.s=default header.b=K1KqBMaK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=nic.cz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234873AbjDTKhW (ORCPT + 99 others); Thu, 20 Apr 2023 06:37:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234870AbjDTKgu (ORCPT ); Thu, 20 Apr 2023 06:36:50 -0400 Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B0657699 for ; Thu, 20 Apr 2023 03:33:55 -0700 (PDT) Received: from kandell (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPS id 2D2591C1824; Thu, 20 Apr 2023 12:33:51 +0200 (CEST) Authentication-Results: mail.nic.cz; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1681986832; bh=ygF+dVEaVaGGwTtV9K6yEQ6mivTLTGTWi1vN1UuuX3s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Reply-To: Subject:To:Cc; b=K1KqBMaKDhpif6xfLQ7/SKwI22uLKNLwMckN7JLfBCrxOBxdzuO5VIT+s/bxSAfxV AgYYrY17mtGCU81oI0/4sZbab8u3fQqaysE5Zmrd8r7A2PFCq3KCd44TnPd9x7umJ4 E13xA7nsPA4lyBz2jIkJLQpHvnn2/7pDx7DjpjV4= Date: Thu, 20 Apr 2023 12:33:51 +0200 From: Marek =?utf-8?B?QmVow7pu?= To: yunchuan Cc: kabel@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware:Remove unnecessary (void*) conversions Message-ID: <20230420103351.cyzbtwjhojkeqak5@kandell> References: <20230420073751.1031944-1-yunchuan@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230420073751.1031944-1-yunchuan@nfschina.com> X-Virus-Scanned: clamav-milter 0.103.7 at mail X-Virus-Status: Clean X-Rspamd-Server: mail X-Rspamd-Queue-Id: 2D2591C1824 X-Spamd-Bar: / X-Spamd-Result: default: False [0.53 / 20.00]; R_MIXED_CHARSET(0.63)[subject]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; WHITELISTED_IP(0.00)[172.20.6.87]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[] X-Rspamd-Pre-Result: action=no action; module=multimap; Matched map: WHITELISTED_IP X-Rspamd-Action: no action X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This makes sense, but the commit title should be firmware: turris-mox-rwtm: drop unnecessary (void *) conversion On Thu, Apr 20, 2023 at 03:37:51PM +0800, yunchuan wrote: > Pointer variables of void * type do not require type cast. > > Signed-off-by: yunchuan > --- > drivers/firmware/turris-mox-rwtm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c > index 6ea5789a89e2..af2fa620e6bc 100644 > --- a/drivers/firmware/turris-mox-rwtm.c > +++ b/drivers/firmware/turris-mox-rwtm.c > @@ -283,7 +283,7 @@ static int check_get_random_support(struct mox_rwtm *rwtm) > > static int mox_hwrng_read(struct hwrng *rng, void *data, size_t max, bool wait) > { > - struct mox_rwtm *rwtm = (struct mox_rwtm *) rng->priv; > + struct mox_rwtm *rwtm = rng->priv; > struct armada_37xx_rwtm_tx_msg msg; > int ret; > > -- > 2.30.2 >