Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Apr 2023 03:41:30 -0700
From:   Zev Weiss <zev@bewilderbeest.net>
To:     Naresh Solanki <naresh.solanki@9elements.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: regulator: Add dt property
Message-ID: <048bf9f4-92ee-4aca-a46f-dbe512129ffe@hatter.bewilderbeest.net>
References: <20230418145051.4192963-1-Naresh.Solanki@9elements.com>
 <0da2b301-8780-48c0-a5dc-326474011e8d@hatter.bewilderbeest.net>
 <9f425205-c395-648a-3f42-a776c7580a8f@9elements.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9f425205-c395-648a-3f42-a776c7580a8f@9elements.com>
Precedence: bulk

On Thu, Apr 20, 2023 at 01:22:30AM PDT, Naresh Solanki wrote:
>Hi Zev,
>
>On 20-04-2023 05:31 am, Zev Weiss wrote:
>>On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
>>>Add DT property regulator-supplies.
>>>This enables us to couple one or more regulator output to gether. This
>>>is use in case of Single connector having 2 or more supplies.
>>>
>>>Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>>>---
>>>.../bindings/regulator/regulator-output.yaml???????? | 12 +++++++++---
>>>1 file changed, 9 insertions(+), 3 deletions(-)
>>>
>>>diff --git 
>>>a/Documentation/devicetree/bindings/regulator/regulator-output.yaml 
>>>b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>index 078b37a1a71a..17f683d3c1f3 100644
>>>--- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>+++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>@@ -21,13 +21,19 @@ properties:
>>>? compatible:
>>>??? const: regulator-output
>>>
>>>-? vout-supply:
>>>+? regulator-supplies:
>>>??? description:
>>>-????? Phandle of the regulator supplying the output.
>>>+????? Specifies the name of the output supply provided by the regulator.
>>>+????? Defaults to "vout".
>>>+??? default: "vout"
>>>+
>>
>>Was this meant to be specified as a string-array to allow providing 
>>multiple names?
>Yes. This is string-array.

Okay -- in that case I think it should include

   $ref: /schemas/types.yaml#/definitions/string-array

>>
>>>+patternProperties:
>>>+? ".*-supply":
>>>+??? description:
>>>+????? Specified the phandle for various supplies
>>>
>>>required:
>>>? - compatible
>>>-? - vout-supply
>>>
>>>additionalProperties: false
>>>
>>>
>>
>>I think it would be nice to also update the examples to show what a 
>>multi-supply instance would look like.
>Ack. Will do that.
>>
>>A slightly more descriptive subject line would also be good -- "Add 
>>dt property" is a bit vague.
>Suggestion ?
>How about like 'Allow multiple supplies' or 'Add support for multiple 
>supplies'

Sure, both of those sound fine to me.

>>
>>>base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005
>>>-- 
>>>2.39.1
>>>
>Regards,
>Naresh