Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <686ee776-8f5f-9814-1f89-0ab9f0e7b2b8@linaro.org>
Date:   Thu, 20 Apr 2023 12:49:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH 08/10] ARM: dts: qcom: apq8060-dragonboard: move
 regulators out of simple-bus
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230420075053.41976-1-krzysztof.kozlowski@linaro.org>
 <20230420075053.41976-8-krzysztof.kozlowski@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230420075053.41976-8-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Regulators is not a bus, so drop incomplete simple-bus usage to fix dtbs
> W=1 warnings:
> 
>   Warning (simple_bus_reg): /regulators/regulator-fixed: missing or empty reg/ranges property
>   Warning (simple_bus_reg): /regulators/xc622a331mrg: missing or empty reg/ranges property
>   Warning (simple_bus_reg): /regulators/nds332p: missing or empty reg/ranges property
>   Warning (simple_bus_reg): /regulators/txb0104rgyr: missing or empty reg/ranges property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../arm/boot/dts/qcom-apq8060-dragonboard.dts | 80 +++++++++----------
>  1 file changed, 38 insertions(+), 42 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> index 8e4b61e4d4b1..e830cb2395aa 100644
> --- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> @@ -18,50 +18,46 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> -	regulators {
> -		compatible = "simple-bus";
> -
> -		/* Main power of the board: 3.7V */
> -		vph: regulator-fixed {
> -			compatible = "regulator-fixed";
> -			regulator-min-microvolt = <3700000>;
> -			regulator-max-microvolt = <3700000>;
> -			regulator-name = "VPH";
> -			regulator-type = "voltage";
> -			regulator-always-on;
> -			regulator-boot-on;
> -		};
> -
> -		/* GPIO controlled ethernet power regulator */
> -		dragon_veth: xc622a331mrg {
> -			compatible = "regulator-fixed";
> -			regulator-name = "XC6222A331MR-G";
> -			regulator-min-microvolt = <3300000>;
> -			regulator-max-microvolt = <3300000>;
> -			vin-supply = <&vph>;
> -			gpio = <&pm8058_gpio 40 GPIO_ACTIVE_HIGH>;
> -			enable-active-high;
> -			pinctrl-names = "default";
> -			pinctrl-0 = <&dragon_veth_gpios>;
> -			regulator-always-on;
> -		};
> +	/* Main power of the board: 3.7V */
> +	vph: regulator-fixed {
> +		compatible = "regulator-fixed";
> +		regulator-min-microvolt = <3700000>;
> +		regulator-max-microvolt = <3700000>;
> +		regulator-name = "VPH";
> +		regulator-type = "voltage";
> +		regulator-always-on;
> +		regulator-boot-on;
> +	};
> +
> +	/* GPIO controlled ethernet power regulator */
> +	dragon_veth: xc622a331mrg {
These names could also be fixed up, but that's for another day..

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> +		compatible = "regulator-fixed";
> +		regulator-name = "XC6222A331MR-G";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&vph>;
> +		gpio = <&pm8058_gpio 40 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&dragon_veth_gpios>;
> +		regulator-always-on;
> +	};
>  
> -		/* VDDvario fixed regulator */
> -		dragon_vario: nds332p {
> -			compatible = "regulator-fixed";
> -			regulator-name = "NDS332P";
> -			regulator-min-microvolt = <1800000>;
> -			regulator-max-microvolt = <1800000>;
> -			vin-supply = <&pm8058_s3>;
> -		};
> +	/* VDDvario fixed regulator */
> +	dragon_vario: nds332p {
> +		compatible = "regulator-fixed";
> +		regulator-name = "NDS332P";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		vin-supply = <&pm8058_s3>;
> +	};
>  
> -		/* This is a levelshifter for SDCC5 */
> -		dragon_vio_txb: txb0104rgyr {
> -			compatible = "regulator-fixed";
> -			regulator-name = "Dragon SDCC levelshifter";
> -			vin-supply = <&pm8058_l14>;
> -			regulator-always-on;
> -		};
> +	/* This is a levelshifter for SDCC5 */
> +	dragon_vio_txb: txb0104rgyr {
> +		compatible = "regulator-fixed";
> +		regulator-name = "Dragon SDCC levelshifter";
> +		vin-supply = <&pm8058_l14>;
> +		regulator-always-on;
>  	};
>  
>  	/*