Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Apr 2023 14:27:49 +0300
From:   Sakari Ailus <sakari.ailus@iki.fi>
To:     Dmitry Perchanov <dmitry.perchanov@intel.com>
Cc:     linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
        mchehab@kernel.org, linux-kernel@vger.kernel.org,
        evgeni.raikhel@intel.com, demisrael@gmail.com
Subject: Re: [PATCH v3] media: uvcvideo: Enable Intel RealSense metadata for
 devices.
Message-ID: <ZEEhtUH/9Nqm/+n0@valkosipuli.retiisi.eu>
References: <5587a4f1a0a7f3e2bd0ce886bb4ee3bcbf8f522a.camel@intel.com>
 <ZEEEwt34bfmNEN99@valkosipuli.retiisi.eu>
 <7fe1b7ab73842ad8ee430cb171b6a59e3d6003bb.camel@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7fe1b7ab73842ad8ee430cb171b6a59e3d6003bb.camel@intel.com>
Precedence: bulk

Hi Dmitry,

On Thu, Apr 20, 2023 at 02:26:53PM +0300, Dmitry Perchanov wrote:
> Hi Sakari,
> 
> On Thu, 2023-04-20 at 12:24 +0300, Sakari Ailus wrote:
> > Hi Dmitry,
> > 
> > On Thu, Apr 20, 2023 at 12:06:55PM +0300, Dmitry Perchanov wrote:
> > > Intel RealSense UVC Depth cameras produce metadata in a
> > > vendor-specific format that is already supported by the uvcvideo driver.
> > > Enable handling of this metadata for 7 additional RealSense devices.
> > > 
> > > Co-developed-by: Yu MENG <yu1.meng@intel.com>
> > > Co-developed-by: Evgeni Raikhel <evgeni.raikhel@intel.com>
> > > Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
> > 
> > Thanks for the update.
> > 
> > Is the D4XX format on these devices the same that's documented in
> > Documentation/userspace-api/media/v4l/pixfmt-meta-d4xx.rst ? I.e. there are
> > no additional fields or differences, and the version of the format is the
> > same?
> We verified the document and found it generally correct.
> Although, we expanded number of fields and I can update this document.
> > 
> > The format documentation doesn't say which version number even the current
> > devices use (just refers to "xxx").
> The document compatible with all D4xx/D5xx devices so far.
> We dropped all obsolete incompatible cameras from support.
> > 
> 
> Should I submit another patch with extended structures?

Please do.

If some of the fields are only available on certain devices, it'd be good
to document which fields and which devices, or whether it's struct version
dependent (and then what that depends on).

-- 
Regards,

Sakari Ailus