Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     =?iso-8859-1?Q?Christian_L=F6hle?= <CLoehle@hyperstone.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/3] mmc: block: ioctl: define rpmb reliable flag
Thread-Topic: [PATCH 1/3] mmc: block: ioctl: define rpmb reliable flag
Thread-Index: AdlntW2uE8YL5x37Rg65HliP9l7UwwL0IX/Q
Date:   Thu, 20 Apr 2023 12:46:50 +0000
Message-ID: <DM6PR04MB657590E0F041462A1C24E11EFC639@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <e41fbab65e164b3788818bae83f0061a@hyperstone.com>
In-Reply-To: <e41fbab65e164b3788818bae83f0061a@hyperstone.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?j4bdOYUhH4MhAR2AgHWsmVVjTqFq9h6LMTdKexcag3tkTZjyOM637aVLp9?=
 =?iso-8859-1?Q?HYxAOR/5MiiRKmLOX6fvLKMiLHK805DeTcBcFzBsOWp2Xve/SRwhjetjn/?=
 =?iso-8859-1?Q?nA46MOF5MVZ4k84SUdttgFoJI9LlQqbuSTbLM48ULoc8UmFvoarC3s0N9a?=
 =?iso-8859-1?Q?11L2ywsO3HW3Q9OMMZvulb43ULGDy7gKoG/AsZT0pjlooTaMrKRKt2XhgU?=
 =?iso-8859-1?Q?cPtA+1Hs18GMhm+vU8kkMCgJWeIkHVqC9TlzjlCkpZ/LNXQ4iYeEV2oxch?=
 =?iso-8859-1?Q?oUi0W/VAsbczCkU1Bwz8e3oFbJ60ZnR9n3AijEl1XCQt6el8yv+0NhQxdX?=
 =?iso-8859-1?Q?dsNBre6SVi/cBzgUk0WnuX11So2FdPSRP9Ps2GyuWPbiJcHZM36ZS73CyZ?=
 =?iso-8859-1?Q?T9QrfdSMfoGyLHKG1QcS9QT+7dQUDXR+7FKi9xa22mFawNm6wKZt/afihe?=
 =?iso-8859-1?Q?cG0vUiuZYBHgGqTSscFYxX7BIW+yyOY8Hep+eD8hI78+Rin+VQUHBSyq3P?=
 =?iso-8859-1?Q?8o6MFZkCD0qth0LP+HeKPT+bsD9y6e26va556gyXmdbt3NQ7jLPKwM0IQ9?=
 =?iso-8859-1?Q?k9Dthtz74lit8LYj4K+dLvL9xZ5+8bzoz2+63+8YwIvPGHHVQdEk7A/rmA?=
 =?iso-8859-1?Q?h1hjdCYZiTF4n0Pnz3r0vWlTTyNif9SGc231A++oV006AlU24KyHZ/JsWN?=
 =?iso-8859-1?Q?Ck6owFIZ9Q4JnvEbspZQk4eLsTtIj84AzY3kaeyL2hQwGoXCl5yBsDU06T?=
 =?iso-8859-1?Q?MsU9yM5kHVbad01owGNEVr/YQ3Lw+rDrI9vKx7fVi5cwJnIr8GQHy6Rxwm?=
 =?iso-8859-1?Q?FPYu7RbfICtJc2jrOjefB0clZ9z729hmoc0ConV/JHcsSLVSfwz8afeNnh?=
 =?iso-8859-1?Q?oCq9THDceaPx6V7yaWonWYRAsWuPa01cpP6Ne3JjYAORa9gvlmwTF0+eMZ?=
 =?iso-8859-1?Q?zMaVRSPSkaIYQHwF050byAe+Ria7irMru5uULa42vsrreNoesil6tQuNRn?=
 =?iso-8859-1?Q?XsiXNTZ4r8TO92YSPftSsM8HTJfuXxOnL4qYM/+MtvAokYYUs0TsazKG6a?=
 =?iso-8859-1?Q?K5mbsqfUJICrRWV328duyMuYt6QPlX8EuPqK3h7N4iTseBfrnHOF9XM8Qt?=
 =?iso-8859-1?Q?gpVU4upYvjG2RyLg2J5o0krRqfzwuPU5XhYlxnS1lzWy5ekKbAetfKGyak?=
 =?iso-8859-1?Q?LRTa4cf4TtKCZkoF7gSSJA5UiaDjqIEZsr8h99frfz6l3TrV/OGFmVBJ0t?=
 =?iso-8859-1?Q?pHsEz80J5M8qFfJ8YE4Xb71dvqJtZUSnEiHR58LsiCLYe0UHHuO4gukQRO?=
 =?iso-8859-1?Q?Ct8Y9nHS9IPJxdEUbeUW6rhMVyyFq79iAsgf/0/GuVDLYIVIgXbqNurE3i?=
 =?iso-8859-1?Q?PFC3FqiTfvS7bnZMAbAK+OJUJUVVVkFUgW3V3kcRa3zjg7Ic3KCZhcuc41?=
 =?iso-8859-1?Q?2shFRev6XRLcrp5+zWaetgmSgsJF17V6rW+PAGzy4fk95N0fxtu0EACfkf?=
 =?iso-8859-1?Q?wRMWthM579BiFAhFAQ2O0L5NWiElk9ZIX1v7fs9uLQKhUWzG/Bqfcp/7Kj?=
 =?iso-8859-1?Q?5t2B71RUhhR0T1VjzVk2ngJvi6V0S+HbCyZ2/TDQpB+barJYqq5Pk7h0d0?=
 =?iso-8859-1?Q?j3pucpqkV925JSeA69BcICFnKeu56Io7sL?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: f+oix/iGyU66OwU/TJgGiHb++Ethc8xOtVHp2OE+QmZX9m7okN9uFNdxcEHWZyH79gUIpxWAQ53nC7r6LwNxauXxK9YjzzhVZHUDuZwOBapf6mSRxxZ31vvqlXCkfAQvkkpjg4wfpLzhm0NN8VEXScVpGLWwq7d5UBeDCjigfEQDrSwvAOEBevvGwXNOIu1PnRKEFJFTkDMve3xDNc6aTLj5SMOp3Me3pvJSVwFOhkBBVzHbYz8cxVhSj8pCpEAQEBbChgZbFIdqOCQTXM5UrDHZ1mcLDXlz+J/AV9qq3Q89iqqlh5G2bUIPoQHaGne0xd0f0Lj8Xxvhw2x67q2o5Uij1Dv6iwIOi3SVwEEpWGrdKXyKpW7owG0VUQCvgdCq3mwupq5aaWrTlUF4FtaW6PxmhvPYjVtqjjj1dsi6P25fVViYPRM9sWSlo48eQgUjBdRWX69QJjnHJx3Ey52936Op4aeKHyk+Ep/JG9H/Oy0P1MWNS2S8meBDcIn/c3gbrstBtuHJgKjWiMPqn5klTKLBBwsJkGrYn5/gJlKSObgUQqxVYMYkqit3f/JSuWAAslDhWBKbfDcsQ1fOoBvRTT7QdPoy+QPZ+nm/A7gXIvHnS53ridbCVWU2w+9l9lHae8AV/UZHJRZf/XU9b8Wfq6anPqZa1SaMemjhs8ITjgwZDm9w2+6CaCztp3tAH4oVt518dFg8qfn+g2yr73FKC1YjGM3QNIRK/HdeRcWXmiN/soNav7JfcRQOIo+/bhfOMxcxC8/jF9NPg0wYcBDl+IYMyouiS69RftzAvPKi9b5ZSCtXyVGXU+o22Jf6kMWuNOXvriwzr6kKF29ujZ3jXzCSBWnFB9ayIO/1NYoiy4w6e8hSmDyO31i/xDuBdjTA
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a6699f8-9dd6-4a9a-0a87-08db419d4fdf
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2023 12:46:50.8396
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: njOzl8KojfX6ohQrOe7bb3YL74PXpwetkgwTinmZhmHCp2vhIs0juL1VBh5XsJgvT/3bRHVpzJam42kNgTwhGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR04MB7329
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
> Give a proper name to BIT 31 which is used as reliable write
> for RPMB.
>=20
> Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

Thanks (see nit below),
Avri

> ---
>  drivers/mmc/core/block.c       | 5 ++++-
>  include/uapi/linux/mmc/ioctl.h | 1 +
>  2 files changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index 672ab90c4b2d..16e262ddc954 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -49,6 +49,8 @@
>=20
>  #include <linux/uaccess.h>
>=20
> +#include <uapi/linux/mmc/ioctl.h>
> +
>  #include "queue.h"
>  #include "block.h"
>  #include "core.h"
> @@ -538,7 +540,8 @@ static int __mmc_blk_ioctl_cmd(struct mmc_card
> *card, struct mmc_blk_data *md,
>                  * may be increased by a future standard. We just copy th=
e
>                  * 'Reliable Write' bit here.
>                  */
> -               sbc.arg =3D data.blocks | (idata->ic.write_flag & BIT(31)=
);
> +               sbc.arg =3D data.blocks |
> +                       (idata->ic.write_flag & MMC_RPMB_RELIABLE_WRITE);
>                 sbc.flags =3D MMC_RSP_R1 | MMC_CMD_AC;
>                 mrq.sbc =3D &sbc;
>         }
> diff --git a/include/uapi/linux/mmc/ioctl.h b/include/uapi/linux/mmc/ioct=
l.h
> index e7401ade6822..b2ff7f5be87b 100644
> --- a/include/uapi/linux/mmc/ioctl.h
> +++ b/include/uapi/linux/mmc/ioctl.h
> @@ -11,6 +11,7 @@ struct mmc_ioc_cmd {
>          * Bit 31 selects 'Reliable Write' for RPMB.
No longer needed.

Thanks,
Avri
>          */
>         int write_flag;
> +#define MMC_RPMB_RELIABLE_WRITE (1 << 31)
>=20
>         /* Application-specific command.  true =3D precede with CMD55 */
>         int is_acmd;
> --
> 2.37.3
>=20
>=20
> Hyperstone GmbH | Reichenaustr. 39a  | 78467 Konstanz
> Managing Director: Dr. Jan Peter Berns.
> Commercial register of local courts: Freiburg HRB381782