Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp742915rwr; Thu, 20 Apr 2023 06:02:15 -0700 (PDT) X-Google-Smtp-Source: AKy350bqn7/4Lwue8Ikzbm1ZG/bD0kXeYJJGOiZ3PKVp1B7B8A0EYq9LfC9u71w1JAL7Zg04Y06S X-Received: by 2002:a1f:5f96:0:b0:43c:6e7d:60b0 with SMTP id t144-20020a1f5f96000000b0043c6e7d60b0mr533984vkb.15.1681995734866; Thu, 20 Apr 2023 06:02:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681995734; cv=none; d=google.com; s=arc-20160816; b=AwoxIgRR4CbpykTmU4F9xN23Dvgc/bPh11VPyn9Y6Bri36fNKSWrb3Yh+ZFzBonjZt URJZeif39RbB5N/IXbvKlj6Qx9lQXQ6Q0Ck9qyI/fb/57mZWHi6I6wMyOTCoenbY/u8x NVKQDKRFNHRBt9ZDMqY8gh/ve/kp/NSye06ao5QI0nIJQS/JKaFmVwGE4gCsl32X9v8K d5z5nBD5Aljo6kEIfBVazmibtSln/qyQcionLGW+u5IdLdvQ5KeZ38ykeBlvb1KtAQzL qyBu/YKxRuC02yHR3iMwwNXd9KU+zx3nfFsld3guTLe/UxFfDcEL2kvhCt2lxRJzrb8D RpJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gVcupUjqxy/2MFJa9BjLN3mhC36GLHdtoZUwAf/ZhO8=; b=BWVOL/DD+b08w3SRPufSZvSM/+e6+8a6hDomfBM6HmHWsmdk0dPmAs5r5j2z0kMoEm RK1R72KxvONDKClLh31LuyrNOrqxiCXIqSwOMfk31oDB0mnECeAOBmC0ANyMq9S/Bm4Y 8fzeQzCcfjMM+zKHHPz+9Itf3t/TBW51oXMw/1LPln300qiiTXB9+yt3DygkM+RD9/gb C6bF72UYHYz+dIA4/DwNygHKRrNlptYbVlnDcAzj5dtc+7OVMbKYe7/aYxMq9JT4Q7eE VZimXshsOcNFvzkLVuJvC3Rzie7Q7fgBvJfynVkOqG6rBqJNMkO+zL9aim6Y+5aPxr08 KCcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=KBT8Uofd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s68-20020a1f4547000000b004324f19df21si403689vka.267.2023.04.20.06.01.52; Thu, 20 Apr 2023 06:02:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=KBT8Uofd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231259AbjDTNAg (ORCPT + 99 others); Thu, 20 Apr 2023 09:00:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231278AbjDTNAd (ORCPT ); Thu, 20 Apr 2023 09:00:33 -0400 Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E6345FFB; Thu, 20 Apr 2023 06:00:30 -0700 (PDT) Received: from localhost.localdomain (unknown [10.101.196.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 1FE2E3F182; Thu, 20 Apr 2023 13:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1681995628; bh=gVcupUjqxy/2MFJa9BjLN3mhC36GLHdtoZUwAf/ZhO8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=KBT8UofdrHu5ROxkheXj+W2JRg5H/a/0UtSI4W/I74Cv0fm7kYf9pCYkKeLfqSqsE wNd+F31u1D6qVML+XmUEtLWTD/QGTkZCH2+ESH57wfzYx3IXFKpxGMozrHJJV3dKEj +Uwsvj3GD4tYWGDcms2lpv8mG2lb2EypZHHGy2ep1/z9yVqkhxKvsrhjIojE/6CyOE fnJmu953hXb0XxqwH6+SJLO2QCsDV5trGjwdbGBSFH0FlbL3MpWLqbr2mQZXPxeE44 mTwD5aczOULvDmLDb611aclY5G1KuEwgjrMqdBiJQpRMkrO+tp2vyvYtx9XMIrXbvq hb0HHPyvbUO3w== From: Kai-Heng Feng To: bhelgaas@google.com Cc: mika.westerberg@linux.intel.com, koba.ko@canonical.com, sathyanarayanan.kuppuswamy@linux.intel.com, Kai-Heng Feng , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/4] PCI: Keep AER status in pci_restore_state() Date: Thu, 20 Apr 2023 20:59:37 +0800 Message-Id: <20230420125941.333675-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When AER is using the same IRQ as PME, AER interrupt is treated as a wakeup event and it can disrupt system suspend process. If that happens, the system will report it's woken up by PME IRQ without indicating any AER error since AER status is cleared on resume. So keep the AER status so users can know the system is woken up by AER instead of PME. Reviewed-by: Mika Westerberg Signed-off-by: Kai-Heng Feng --- v3: - No change. v2: - New patch. drivers/pci/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 7a67611dc5f4..71aead00fc20 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -1778,7 +1778,6 @@ void pci_restore_state(struct pci_dev *dev) pci_restore_dpc_state(dev); pci_restore_ptm_state(dev); - pci_aer_clear_status(dev); pci_restore_aer_state(dev); pci_restore_config_space(dev); -- 2.34.1