Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0e1a27ca-8288-cbff-b903-0bb4f605bf84@linux.intel.com>
Date:   Thu, 20 Apr 2023 09:03:55 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] perf/x86/intel/uncore: add events for Intel SPR IMC PMU
Content-Language: en-US
To:     Stephane Eranian <eranian@google.com>, linux-kernel@vger.kernel.org
Cc:     peterz@infradead.org, kan.liang@intel.com, ak@linux.intel.com,
        namhyung@kernel.org, irogers@google.com
References: <20230419214241.2310385-1-eranian@google.com>
From:   "Liang, Kan" <kan.liang@linux.intel.com>
In-Reply-To: <20230419214241.2310385-1-eranian@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023-04-19 5:42 p.m., Stephane Eranian wrote:
> Add missing clockticks and cas_count_* events for Intel SapphireRapids IMC
> PMU. These events are useful to measure memory bandwidth.
> 
> Signed-off-by: Stephane Eranian <eranian@google.com>

Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks,
Kan

> ---
>  arch/x86/events/intel/uncore_snbep.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
> index 7d1199554fe3..fa9b209a11fa 100644
> --- a/arch/x86/events/intel/uncore_snbep.c
> +++ b/arch/x86/events/intel/uncore_snbep.c
> @@ -6068,6 +6068,17 @@ static struct intel_uncore_ops spr_uncore_mmio_ops = {
>  	.read_counter		= uncore_mmio_read_counter,
>  };
>  
> +static struct uncore_event_desc spr_uncore_imc_events[] = {
> +	INTEL_UNCORE_EVENT_DESC(clockticks,      "event=0x01,umask=0x00"),
> +	INTEL_UNCORE_EVENT_DESC(cas_count_read,  "event=0x05,umask=0xcf"),
> +	INTEL_UNCORE_EVENT_DESC(cas_count_read.scale, "6.103515625e-5"),
> +	INTEL_UNCORE_EVENT_DESC(cas_count_read.unit, "MiB"),
> +	INTEL_UNCORE_EVENT_DESC(cas_count_write, "event=0x05,umask=0xf0"),
> +	INTEL_UNCORE_EVENT_DESC(cas_count_write.scale, "6.103515625e-5"),
> +	INTEL_UNCORE_EVENT_DESC(cas_count_write.unit, "MiB"),
> +	{ /* end: all zeroes */ },
> +};
> +
>  static struct intel_uncore_type spr_uncore_imc = {
>  	SPR_UNCORE_COMMON_FORMAT(),
>  	.name			= "imc",
> @@ -6075,6 +6086,7 @@ static struct intel_uncore_type spr_uncore_imc = {
>  	.fixed_ctr		= SNR_IMC_MMIO_PMON_FIXED_CTR,
>  	.fixed_ctl		= SNR_IMC_MMIO_PMON_FIXED_CTL,
>  	.ops			= &spr_uncore_mmio_ops,
> +	.event_descs		= spr_uncore_imc_events,
>  };
>  
>  static void spr_uncore_pci_enable_event(struct intel_uncore_box *box,