Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Apr 2023 14:47:40 +0100
From:   Chris Down <chris@chrisdown.name>
To:     John Ogness <john.ogness@linutronix.de>
Cc:     linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>, kernel-team@fb.com
Subject: Re: [PATCH v4 1/2] printk: Do not delay messages which aren't
 solicited by any console
Message-ID: <ZEFCfJLteNo91n-f@chrisdown.name>
References: <cover.1681994220.git.chris@chrisdown.name>
 <43d7f8d6e4b45a1a76fceef2d117bbc3954bc0bf.1681994221.git.chris@chrisdown.name>
 <87wn26vg3p.fsf@jogness.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <87wn26vg3p.fsf@jogness.linutronix.de>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk

John Ogness writes:
>On 2023-04-20, Chris Down <chris@chrisdown.name> wrote:
>> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
>> index fd0c9f913940..06f16a5f1516 100644
>> --- a/kernel/printk/printk.c
>> +++ b/kernel/printk/printk.c
>> @@ -1289,15 +1289,13 @@ static int __init boot_delay_setup(char *str)
>>  }
>>  early_param("boot_delay", boot_delay_setup);
>>
>> -static void boot_delay_msec(int level)
>> +static void boot_delay_msec(void)
>>  {
>>  	unsigned long long k;
>>  	unsigned long timeout;
>>
>>  	if ((boot_delay == 0 || system_state >= SYSTEM_RUNNING)
>
>            ^----- you will need to remove this paren as well

That'll teach me to compile test without remembering it also needs 
CONFIG_BOOT_PRINTK_DELAY=y :-) Thanks.

>
>> -		|| suppress_message_printing(level)) {
>>  		return;
>> -	}
>
>John Ogness