Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0b01ff9d-95c0-02d6-ba77-9af234e02a2f@amd.com>
Date:   Thu, 20 Apr 2023 10:19:05 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] drm/amd/display: remove unused variables otg_inst and cmd
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, harry.wentland@amd.com,
        sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        qingqing.zhuo@amd.com, wenjing.liu@amd.com, Jun.Lei@amd.com,
        Josip.Pavic@amd.com, Leon.Huang1@amd.com,
        Nicholas.Kazlauskas@amd.com
Cc:     dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230420020422.3256782-1-trix@redhat.com>
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230420020422.3256782-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHZaZzJrTUtKTG5qakhOcy9lVlFyczRDY2pFUlg2MTZXbUhhcHA5cW9WT1Rs?=
 =?utf-8?B?eFJmZWxUVE9aeGNqQSs5dFB5VjJjNmcyRmc4Y2FwUzdlREpRdVVPanZ3MWJk?=
 =?utf-8?B?YWV2Rnp6L3hDLzY5Rk9WeklhOVFLWTVwQi9sWjBqTDliYTN1V1J3cFB6Mm1S?=
 =?utf-8?B?SXBvQllEc3dmUStmcXJGNmlNNjc4WXVDVWxqZyt4dGN4alUyc1Bsdk02d0Jp?=
 =?utf-8?B?K3JrWmtpWE5tNmJLbkVZUE9uVmsyblBET2dWeGE5QWllM3l3RGZ3VU5JeTgy?=
 =?utf-8?B?alVjRElXdWhrVnBmL05TbTlyTzBjODhaVnpUbW1FdXhua280RjU1UFEzT2ZN?=
 =?utf-8?B?RlNXdHR3elc2UURSNWtkTmdOZC8xSE1mZmFJbC83MkpWSGpSSHZNVkhBR2Y2?=
 =?utf-8?B?WE05dXgrS0tZdmNOb2FwYTJxaU9JT2hHMzBPM0ZBdGhKMFVBcTE2SDBzbTBN?=
 =?utf-8?B?U1hUMWtieUtxK1BKQUdRY1JyY2tNRXluT1R6UDB5V1BXT01Rd3psdDNhRlhp?=
 =?utf-8?B?RE4rWnFjbEtTQWFGOFN3OFVFNytobVYrcHFkNldhcmNUZnBIelVpcllZWnZx?=
 =?utf-8?B?WmRZRVhtRUFKNXJNbFFqeTZSYVVqaGZ6ejB5ZmczTDN2STRmQTVNUUNBOGMx?=
 =?utf-8?B?UklQcmdiVjd5NVpCclF0R3lXaWNDcWFWMTg3bjJQSmR4WHlnVUg5SU8rNGxh?=
 =?utf-8?B?S3lPcjJPaGZaU2pISEFZRG0xLzYrY2xmUmFzUnRuYXpuZzNtd2ljMlV3UGo4?=
 =?utf-8?B?MkxhTFliYmJyRkE4TUovOWc1dm1rMythRVUwNHR2YVRKRm9lTE1NV050NEJZ?=
 =?utf-8?B?c1RRcXd1TXVobzkzMGx3bEZRYnFNakJTOGozeUh1cUtEMjcwREgvQ2NYZVVK?=
 =?utf-8?B?eGVpMVVlR3ROVDBuMGV0ZEVmcHJ2dEdDRkZNMTF3Mkg1Q0o1cTdjOXhDSXlh?=
 =?utf-8?B?VTVrWFFpMkxIMU81Zy9iUWhoNWdocXFVWndBTHY2UkQ5cjRFdkZHWTBqT1FB?=
 =?utf-8?B?enBqTjNLaGVUOGl3WkUwQ09NRWhxSm54Q29PM3VMOGQ0WTU1dU0rOFI1MEkv?=
 =?utf-8?B?dHIzc1NCZGUxQ1o3bEJiVW9nUXI5Uk1BQ0Y3cTZ6Z3ZqaDZNTkxBMWN5VGh5?=
 =?utf-8?B?cWRha1crUFZMUXNQSTFLL0drK0N0U2F4RnlRVTFIcVIrNnd1NkRPNFh0bVdo?=
 =?utf-8?B?K1hiWkl3SzVCUVA4OFAveFFZT3ZCQ2FMd0VLTXRJYnFVVUR4azdCNG5EbjBT?=
 =?utf-8?B?eSs4R1M1TkRyRzBaNGxSd1kxZHBpSzNPNGxEelJmbGZWcGk1VGRoNWsySmFh?=
 =?utf-8?B?aUV2SjV5MDBZRFM5bklvYXZXZnljcnhVUlIraG00cmtSR0NzdHRxY2lSYk50?=
 =?utf-8?B?S0xKc1UyU0RPczIzME1xeWZsNHJQbDRLMTdmZnpMemZKZURycTZxRFNOSkgx?=
 =?utf-8?B?a29PemJueTZUaXNXOFVaZTYwYW5yY2g1SFNNL25rOFp4cnc3TXNaRWtCYmJJ?=
 =?utf-8?B?ZEJLVGxUVWV6N0FQRVpjMmEvd3JkU3RXaHAybVpDTWU5dVZsbTIwY1V6aG80?=
 =?utf-8?B?d2NzMEtnUFlUNThoVS9vRHc1bDNrcXI2MEd6WStJVW5LUjI5Z0JneTZPU3lr?=
 =?utf-8?B?ejh0NEFtZVVrcWpEU3M1YzlnclpXZzRsMWRBY05Pa1Z5S0Z5R0FTbG5mWU9i?=
 =?utf-8?B?MFQzQkNvRjFHcGhxc1YrMW5pdWd1U2htUW9rdWY0eUpLNlZ4NUZQMFhWWHkw?=
 =?utf-8?B?T01rVElVNFlFTXZkMWt2RmdyL1h6WEpjVzhFbFlnNFd5cGZPMnU1YVlqbU16?=
 =?utf-8?B?RE5kU3dxaWMrT2cyNkRiWE1QUzF3ZTdBcVdJeTUwb0NxRjdiTmNvdll1clY0?=
 =?utf-8?B?amFkQ3pSaUF5eVlCbVZaTFA0OExrTkYybHovRHovWFlRVGMvM2tBeHpSOGdG?=
 =?utf-8?B?d1hnakxMeU9VcUF2SVRCMkVpWWFEckgzaklXL2d5ZDVmQkgvOW5UcU5IdTlL?=
 =?utf-8?B?Zmowbk1XYmNMZzNYcHJKSWwwUEZtSGFDN0hpRm1tRzV4MFhtaVJpZ2hlL21k?=
 =?utf-8?B?cmo4NDluSWN0dWN2aVhCeHdEdklpVjlVRlhSMW5vS0VrQkNycjBQMTRoeFZH?=
 =?utf-8?Q?3QJEDAhOrBa2XRP1yrj2F1Msl?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82bcb6dc-989a-4194-0218-08db41a9ffe6
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2023 14:17:40.4063
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eyDexukq4uKYYhYEQBubZ1dtCOWeVparYz6CsnkCKH87eD85gt7/uGZ2hfnloFHYmNRtaFw/It2DQHdkcWWWAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6557
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/19/23 22:04, Tom Rix wrote:
> gcc reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:
>    In function ‘dcn21_set_backlight_level’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:229:18:
>    error: unused variable ‘otg_inst’ [-Werror=unused-variable]
>    229 |         uint32_t otg_inst = pipe_ctx->stream_res.tg->inst;
>        |                  ^~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:226:27:
>    error: unused variable ‘cmd’ [-Werror=unused-variable]
>    226 |         union dmub_rb_cmd cmd;
>        |                           ^~~
> 
> These variables are not used, so remove them.
> 
> Fixes: e97cc04fe0fb ("drm/amd/display: refactor dmub commands into single function")
> Signed-off-by: Tom Rix <trix@redhat.com>

This has already been fixed, as of commit 1adb4dd5bd4b
("drm/amd/display: Remove unused variables in dcn21_hwseq.c") in
amd-staging-drm-next.

> ---
>   drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c
> index 55a464a39529..43463d08f21b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c
> @@ -223,10 +223,8 @@ bool dcn21_set_backlight_level(struct pipe_ctx *pipe_ctx,
>   		uint32_t backlight_pwm_u16_16,
>   		uint32_t frame_ramp)
>   {
> -	union dmub_rb_cmd cmd;
>   	struct dc_context *dc = pipe_ctx->stream->ctx;
>   	struct abm *abm = pipe_ctx->stream_res.abm;
> -	uint32_t otg_inst = pipe_ctx->stream_res.tg->inst;
>   	struct panel_cntl *panel_cntl = pipe_ctx->stream->link->panel_cntl;
>   
>   	if (dc->dc->res_pool->dmcu) {
-- 
Hamza