Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Apr 2023 16:43:20 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Michal Kubecek <mkubecek@suse.cz>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Petr Machata <petrm@nvidia.com>,
        Danielle Ratson <danieller@nvidia.com>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Aaron Conole <aconole@redhat.com>,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next 5/9] net: ethtool: mm: sanitize some UAPI
 configurations
Message-ID: <ZEFPiMG8Rn5Mc3g5@corigine.com>
References: <20230418111459.811553-1-vladimir.oltean@nxp.com>
 <20230418111459.811553-6-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230418111459.811553-6-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?52ZYbxd/fs9eyW3PUiT0wI9e9tSNpy8yEFo9Ngf1w6J9tWNYsYGd1HiARr7t?=
 =?us-ascii?Q?DtVOQJRp0ulfPkOPS22a0AbUt164+wDk7CwwFxpBz9zKipJP2FVKVFdkMnvT?=
 =?us-ascii?Q?r/o/C2N90HniAUohbr35wJIWcigxxkcbi8gZrOHmzS97hg/kNLQZm34HBwmg?=
 =?us-ascii?Q?AoV4fEPRxdiio2doeb5pBtDDsEPH9kiX+TkEm5Xp9vlVFSjGlmKx1ObxWe6+?=
 =?us-ascii?Q?dvXN5a7s8S/tGztmrv3mRVw2HSw2G/rRqxS/yr7AMhXOp/kG+wTxmU2Lbpp6?=
 =?us-ascii?Q?JU3tL7IopY8zCwmP3DNYanhzv9l2MOK3Ck/4hBlgzayXATHAYmyb9qaBN4Qh?=
 =?us-ascii?Q?YicF1lgU59Xn1zAsgnSolsW8devyG7KnFGaa5Br2BXv/+UPTwxK4iBslpLpg?=
 =?us-ascii?Q?n7lln0HiF31sOwrOo+1qE3q2liOy1r+vPdCzLQzDo9Hro+gcvk379EOLubw/?=
 =?us-ascii?Q?rAVyrIWx0JoRyqwtNA9Wrqt4/iHfvK7sv9pIP7YVgb82ZpDw1aMNmfe2QljU?=
 =?us-ascii?Q?byOurCmIopUCeiRNg5z9/r261KXqCl/qvKi00RKr0fTCN2xQz56ep+6lWE2S?=
 =?us-ascii?Q?R8PhNHE7XUe5WBNghEaloB3SePWrtPfwh8H58mLXYuoGWWJGM59/JcbgbRT8?=
 =?us-ascii?Q?ra8mLQ26Isg8KwDrxFpBpn4wsWXEqRA/9fqw2E85/dDh1ITlUkp2MwUEuo/6?=
 =?us-ascii?Q?MXhYqGue0YN1l87kpDJrmik714oMHetm460p79ohOQwn6DKWk3D2NLzkETwi?=
 =?us-ascii?Q?MXgDYT9MYsdw3+8lsOiHddx5apQv5JTw4NQdoVhd8EFArKwtRkYepU1vCemH?=
 =?us-ascii?Q?iJq2h30HbdrXbmTwz5P28Q47VIphcQtTrobLPgcqxGCp2bfEg52gwkoVYcYI?=
 =?us-ascii?Q?NIMgx309wG8JL2nhg8hz19WIWXEGRRI4MbzdRzrKdUVnKHNTs650JFS5a58w?=
 =?us-ascii?Q?cq4mtqLwwxTkPpdb6qROvyFdEAxCc6tk0JA21GMZa4jrQ3dy25RHks0T/BVG?=
 =?us-ascii?Q?chgjF9JABCFrU2OfGDEm6vcUI9zNhLV2lu8c3ysDNZYyJKgIh1LLvQydhktK?=
 =?us-ascii?Q?m361ATDRQzyR+imcQnatKQ9cgGZ5Z2fOHEGuohyiPuqZaJPWF+8MZOw+EgJY?=
 =?us-ascii?Q?6QDfATcztCeqSNzmUaP59jp96/rWwfuJ7z9wuv11Tbr3sr8tg4pKEaWv/qmI?=
 =?us-ascii?Q?skKicOOsLBDXdETSirYrrC0XHfktZWEE2Us+KhlbiRngzPKNigmYxs101NCK?=
 =?us-ascii?Q?AM3WdmglsPHwcS+6087Lf1H0p3ViCm37Uh9Ma4egt36nKJOp8nisUc9BlZIt?=
 =?us-ascii?Q?6Wf8E6KlbWh1SeY9B8Opijul8SMIWd4IqfVZ8hMt8u5++nSuNPp1EtfMajwx?=
 =?us-ascii?Q?kNtNrkmeFnAI+10mP3DvJr3BBCcyZO5xUWSmDp9gdHjGhi9qMRTaqlq12Fgb?=
 =?us-ascii?Q?FZ7mkA1mySD9WJ4gcDYlFNIKXWYFygtgUfgHOO4SuRw1gsx85eoJ5X4yxcw4?=
 =?us-ascii?Q?SG/RSgBTk/4fxHnMDHn+89NqAHI4UrAzuhWtwzBM4RaLXrLfcOW70m7BLcVh?=
 =?us-ascii?Q?Q1YVzmj1DCRHie2CGEN06l87BrRubwLdj1t67GcEbfaeDQPO05X0Fc2Xm5ex?=
 =?us-ascii?Q?16yLFYFpSgnatDdQU6vcMRKNDARxRWKAyO1QqgaDxFbBa2x47MEdfjf74BLM?=
 =?us-ascii?Q?b2cDjQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f37f702-bbf3-4dc4-35ce-08db41ad9acd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2023 14:43:28.9086
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /2pTIPockZflqV7smIZSfojAJh5+up28S9Ovw300a0DAIIgisQOzuMgqkPB5A42hxzb8j3FA7KqhWeqhGYciTpF1JLvt0QNsHhCdQnAa/Dc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB4410
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 18, 2023 at 02:14:55PM +0300, Vladimir Oltean wrote:
> The verify-enabled boolean (ETHTOOL_A_MM_VERIFY_ENABLED) was intended to
> be a sub-setting of tx-enabled (ETHTOOL_A_MM_TX_ENABLED). IOW, MAC Merge
> TX can be enabled with or without verification, but verification with TX
> disabled makes no sense.
> 
> The pmac-enabled boolean (ETHTOOL_A_MM_PMAC_ENABLED) was intended to be
> a global toggle from an API perspective, whereas tx-enabled just handles
> the TX direction. IOW, the pMAC can be enabled with or without TX, but
> it doesn't make sense to enable TX if the pMAC is not enabled.
> 
> Add two checks which sanitize and reject these invalid cases.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>