Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Apr 2023 17:56:22 +0200
From:   Michal Kubiak <michal.kubiak@intel.com>
To:     Ding Hui <dinghui@sangfor.com.cn>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,
        <jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
        <keescook@chromium.org>, <grzegorzx.szczurek@intel.com>,
        <mateusz.palczewski@intel.com>, <mitch.a.williams@intel.com>,
        <gregory.v.rose@intel.com>, <jeffrey.t.kirsher@intel.com>,
        <simon.horman@corigine.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>,
        <pengdonglin@sangfor.com.cn>, <huangcun@sangfor.com.cn>
Subject: Re: [PATCH net v2 0/2] iavf: Fix issues when setting channels
 concurrency with removing
Message-ID: <ZEFgplaRuxaBRxlB@localhost.localdomain>
References: <20230419150709.24810-1-dinghui@sangfor.com.cn>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230419150709.24810-1-dinghui@sangfor.com.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iavcOl8pcEXfk9Ic041PpMD9D7wBdBmCBlqGZYzziCabJQfEMvkJLqy1aUlC?=
 =?us-ascii?Q?gJ3on8Fo8yvrMHOy2cBGsIfKqqcj/KD0z0YnOtamW+KMF3vnlv9rpirEjci4?=
 =?us-ascii?Q?kmGtnu4vd0eeqOVdIUNGXfAtWYd1cBEGpVO1ydCWmmud0jYDDd+7O6qwdPCJ?=
 =?us-ascii?Q?BNY/1lndSwz1OmA2JMtqRw/Kun2L32JV2XZr9faRfTOZsDeuoKK9lZX+IIVi?=
 =?us-ascii?Q?eD/BF7RpWO4j411IX/gNpZFCm6weO7blaoAZDvqB0sa43lsJYg5sdBMU/Fox?=
 =?us-ascii?Q?24w6no1SBXU9UVvdiTqeWuw45wzdsuAykV8WwPnj4Jn9VN/zhTqJMx7PHfQU?=
 =?us-ascii?Q?OmsVJNUBQ2+BxZTj1aI/rXo0bJwwyGfv1bW1rLk/AtMlDxOpct8LCLtIPuQM?=
 =?us-ascii?Q?1OS7RkCyVZEqPf5UdzFqI+tSemapS476YEx1qve3ttui2zhPZ3C50DilviRA?=
 =?us-ascii?Q?8bl/KF0Ov1d96Xuh3sfd265lwOlCD65+j+Yd/2sinTxsvaxdze1f/DB90HqA?=
 =?us-ascii?Q?Y2bwcxoTSFwZnCh4CS3ooo1NtDubRLpFcrtzYAC9QgdyMt4cs1emy478vFHT?=
 =?us-ascii?Q?OkMOeS6w3xf0H1JLxhjGvFjTA0e+47c0CJykGVC4qHhiJhasRFUSsSKi3ubE?=
 =?us-ascii?Q?4RNESSLbR8uTd/Ln8Rixn6QVuxZklVlvkyxR1irOCSjgxpIHq/cu6q4b7MfE?=
 =?us-ascii?Q?oaL6ZgDLkxPXcdkoCd86VM2nS9ggUS5LgWKfgBlRDyL+yxY9ZjZK0GeDG0tQ?=
 =?us-ascii?Q?0yCEDJT9PTis4K4tQqSBhC7lgRBI20di2ydcufx4T9wVWV+2XKQAp9UzRtZO?=
 =?us-ascii?Q?7rJE2lFBlj7ytybbQh5/wxNhpWmTKLB9NKDzTyAt6tfKc6RniJ7FFMJhd5eB?=
 =?us-ascii?Q?KhGobkRGxNdWjRJZgK5dwxUgrwcmu+DGjrTUMfJnkl5d6nEObCzqxuLaLvf5?=
 =?us-ascii?Q?xpjB8lHyGpTkfwsww2JQPORpjrh8ulGclHgwuA3u0m4Wg0mgIQM5UHbNqskM?=
 =?us-ascii?Q?/RZZzqVGtXH/8Ka0qQVUpkv9IXEWG7lrB9OqgrJDF9Xc5pgWHJx5s4JwHvbm?=
 =?us-ascii?Q?kEuh05iuIIGk8bIsoIsbS9dq+wwVgHlXRP+RM+oeig17w3qd9xwV78zSOL17?=
 =?us-ascii?Q?7WyWxPsahYxpXqe/mDG3yMPWSA64dONL+VMJbB4XAJaV+OWcjgc3/ZTP1ZnD?=
 =?us-ascii?Q?gPr1se+CYCreCxz5AYSBSFf8b/s+sf+WvB8CiOVyN/k7P3/wekSELnuPopd4?=
 =?us-ascii?Q?9pDZlNiY4+Hezg7avwgXEq6SDf/7J1R7oInNSDw4IHLI8cQJ6RtwI1t4LBqg?=
 =?us-ascii?Q?HVd9fUfSNGcjWC7cYze2BaaQKIvBXNXLSusW1tAfyB89rjooFLz44sgM9YEK?=
 =?us-ascii?Q?oS0FKvJQ9fG/4aHeYT3ENAorlXZxx1opEUe5Z55LTkzjiJxHxeDVDiGD+lsH?=
 =?us-ascii?Q?IsXzDgRgErh7KdcuOqay23FtZ8i/JaCa80tIwSQPYKzbLqcNkZr5Dq9QBq/I?=
 =?us-ascii?Q?q/otNNypYo5xrXTTWjhiYjFnvxPuxgfSqJnmfqDHyrqBtFvUKDhCbm90vSAv?=
 =?us-ascii?Q?NVtjvDv0cMvLyhmvyqMSjFNOUj5v/hXf4Y7miQ7JNQGDOcVMmIgdLTn4mA4/?=
 =?us-ascii?Q?kw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 26af0e0e-bb8a-48c5-f67c-08db41b7cea3
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2937.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2023 15:56:30.7060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 28bkG/1+T7CbNRksu2IP7I+IxI0Q1K5LhVDAH/HSzlt2KjIhaVgwiE2uNCxwMBjcsQnT72a9oqHqZ+XYSSceSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6430
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 19, 2023 at 11:07:07PM +0800, Ding Hui wrote:
> The patchset fix two issues which can be reproduced by the following script:
> 
> [root@host ~]# cat repro.sh
> #!/bin/bash
> 
> pf_dbsf="0000:41:00.0"
> vf0_dbsf="0000:41:02.0"
> g_pids=()
> 
> function do_set_numvf()
> {
>     echo 2 >/sys/bus/pci/devices/${pf_dbsf}/sriov_numvfs
>     sleep $((RANDOM%3+1))
>     echo 0 >/sys/bus/pci/devices/${pf_dbsf}/sriov_numvfs
>     sleep $((RANDOM%3+1))
> }
> 
> function do_set_channel()
> {
>     local nic=$(ls -1 --indicator-style=none /sys/bus/pci/devices/${vf0_dbsf}/net/)
>     [ -z "$nic" ] && { sleep $((RANDOM%3)) ; return 1; }
>     ifconfig $nic 192.168.18.5 netmask 255.255.255.0
>     ifconfig $nic up
>     ethtool -L $nic combined 1
>     ethtool -L $nic combined 4
>     sleep $((RANDOM%3))
> }
> 
> function on_exit()
> {
>     local pid
>     for pid in "${g_pids[@]}"; do
>         kill -0 "$pid" &>/dev/null && kill "$pid" &>/dev/null
>     done
>     g_pids=()
> }
> 
> trap "on_exit; exit" EXIT
> 
> while :; do do_set_numvf ; done &
> g_pids+=($!)
> while :; do do_set_channel ; done &
> g_pids+=($!)
> 
> wait
> 
> 
> Ding Hui (2):
>   iavf: Fix use-after-free in free_netdev
>   iavf: Fix out-of-bounds when setting channels on remove
> 
>  drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 4 +++-
>  drivers/net/ethernet/intel/iavf/iavf_main.c    | 6 +-----
>  2 files changed, 4 insertions(+), 6 deletions(-)

For the series:
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>

> 
> -- 
> 2.17.1
>