Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1097894rwr; Thu, 20 Apr 2023 09:56:09 -0700 (PDT) X-Google-Smtp-Source: AKy350aqLV+3LeQ8K/LZinTAGAS6b1fi1btlU8YAjV6kKQ8bAXJuXD32mA7LlifTNL3Os3LSh+Fc X-Received: by 2002:a17:902:ce84:b0:1a8:11d3:6b93 with SMTP id f4-20020a170902ce8400b001a811d36b93mr2871763plg.66.1682009769268; Thu, 20 Apr 2023 09:56:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682009769; cv=none; d=google.com; s=arc-20160816; b=PIqUQeZ0ankqsAZlopcEqTsd1u+j8w1QyGcJKeViYmHiSyjKTTJtFw08ZPYh2/UOIc 1Xl1ZTTmB0nXQ29TY3eOdGI9h0RbmDPuHZS8/KYbSN7qGu934Ekku2Uqh5WWL9n4mF1B UNFHIthcKF5y87GjKb81FLlVEWmBROlU+kRx8JkE5beTXxxLgCkAqA7VR6Rv1kAkDZ8u hYRHOiVDG+eVmeD/A2/a5dync949DiSjOO01/zjeNicMdOhm0sqPHnztChzBVift0k6P zIvcd/PSViKnPNd5A33eUQ/u3igkAXpVSy3iQ3GXh4KvrU95FI7c9nx/DUdpitteNC4N WSxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=I0MN3rmC2Cti4f4qVv8lFeF+tvj8v0RUpECBbW/4GFg=; b=TofGfAhZnFiqwhDMWQe3vtJ8nlJD5oU6Z6IMwQP7R4oOflCboDfAZZcP2JFnLzE/xs PAP21le+/KBtO5mQrrL5oHTl0AvenB+6cmqRYrLjEtXwE983HL/L/gRDNtz41g+UjZdP kTAkPU8TXhOkkzT36O8j/xUZD1cTZpe2MCY3GyYtmj+HCPBdojD0jecFocJSl1SCtjne WPd+B7vuAlPkErnOGMwIrdtD6Qz1UHiAQJNlO5yJQcOpDssbNsBUmuOF+o8xFdcyxlkZ vgi4Xx7iH3ySpBteIE5LfiDPPH048DVqz9UxE9qdivclNFyrhubEZoq4c+a2iwDPHU2O 6dgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=deH7FOyY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j5-20020a170903024500b001a55571febesi2416056plh.277.2023.04.20.09.55.57; Thu, 20 Apr 2023 09:56:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=deH7FOyY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbjDTQzR (ORCPT + 99 others); Thu, 20 Apr 2023 12:55:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230187AbjDTQzH (ORCPT ); Thu, 20 Apr 2023 12:55:07 -0400 Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 285B74221; Thu, 20 Apr 2023 09:55:03 -0700 (PDT) Received: by mail-oo1-xc2f.google.com with SMTP id bb7-20020a056820160700b00546d9935668so830016oob.8; Thu, 20 Apr 2023 09:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682009702; x=1684601702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=I0MN3rmC2Cti4f4qVv8lFeF+tvj8v0RUpECBbW/4GFg=; b=deH7FOyY31CM0n5o0pz6bFBR91hNGcPJos7XSjBHrF3i+Z25ls1hrwnwrIDUrk3seQ 6p4hV+lXFyjWunw+eD2+gOzEhmJzY034WlV1qjqe0RiJTZAoEdg7kMRig/x0zQRfKFqW 7GM9ZOtHH9yDWHys3diY91PATwSpp6K/X8FjMOnKcvXNRr+N3b1Y1z3BKqrQw+gd4e7p jQyY6XMovs4Y8gG+m8zGQiZZvBe40B5SfInd34KyEGQvvhipIspms7rFsY/auTcL+2/f 21M+mNnN8w1zeiylFzE506NNbyQ4Btsb/ok4JGWdk6tpjTz/bcsBSsuVR+7kEDcm7g4J qbSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682009702; x=1684601702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I0MN3rmC2Cti4f4qVv8lFeF+tvj8v0RUpECBbW/4GFg=; b=fNGLlzeMvNs5z77E5DCoEef3raahHbeS1qG+H7W2GlZzTKaFpU9Zzl9Hg8hYqNSJUD OoQmT7znt8dgxjvGx7qwPSn5yaya5geNnjb+6Wv7Ck5wEl01Vv97btrCkHbTU1yiYnUF sG+IqjTiMA+VcbSiqm+sWJDGUXCpbn4VFk/ONiPVDAssZoWxexcOvFRCqJFtzP8xA7DT BmN9b0bs+hgAOlERGnrjCEjRfhhmcw5hXOPRa+AN8E06Jos8CD7naA0IJ/jUomD85NLk 4ylrcRKHrf15uruO944vVuR5fh6Q4qY6YwmO+PVmmSQc+nJ2Sr7N5o/LxleooksPAeDB j1Ng== X-Gm-Message-State: AAQBX9fNVcYKN0Cxow1FsZzHGvyBV15z5L7byanZ9w3x4Vb1A18o6070 wPbfYftRSoFtDrHJGeB74FUoYQXXyDg= X-Received: by 2002:a4a:2c58:0:b0:546:3aa4:3dba with SMTP id o85-20020a4a2c58000000b005463aa43dbamr1193770ooo.7.1682009702398; Thu, 20 Apr 2023 09:55:02 -0700 (PDT) Received: from grumpy-VECTOR.hsd1.tx.comcast.net ([2601:2c3:480:7390:d090:9746:e449:eb46]) by smtp.gmail.com with ESMTPSA id s129-20020a4a5187000000b005252e5b6604sm791913ooa.36.2023.04.20.09.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 09:55:01 -0700 (PDT) From: Jorge Lopez X-Google-Original-From: Jorge Lopez To: hdegoede@redhat.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, thomas@t-8ch.de Subject: [PATCH v11 05/14] HP BIOSCFG driver - ordered-attributes Date: Thu, 20 Apr 2023 11:54:45 -0500 Message-Id: <20230420165454.9517-6-jorge.lopez2@hp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230420165454.9517-1-jorge.lopez2@hp.com> References: <20230420165454.9517-1-jorge.lopez2@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HP BIOS Configuration driver purpose is to provide a driver supporting the latest sysfs class firmware attributes framework allowing the user to change BIOS settings and security solutions on HP Inc.’s commercial notebooks. Many features of HP Commercial notebooks can be managed using Windows Management Instrumentation (WMI). WMI is an implementation of Web-Based Enterprise Management (WBEM) that provides a standards-based interface for changing and monitoring system settings. HP BIOSCFG driver provides a native Linux solution and the exposed features facilitates the migration to Linux environments. The Linux security features to be provided in hp-bioscfg driver enables managing the BIOS settings and security solutions via sysfs, a virtual filesystem that can be used by user-mode applications. The new documentation cover HP-specific firmware sysfs attributes such Secure Platform Management and Sure Start. Each section provides security feature description and identifies sysfs directories and files exposed by the driver. Many HP Commercial notebooks include a feature called Secure Platform Management (SPM), which replaces older password-based BIOS settings management with public key cryptography. PC secure product management begins when a target system is provisioned with cryptographic keys that are used to ensure the integrity of communications between system management utilities and the BIOS. HP Commercial notebooks have several BIOS settings that control its behaviour and capabilities, many of which are related to security. To prevent unauthorized changes to these settings, the system can be configured to use a cryptographic signature-based authorization string that the BIOS will use to verify authorization to modify the setting. Linux Security components are under development and not published yet. The only linux component is the driver (hp bioscfg) at this time. Other published security components are under Windows. Signed-off-by: Jorge Lopez --- Based on the latest platform-drivers-x86.git/for-next --- .../x86/hp/hp-bioscfg/ordered-attributes.c | 563 ++++++++++++++++++ 1 file changed, 563 insertions(+) create mode 100644 drivers/platform/x86/hp/hp-bioscfg/ordered-attributes.c diff --git a/drivers/platform/x86/hp/hp-bioscfg/ordered-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/ordered-attributes.c new file mode 100644 index 000000000000..5e5d540f728d --- /dev/null +++ b/drivers/platform/x86/hp/hp-bioscfg/ordered-attributes.c @@ -0,0 +1,563 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Functions corresponding to ordered list type attributes under + * BIOS ORDERED LIST GUID for use with hp-bioscfg driver. + * + * Copyright (c) 2022 HP Development Company, L.P. + */ + +#include "bioscfg.h" + +GET_INSTANCE_ID(ordered_list); + +static ssize_t current_value_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) +{ + + int instance_id = get_ordered_list_instance_id(kobj); + + if (instance_id < 0) + return -EIO; + + return sysfs_emit(buf, "%s\n", + bioscfg_drv.ordered_list_data[instance_id].current_value); +} + +/* + * validate_ordered_list_value - + * Validate input of current_value against possible values + * + * @instance_id: The instance on which input is validated + * @buf: Input value + */ +static int validate_ordered_list_values(int instance_id, const char *buf) +{ + int ret = 0; + int found = 0; + char *new_values = NULL; + char *value; + int elem; + int elem_found = 0; + + /* Is it a read only attribute */ + if (bioscfg_drv.ordered_list_data[instance_id].common.is_readonly) + return -EIO; + + new_values = kstrdup(buf, GFP_KERNEL); + + /* + * Changes to ordered list values require checking that new + * values are found in the list of elements. + */ + elem_found = 0; + while (elem_found < bioscfg_drv.ordered_list_data[instance_id].elements_size) { + + value = strsep(&new_values, ","); + if (value != NULL) { + if (!*value) + continue; + elem_found++; + } + + found = 0; + for (elem = 0; elem < bioscfg_drv.ordered_list_data[instance_id].elements_size; elem++) { + if (!strcasecmp(bioscfg_drv.ordered_list_data[instance_id].elements[elem], value)) { + found = 1; + break; + } + } + + + if (!found) { + ret = -EINVAL; + goto out_list_value; + } + } + + if (elem_found == bioscfg_drv.ordered_list_data[instance_id].elements_size) { + pr_warn("Number of new values is not equal to number of ordered list elements (%d)\n", + bioscfg_drv.ordered_list_data[instance_id].elements_size); + ret = -EINVAL; + goto out_list_value; + } + +out_list_value: + kfree(new_values); + return ret; +} + +/* + * validate_ordered_input() - + * Validate input of current_value against possible values + * + * @instance_id: The instance on which input is validated + * @buf: Input value + */ +static int validate_ordered_list_input(int instance_id, const char *buf) +{ + int ret = 0; + + ret = validate_ordered_list_values(instance_id, buf); + if (ret < 0) + return -EINVAL; + + /* + * set pending reboot flag depending on + * "RequiresPhysicalPresence" value + */ + if (bioscfg_drv.ordered_list_data[instance_id].common.requires_physical_presence) + bioscfg_drv.pending_reboot = true; + + return ret; +} + +static void update_ordered_list_value(int instance_id, char *attr_value) +{ + strscpy(bioscfg_drv.ordered_list_data[instance_id].current_value, + attr_value, + sizeof(bioscfg_drv.ordered_list_data[instance_id].current_value)); +} + +ATTRIBUTE_S_COMMON_PROPERTY_SHOW(display_name_language_code, ordered_list); +static struct kobj_attribute ordered_list_display_langcode = + __ATTR_RO(display_name_language_code); + +ATTRIBUTE_S_COMMON_PROPERTY_SHOW(display_name, ordered_list); +static struct kobj_attribute ordered_list_display_name = + __ATTR_RO(display_name); + +ATTRIBUTE_PROPERTY_STORE(current_value, ordered_list); +static struct kobj_attribute ordered_list_current_val = + __ATTR_RW_MODE(current_value, 0644); + + +ATTRIBUTE_N_COMMON_PROPERTY_SHOW(prerequisites_size, ordered_list); +static struct kobj_attribute ordered_list_prerequisites_size_val = + __ATTR_RO(prerequisites_size); + +ATTRIBUTE_V_COMMON_PROPERTY_SHOW(prerequisites, ordered_list); +static struct kobj_attribute ordered_list_prerequisites_val = + __ATTR_RO(prerequisites); + +ATTRIBUTE_N_PROPERTY_SHOW(elements_size, ordered_list); +static struct kobj_attribute ordered_list_elements_size_val = + __ATTR_RO(elements_size); + +ATTRIBUTE_VALUES_PROPERTY_SHOW(elements, ordered_list); +static struct kobj_attribute ordered_list_elements_val = + __ATTR_RO(elements); + +static ssize_t type_show(struct kobject *kobj, struct kobj_attribute *attr, + char *buf) +{ + return sysfs_emit(buf, "ordered-list\n"); +} +static struct kobj_attribute ordered_list_type = + __ATTR_RO(type); + +static struct attribute *ordered_list_attrs[] = { + &ordered_list_display_langcode.attr, + &ordered_list_display_name.attr, + &ordered_list_current_val.attr, + &ordered_list_prerequisites_size_val.attr, + &ordered_list_prerequisites_val.attr, + &ordered_list_elements_val.attr, + &ordered_list_elements_size_val.attr, + &ordered_list_type.attr, + NULL +}; + +static const struct attribute_group ordered_list_attr_group = { + .attrs = ordered_list_attrs, +}; + +int alloc_ordered_list_data(void) +{ + int ret = 0; + + bioscfg_drv.ordered_list_instances_count = + get_instance_count(HP_WMI_BIOS_ORDERED_LIST_GUID); + bioscfg_drv.ordered_list_data = kcalloc(bioscfg_drv.ordered_list_instances_count, + sizeof(struct ordered_list_data), GFP_KERNEL); + if (!bioscfg_drv.ordered_list_data) { + bioscfg_drv.ordered_list_instances_count = 0; + ret = -ENOMEM; + } + return ret; +} + +/* + * populate_ordered_list_package_data() - + * Populate all properties of an instance under ordered_list attribute + * + * @order_obj: ACPI object with ordered_list data + * @instance_id: The instance to enumerate + * @attr_name_kobj: The parent kernel object + */ +int populate_ordered_list_package_data(union acpi_object *order_obj, int instance_id, + struct kobject *attr_name_kobj) +{ + bioscfg_drv.ordered_list_data[instance_id].attr_name_kobj = attr_name_kobj; + + populate_ordered_list_elements_from_package(order_obj, + order_obj->package.count, + instance_id); + update_attribute_permissions(bioscfg_drv.ordered_list_data[instance_id].common.is_readonly, + &ordered_list_current_val); + friendly_user_name_update(bioscfg_drv.ordered_list_data[instance_id].common.path, + attr_name_kobj->name, + bioscfg_drv.ordered_list_data[instance_id].common.display_name, + sizeof(bioscfg_drv.ordered_list_data[instance_id].common.display_name)); + return sysfs_create_group(attr_name_kobj, &ordered_list_attr_group); +} + +/* Expected Values types associated with each element */ +static const acpi_object_type expected_order_types[] = { + [NAME] = ACPI_TYPE_STRING, + [VALUE] = ACPI_TYPE_STRING, + [PATH] = ACPI_TYPE_STRING, + [IS_READONLY] = ACPI_TYPE_INTEGER, + [DISPLAY_IN_UI] = ACPI_TYPE_INTEGER, + [REQUIRES_PHYSICAL_PRESENCE] = ACPI_TYPE_INTEGER, + [SEQUENCE] = ACPI_TYPE_INTEGER, + [PREREQUISITES_SIZE] = ACPI_TYPE_INTEGER, + [PREREQUISITES] = ACPI_TYPE_STRING, + [SECURITY_LEVEL] = ACPI_TYPE_INTEGER, + [ORD_LIST_SIZE] = ACPI_TYPE_INTEGER, + [ORD_LIST_ELEMENTS] = ACPI_TYPE_STRING +}; + + +int populate_ordered_list_elements_from_package(union acpi_object *order_obj, + int order_obj_count, + int instance_id) +{ + char *str_value = NULL; + int value_len; + int ret = 0; + u32 size = 0; + u32 int_value; + int elem = 0; + int reqs; + int eloc; + char *tmpstr = NULL; + char *part_tmp = NULL; + int tmp_len = 0; + char *part = NULL; + + if (!order_obj) + return -EINVAL; + + strscpy(bioscfg_drv.ordered_list_data[instance_id].common.display_name_language_code, + LANG_CODE_STR, + sizeof(bioscfg_drv.ordered_list_data[instance_id].common.display_name_language_code)); + + for (elem = 1, eloc = 1; elem < order_obj_count; elem++, eloc++) { + + /* ONLY look at the first ORDERED_ELEM_CNT elements */ + if (eloc == ORDERED_ELEM_CNT) + goto exit_list_package; + + switch (order_obj[elem].type) { + case ACPI_TYPE_STRING: + + if (elem != PREREQUISITES && elem != ORD_LIST_ELEMENTS) { + ret = convert_hexstr_to_str(order_obj[elem].string.pointer, + order_obj[elem].string.length, + &str_value, &value_len); + if (ret) + continue; + } + break; + case ACPI_TYPE_INTEGER: + int_value = (u32)order_obj[elem].integer.value; + break; + default: + pr_warn("Unsupported object type [%d]\n", order_obj[elem].type); + continue; + } + + /* Check that both expected and read object type match */ + if (expected_order_types[eloc] != order_obj[elem].type) { + pr_err("Error expected type %d for elem %d, but got type %d instead\n", + expected_order_types[eloc], elem, order_obj[elem].type); + return -EIO; + } + + /* Assign appropriate element value to corresponding field*/ + switch (eloc) { + case VALUE: + strscpy(bioscfg_drv.ordered_list_data[instance_id].current_value, + str_value, sizeof(bioscfg_drv.ordered_list_data[instance_id].current_value)); + break; + case PATH: + strscpy(bioscfg_drv.ordered_list_data[instance_id].common.path, str_value, + sizeof(bioscfg_drv.ordered_list_data[instance_id].common.path)); + break; + case IS_READONLY: + bioscfg_drv.ordered_list_data[instance_id].common.is_readonly = int_value; + break; + case DISPLAY_IN_UI: + bioscfg_drv.ordered_list_data[instance_id].common.display_in_ui = int_value; + break; + case REQUIRES_PHYSICAL_PRESENCE: + bioscfg_drv.ordered_list_data[instance_id].common.requires_physical_presence = int_value; + break; + case SEQUENCE: + bioscfg_drv.ordered_list_data[instance_id].common.sequence = int_value; + break; + case PREREQUISITES_SIZE: + bioscfg_drv.ordered_list_data[instance_id].common.prerequisites_size = int_value; + if (int_value > MAX_PREREQUISITES_SIZE) + pr_warn("Prerequisites size value exceeded the maximum number of elements supported or data may be malformed\n"); + + /* + * This HACK is needed to keep the expected + * element list pointing to the right obj[elem].type + * when the size is zero. PREREQUISITES + * object is omitted by BIOS when the size is + * zero. + */ + if (int_value == 0) + eloc++; + break; + case PREREQUISITES: + size = bioscfg_drv.ordered_list_data[instance_id].common.prerequisites_size; + + for (reqs = 0; reqs < size && reqs < MAX_PREREQUISITES_SIZE; reqs++) { + ret = convert_hexstr_to_str(order_obj[elem + reqs].string.pointer, + order_obj[elem + reqs].string.length, + &str_value, &value_len); + + if (ret) + continue; + + strscpy(bioscfg_drv.ordered_list_data[instance_id].common.prerequisites[reqs], + str_value, + sizeof(bioscfg_drv.ordered_list_data[instance_id].common.prerequisites[reqs])); + + kfree(str_value); + } + break; + + case SECURITY_LEVEL: + bioscfg_drv.ordered_list_data[instance_id].common.security_level = int_value; + break; + + case ORD_LIST_SIZE: + bioscfg_drv.ordered_list_data[instance_id].elements_size = int_value; + if (int_value > MAX_ELEMENTS_SIZE) + pr_warn("Ordered List size value exceeded the maximum number of elements supported or data may be malformed\n"); + /* + * This HACK is needed to keep the expected + * element list pointing to the right obj[elem].type + * when the size is zero. ORD_LIST_ELEMENTS + * object is omitted by BIOS when the size is + * zero. + */ + if (int_value == 0) + eloc++; + break; + case ORD_LIST_ELEMENTS: + size = bioscfg_drv.ordered_list_data[instance_id].elements_size; + + /* + * Ordered list data is stored in hex and comma separated format + * Convert the data and split it to show each element + */ + ret = convert_hexstr_to_str(str_value, value_len, &tmpstr, &tmp_len); + if (ret) + goto exit_list_package; + + part_tmp = tmpstr; + part = strsep(&part_tmp, ","); + if (!part) + strscpy(bioscfg_drv.ordered_list_data[instance_id].elements[0], + tmpstr, + sizeof(bioscfg_drv.ordered_list_data[instance_id].elements[0])); + + for (elem = 1; elem < MAX_ELEMENTS_SIZE && part; elem++) { + strscpy(bioscfg_drv.ordered_list_data[instance_id].elements[elem], + part, + sizeof(bioscfg_drv.ordered_list_data[instance_id].elements[elem])); + part = strsep(&part_tmp, ","); + } + + kfree(tmpstr); + break; + default: + pr_warn("Invalid element: %d found in Ordered_List attribute or data may be malformed\n", elem); + break; + } + kfree(tmpstr); + kfree(str_value); + } + +exit_list_package: + kfree(tmpstr); + kfree(str_value); + return 0; +} + +/* + * populate_ordered_list_data() - Populate all properties of an + * instance under ordered list attribute + * + * @buffer_ptr: Buffer pointer + * @buffer_size: Buffer size + * @instance_id: The instance to enumerate + * @attr_name_kobj: The parent kernel object + * @enum_property_count: Total properties count under ordered list type + */ +int populate_ordered_list_buffer_data(u8 *buffer_ptr, u32 *buffer_size, int instance_id, + struct kobject *attr_name_kobj) +{ + + bioscfg_drv.ordered_list_data[instance_id].attr_name_kobj = attr_name_kobj; + + /* Populate ordered list elements */ + populate_ordered_list_elements_from_buffer(buffer_ptr, buffer_size, + instance_id); + update_attribute_permissions(bioscfg_drv.ordered_list_data[instance_id].common.is_readonly, + &ordered_list_current_val); + friendly_user_name_update(bioscfg_drv.ordered_list_data[instance_id].common.path, + attr_name_kobj->name, + bioscfg_drv.ordered_list_data[instance_id].common.display_name, + sizeof(bioscfg_drv.ordered_list_data[instance_id].common.display_name)); + + return sysfs_create_group(attr_name_kobj, &ordered_list_attr_group); +} + +int populate_ordered_list_elements_from_buffer(u8 *buffer_ptr, u32 *buffer_size, + int instance_id) +{ + int ret; + char *dst = NULL; + int elem; + int reqs; + int integer; + int size = 0; + int values; + int dst_size = *buffer_size / sizeof(u16); + + dst = kcalloc(dst_size, sizeof(char), GFP_KERNEL); + if (!dst) + return -ENOMEM; + + elem = 0; + strscpy(bioscfg_drv.ordered_list_data[instance_id].common.display_name_language_code, + LANG_CODE_STR, + sizeof(bioscfg_drv.ordered_list_data[instance_id].common.display_name_language_code)); + + for (elem = 1; elem < 3; elem++) { + + ret = get_string_from_buffer(&buffer_ptr, buffer_size, dst, dst_size); + if (ret < 0) + continue; + + switch (elem) { + case VALUE: + strscpy(bioscfg_drv.ordered_list_data[instance_id].current_value, + dst, sizeof(bioscfg_drv.ordered_list_data[instance_id].current_value)); + break; + case PATH: + strscpy(bioscfg_drv.ordered_list_data[instance_id].common.path, dst, + sizeof(bioscfg_drv.ordered_list_data[instance_id].common.path)); + break; + default: + pr_warn("Invalid element: %d found in Ordered list attribute or data may be malformed\n", elem); + break; + } + } + for (elem = 3; elem < ORDERED_ELEM_CNT; elem++) { + + if (elem != PREREQUISITES && elem != ORD_LIST_ELEMENTS) { + ret = get_integer_from_buffer((int **)&buffer_ptr, buffer_size, (int *)&integer); + if (ret < 0) + continue; + } + + switch (elem) { + + case IS_READONLY: + bioscfg_drv.ordered_list_data[instance_id].common.is_readonly = integer; + break; + case DISPLAY_IN_UI: + bioscfg_drv.ordered_list_data[instance_id].common.display_in_ui = integer; + break; + case REQUIRES_PHYSICAL_PRESENCE: + bioscfg_drv.ordered_list_data[instance_id].common.requires_physical_presence = integer; + break; + case SEQUENCE: + bioscfg_drv.ordered_list_data[instance_id].common.sequence = integer; + break; + case PREREQUISITES_SIZE: + bioscfg_drv.ordered_list_data[instance_id].common.prerequisites_size = integer; + if (integer > MAX_PREREQUISITES_SIZE) + pr_warn("Prerequisites size value exceeded the maximum number of elements supported or data may be malformed\n"); + + // PREREQUISITES: + elem++; + size = bioscfg_drv.ordered_list_data[instance_id].common.prerequisites_size; + for (reqs = 0; reqs < size && reqs < MAX_PREREQUISITES_SIZE; reqs++) { + ret = get_string_from_buffer(&buffer_ptr, buffer_size, dst, dst_size); + if (ret < 0) + continue; + + strscpy(bioscfg_drv.ordered_list_data[instance_id].common.prerequisites[reqs], + dst, + sizeof(bioscfg_drv.ordered_list_data[instance_id].common.prerequisites[reqs])); + } + break; + case SECURITY_LEVEL: + bioscfg_drv.ordered_list_data[instance_id].common.security_level = integer; + break; + case ORD_LIST_SIZE: + bioscfg_drv.ordered_list_data[instance_id].elements_size = integer; + if (integer > MAX_ELEMENTS_SIZE) + pr_warn("Ordered List size value exceeded the maximum number of elements supported or data may be malformed\n"); + + // ORD_LIST_ELEMENTS: + elem++; + size = bioscfg_drv.ordered_list_data[instance_id].elements_size; + for (values = 0; values < size && values < MAX_ELEMENTS_SIZE; values++) { + ret = get_string_from_buffer(&buffer_ptr, buffer_size, dst, dst_size); + if (ret < 0) + continue; + + strscpy(bioscfg_drv.ordered_list_data[instance_id].elements[values], + dst, + sizeof(bioscfg_drv.ordered_list_data[instance_id].elements)[values]); + } + break; + default: + pr_warn("Invalid element: %d found in Ordered list attribute or data may be malformed\n", elem); + break; + } + } + kfree(dst); + + return 0; +} + + +/* + * exit_ordered_list_attributes() - Clear all attribute data + * + * Clears all data allocated for this group of attributes + */ +void exit_ordered_list_attributes(void) +{ + int instance_id; + + for (instance_id = 0; instance_id < bioscfg_drv.ordered_list_instances_count; instance_id++) { + struct kobject *attr_name_kobj = bioscfg_drv.ordered_list_data[instance_id].attr_name_kobj; + + if (attr_name_kobj) + sysfs_remove_group(attr_name_kobj, + &ordered_list_attr_group); + } + bioscfg_drv.ordered_list_instances_count = 0; + + kfree(bioscfg_drv.ordered_list_data); + bioscfg_drv.ordered_list_data = NULL; +} -- 2.34.1