Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Apr 2023 19:58:52 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Simon Horman <simon.horman@corigine.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Michal Kubecek <mkubecek@suse.cz>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Petr Machata <petrm@nvidia.com>,
        Danielle Ratson <danieller@nvidia.com>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Aaron Conole <aconole@redhat.com>,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next 4/9] net: enetc: include MAC Merge / FP
 registers in register dump
Message-ID: <20230420165852.op2bn3c7kdkhekvx@skbuf>
References: <20230418111459.811553-1-vladimir.oltean@nxp.com>
 <20230418111459.811553-5-vladimir.oltean@nxp.com>
 <ZEFOSGwKhIyzwWmB@corigine.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZEFOSGwKhIyzwWmB@corigine.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pW011I9AyjPtnpMZw1o5h9MBbRuF71FRqNvXgOWWAgHf3WULDZySUsCuUhrm?=
 =?us-ascii?Q?5WeNrxc9GT/0uDG8Y2Nar1bNbE4XVK7bxs6yM9lRn1XC/jWwgpwqzbRMn+/p?=
 =?us-ascii?Q?AnpBcpoTk48p8ZUSuFHjpjCc9Li6pJiXOdy9+UZ+b2uAdzJQMCkpoQgWXHn8?=
 =?us-ascii?Q?LknA80bgKYW5Ikj2TJA0F6He4IM1P8HT4cWthIZ70wPet/FcQy6QJRf9G8UA?=
 =?us-ascii?Q?AdeH5ORjOZ70O5VZWPxVxFATRwWaomlsN1GnDgrAso7l+at9RWdb4k6gWl6F?=
 =?us-ascii?Q?SWDyOrJ1hPYwu88Gyi89XnB5qlp1LjuwmT8moljG0wnBkavhfPvAI84j6QTD?=
 =?us-ascii?Q?CvwtQE8feebUgfIYwyZn3UOaWAh1mTi5QFagVOWLDub0dntD9nOl04T3SmJJ?=
 =?us-ascii?Q?pS2ikqKB9zdNbMFqupHnlHFWQmNFGjoSFX7wDQ/qmRExmURNCI5wqp9ythK/?=
 =?us-ascii?Q?yq+U32XH/JQ+PHkce4fzjROL7ilG31WEzy1O1eNNyBcqvFWh1QGyNyn7AbhM?=
 =?us-ascii?Q?XIhWQyROs+N2bpl6hF87lJT8uoL3/FxaZTv5mCN3D/+Q0ewII8/rEIg6UqxU?=
 =?us-ascii?Q?KXWlLuJWsfokDhQoHQizqQV9ONFyHdjPPwBOhO1q4GhocYEcFHGuCCLzhZUl?=
 =?us-ascii?Q?7eP9KYT+lKNPehiKSzscV7SDB1NJqbubNiHhR3+e+IQbWLJlChpGcpHlM8sv?=
 =?us-ascii?Q?JsUwLHRCuJw1pN8u7MFPleQFsobtN06Y6fVllcujuSORNIFDptlfe8NuQVbs?=
 =?us-ascii?Q?bTBn5b31Z08r1boL6xaRPxX5VmUeMtNNB96uAqOaHwXQS/h9D6hSzTYxXBBN?=
 =?us-ascii?Q?A2LzBTcfLDL1WWh6wM97N5rxVQPnSO4EyGTdW9SM8FFGSxofe7NU8orVWYeA?=
 =?us-ascii?Q?yptBwbqiBlXeksGuoJiOv0kOxIC2qx5KhjotNruNbYQHdLRLVMraIzyzxCpr?=
 =?us-ascii?Q?ztxp5f+tQ4iPPBAj2ARXqScW6MrSAx6c9Z8w+n8F07Qreafzsi7bjiyrpXWW?=
 =?us-ascii?Q?0Ugn7gBXNZ6EfN3gHUdQtxf/4xq5HUAFtnc6TRCdwHjoTNEZzUFDlWsaZGr4?=
 =?us-ascii?Q?CZzZoidJUA+Mtbz9KE6/wF4jOHVBTLZzj7KWqRQ3Ss455sN0v2HLFmkXNYF9?=
 =?us-ascii?Q?5ixoTTYRVhVwZMlyT8wkjk70MW4SuBtQakhSRznmN+pZEZdhkkCy6N38O0ii?=
 =?us-ascii?Q?P6fktxMzsaKA2HF4EA3FiCEoQXp877dPOKvoPC4LIhDP9hec2jAsh1716Iqd?=
 =?us-ascii?Q?CQYxXFfH68xdcgd+FSE5USwsxFbAg7Iv8fnY26T/8B9+poTVjOFCwu7JbmLw?=
 =?us-ascii?Q?XyAvxhRFtyBx2rP4I+cJ2xUjzvUYESJUjQodRXckMx5Yp00T2IMfk8yOJRf6?=
 =?us-ascii?Q?fmTmwtEtldXEow+Gnil4AtRPSiLdudmAgJFY5/DR4VyFZgCr7tbMvsgZEYi4?=
 =?us-ascii?Q?w+fPIxqyIOc0hXtp+otQAwNmfJsJ/vi03A7F8pMrMubZeCaQTfbYV3r9BRk5?=
 =?us-ascii?Q?2d2kADCz0Fz0pe10qoUVKwfcSR8st7SU85SLzufEXi+wC16S/G+n4crzHopi?=
 =?us-ascii?Q?5xb5JVFkwaJwEB2avVZLsuSP2fu8Q7dl6HgQgqOZiO91bGX44Ui4Imx+5yp0?=
 =?us-ascii?Q?cg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45ee3639-de8e-41cb-9ee4-08db41c08790
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2023 16:58:56.8579
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xNm/n+EIjYmeylsklNvjHGe1P2/uCABivhbKthgGkIFEW4S4I+YE3B1bSwg9VecdCd1iaD7R1JAibl3xT9CkhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8557
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 20, 2023 at 04:38:00PM +0200, Simon Horman wrote:
> > +	if (hw->port && !!(priv->si->hw_features & ENETC_SI_F_QBU))
> 
> nit: I think you could make the condition.
> 
> 	if (hw->port && priv->si->hw_features & ENETC_SI_F_QBU)
> 
> which would be consistent with the condition in the next hunk.
> 
> > +	if (priv->si->hw_features & ENETC_SI_F_QBU) {

Maybe, but it generates the exact same object code (tested with
"make drivers/net/ethernet/freescale/enetc/enetc_ethtool.lst").

When I'm debugging, I'm a bit of a conspiracy theorist when it comes
to operator precedence (& vs &&), and so, "A && B & C" doesn't read
particularly well to me, and would be one of my first suspects at
hiding a bug. I do know it would have worked in this case though,
and that modern gcc/clang usually complains about suspicious/
unintuitive precedence.