Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1159265rwr; Thu, 20 Apr 2023 10:42:50 -0700 (PDT) X-Google-Smtp-Source: AKy350au4nlj171wKrNx6kNSA05BOtBue5EE1K8lUmiWmq6imuxO0ltCTzDHCwvzasW1OHit7hrX X-Received: by 2002:a17:903:2285:b0:1a6:3737:750d with SMTP id b5-20020a170903228500b001a63737750dmr2647635plh.17.1682012569675; Thu, 20 Apr 2023 10:42:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682012569; cv=none; d=google.com; s=arc-20160816; b=a/vj5OrGSYeWXRsTdhCYThWy63CJDlDJCohZqFNsoSbofVQSGnha8ZxJrdvBs8D6uw OBDkNxC38f2h4Nrw5hhKBkAM2QcupzutJnPbbQRneO12HuqoiYzg2dnlm1jc+8/yRTHE 03JdjK/EwcUEf5GV+ioKjbBUb/kyEUkp2sAzkkgMYFODufMx+5yVS+HoIViE5tO7wNSS zQBFJRHp0K4Y5naW65qfdGCd2hBkmIvxP0nVpcFjA2+T7TYZh4vdKSXmqZ3WC1EPn8Rk +3K2nGTNm4ErSi4kXdZHJ5eSQJ4oA7tjiIx7JzWourCiiYjPycx1KZ+SYtUwMCItsbl3 MYZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=jOShlAmW5KtWyt18VPabl3AojpTzB/52zpa39oAofYI=; b=zJZGM0+U8vr7qCUpfSaoRTEDVgsQHTWiBBeabA2PUU0ASvqP+oDF4voQ6csH166oxC ioV7XqLIjDyiNFwEJWoUDgq1/xoVKFmYHB4uTTI418G+Eyhh5Uvy5K+yLnjF3NTy+K3/ 9yjjFAiSru7sF9lrVXotZsWbHRi63YdYkQJ5yGxwKLlRug0LezU6yHDFaFRMz727dWjo kh1fZM/JP0VRjBYXPjOce4kDS5Vabi74jnbPqtjSpEXHMiJOe1IOG/CpuVDAn90+mHrf anqB13BIkie5mBJBJzcTI2pa+Mw5Na6oDdqEt+w37fiIQsgd3PsPkZvzCrlgSgPPagAr XKaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=YmddgtRt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ix5-20020a170902f80500b001a64541624asi2135537plb.484.2023.04.20.10.42.38; Thu, 20 Apr 2023 10:42:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=YmddgtRt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231646AbjDTRmR (ORCPT + 99 others); Thu, 20 Apr 2023 13:42:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231648AbjDTRmN (ORCPT ); Thu, 20 Apr 2023 13:42:13 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6203170C for ; Thu, 20 Apr 2023 10:42:10 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-94eff00bcdaso97967466b.1 for ; Thu, 20 Apr 2023 10:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682012529; x=1684604529; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jOShlAmW5KtWyt18VPabl3AojpTzB/52zpa39oAofYI=; b=YmddgtRtW8ICTes0+dab7w6Oem6Kx16VyROeBvQ/nYxGBP5/ZMHSlacbBwi0Ijvq0Z HBwAMMZMA69v0M6/JecoGitZ1Z+oEhnr95tNJhaUhyTkNIF355Sm7sagw0sExkPzRaWQ YaW0R2WKdh8uu6dv0MaNqSyH0IBqw4UGq2EDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682012529; x=1684604529; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jOShlAmW5KtWyt18VPabl3AojpTzB/52zpa39oAofYI=; b=Y87AAKjaaet6jqnG5huW6P5OvETVRMrNT+1QRzCYxJmEiIVXGd/WnlesWq6gdx+OsC LGl7T8xYPoVqTFS81+UQ+G0JQhkEVt79TUH0GHRrw/w+c1VO06JOrBbPQqH7LV38f5se VGGDnGwW8f+fdmFg/HoWs+Vrp2zPAgD7y1LfW9UnO8odMHGCBd5SUD3EbfcpVMS9CU8L Hsz4HxokISWpX334/BL6H1IgRWqYfuV7kise2p11+kYFi8jhcBI/wgMBNTOjzN3SKTaZ GDkNa/EZeS+qTrYjuvb72Xice6taK961Bj4wl1KiptrQnTnV9AlHgHFBbxqDc7LvDEw9 cKpQ== X-Gm-Message-State: AAQBX9fTeLn5dnzZ4M3WvxhBND1tyV5gkxLvoKJUSdUiw7V++ofocxnK ypuzLqdvU5jbDs5G8Ky5SuI8US6OEE2oS0+UAqiaqQ== X-Received: by 2002:a05:6402:7d8:b0:502:2265:8428 with SMTP id u24-20020a05640207d800b0050222658428mr2195635edy.38.1682012529194; Thu, 20 Apr 2023 10:42:09 -0700 (PDT) MIME-Version: 1.0 References: <20230414000219.92640-1-sarthakkukreti@chromium.org> <20230418221207.244685-1-sarthakkukreti@chromium.org> <20230418221207.244685-2-sarthakkukreti@chromium.org> In-Reply-To: From: Sarthak Kukreti Date: Thu, 20 Apr 2023 10:41:57 -0700 Message-ID: Subject: Re: [PATCH v4 1/4] block: Introduce provisioning primitives To: Bart Van Assche Cc: dm-devel@redhat.com, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , "Michael S. Tsirkin" , Jason Wang , Stefan Hajnoczi , Alasdair Kergon , Mike Snitzer , Christoph Hellwig , Brian Foster , "Theodore Ts'o" , Andreas Dilger , Bart Van Assche , Daniil Lunev , "Darrick J. Wong" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dropped in v5. Thanks! Sarthak On Tue, Apr 18, 2023 at 3:43=E2=80=AFPM Bart Van Assche wrote: > > On 4/18/23 15:12, Sarthak Kukreti wrote: > > /* Fail if we don't recognize the flags. */ > > - if (mode & ~BLKDEV_FALLOC_FL_SUPPORTED) > > + if (mode !=3D 0 && mode & ~BLKDEV_FALLOC_FL_SUPPORTED) > > return -EOPNOTSUPP; > > Is this change necessary? Doesn't (mode & ~BLKDEV_FALLOC_FL_SUPPORTED) > !=3D 0 imply that mode !=3D 0? > > Thanks, > > Bart. >