Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1300840rwr; Thu, 20 Apr 2023 12:54:37 -0700 (PDT) X-Google-Smtp-Source: AKy350bwANCZs2v0iV8fTpZCOs/XfLX9Z8mf7y8cEucCn/WjUCpno5hr10w9uhYoS16l68yJ9KLt X-Received: by 2002:a05:6a20:d399:b0:ef:563e:ac1a with SMTP id iq25-20020a056a20d39900b000ef563eac1amr2975757pzb.47.1682020477485; Thu, 20 Apr 2023 12:54:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682020477; cv=none; d=google.com; s=arc-20160816; b=eiEUFTPlveuUy9CB+Eh4TdMOP8Zu+Co/ftWDyN9ofEk3g7s3cBfDXvQXhFFEQ1frIX EJhVigngChCuu/W+q91q85GpW0EOytLzaX1LG/qyNgm6tTM53UBZ/GN5ci4BeZR2zfgt Hw9kaRJg8Ig3NTXhIH++jdpWCwBhbEuzkr/s/N5TOwCKcB0crvbMmpNPLbO3mHR25CI4 DKJhg59GCfeQEJNNhqDNzR8mRJKFUwlFYzllESo+l8qo5k5BCVQa8RY77YywlKt0pZh/ 51W0JwFOEu+gkkKl8SXPY23bXyDf/jbT/GeEnDbnGCWbrGMG7zMft1Gp7R6aCNpeDIuO Km/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:sender:dkim-signature; bh=9hSMRCReTvqtVhzznHuB7A9Sa7YpxOxqbCtc68BgIgE=; b=cZ9R5XE2aDCgL/CXBCKx0zh6Zq+DxWRA/9YkEU1REBZa3PS3mnpZ+JLvPHlo83MqG1 7ye9JqvXmS3ta4C+dQLdHdsJW4O7o7Epud10K5NDFOebTjfINRi/IXwfPUyOyJ6bMQ6L JX8CXF1tG3NVG+BczRhLperp0u+cG0EuUgZO7pgQySv6+i0/hjo9s3mv1x3MG6JIFkQM eeY2IeHadI12Gh01fdAbd08ChA22o2MrTPYwBw8ccMaYEdCeshRHXk7Jf+3tFqUubysY qt2x52FbTUgl2APCiCSTGb2Pye+ip1P5XcZ07l8RqsJvLVgmEBY4YxNrtEFMSc4sM5d+ 8Xzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=GoIwaWRN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o38-20020a634e66000000b0051b65f4d94asi2212120pgl.484.2023.04.20.12.54.24; Thu, 20 Apr 2023 12:54:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=GoIwaWRN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232130AbjDTTtG (ORCPT + 99 others); Thu, 20 Apr 2023 15:49:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232054AbjDTTs4 (ORCPT ); Thu, 20 Apr 2023 15:48:56 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 713DF4EEB; Thu, 20 Apr 2023 12:48:48 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-51efefe7814so1396394a12.3; Thu, 20 Apr 2023 12:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682020128; x=1684612128; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=9hSMRCReTvqtVhzznHuB7A9Sa7YpxOxqbCtc68BgIgE=; b=GoIwaWRNZp8R808HTRD2raT1Cv8BRnqejXttPEHtds1fb9h/AhpUl9OJJDZbZmKXs5 ej/EgFXvWbW4w9LKCGU126TWEXFo2+e2QBkYSEiIkVYLkKp1Yq2F3zfrwPr0jqd9Gxuf nQBlNGqMhkaoKeGxlQQKNtnQKu8VM9dMoPNkjoNtq2Vl5kaG9YwMIhgPxXoCy36D5FRc kTUIUtcABjFyfsXA5LyCQQ3tIc/llbcBmRnzOByhC5xDRPIRsz2ZEK0WecgOzzFd/OBx kDyCdn5VDNCWI38ITAGu4oI1U/W4LwSmXRJIn63S/wewHbLIYoRGeaHxay6aEJrk9U+e dTKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682020128; x=1684612128; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9hSMRCReTvqtVhzznHuB7A9Sa7YpxOxqbCtc68BgIgE=; b=HV53kQQA8qYOs9FrtBbIgudYmaQ0OzjB1q2AB2TRXo1F++WxVRLNXQ7HxPSDbAoByu M+XVt1gC4AJcT/7Dzwrfoad4K6DswpcKuNw6bwYLIe1clzvThZBMaSn6mTYdkxvuOESy NVAbkm7gEkUN0lBFZlIWtC0r+Rbew8dgPQjsLtKHswl5DMhzwZf5RFxd5ZBT9QEjg6Mc EzvEjlmsHWmsr7AqbZlEYsIF0SvEYCOhRki8b/pyB3GQuhRPpvm805flhB/E10bok/nq OuGbd9QtKHsnCmBJK7GiWNA3aoh31kgyUuuL0SabrRVIl4NwD83eKQvi812wHVBHELto ZEGA== X-Gm-Message-State: AAQBX9c8Nu2fD+ajR06/VI3t3izdmrJlhjSwNT4Cxf+c5drPDIlspA+U z5OuVS+FnEr6djs5O389Ac8= X-Received: by 2002:a17:90a:c24a:b0:23d:35d9:d065 with SMTP id d10-20020a17090ac24a00b0023d35d9d065mr2219608pjx.48.1682020127742; Thu, 20 Apr 2023 12:48:47 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id j12-20020a170902c3cc00b001a04d27ee92sm1474391plj.241.2023.04.20.12.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 12:48:47 -0700 (PDT) Sender: Tejun Heo Date: Thu, 20 Apr 2023 09:48:46 -1000 From: Tejun Heo To: Shakeel Butt Cc: Yosry Ahmed , Alexander Viro , Christian Brauner , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH mm-unstable RFC 5/5] cgroup: remove cgroup_rstat_flush_atomic() Message-ID: References: <20230403220337.443510-1-yosryahmed@google.com> <20230403220337.443510-6-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 20, 2023 at 12:40:24PM -0700, Shakeel Butt wrote: > +Tejun > > > On Mon, Apr 3, 2023 at 3:03 PM Yosry Ahmed wrote: > > > > Previous patches removed the only caller of cgroup_rstat_flush_atomic(). > > Remove the function and simplify the code. > > > I would say let cgroup maintainers decide this and this patch can be > decoupled from the series. Looks fine to me but yeah please cc me on the whole series from the next round. Thanks. -- tejun