Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Apr 2023 22:02:47 +0200
From:   Andrea Righi <andrea.righi@canonical.com>
To:     Tejun Heo <tj@kernel.org>
Cc:     torvalds@linux-foundation.org, mingo@redhat.com,
        peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org,
        joshdon@google.com, brho@google.com, pjt@google.com,
        derkling@google.com, haoluo@google.com, dvernet@meta.com,
        dschatzberg@meta.com, dskarlat@cs.cmu.edu, riel@surriel.com,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        kernel-team@meta.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 24/32] sched_ext: Add cgroup support
Message-ID: <ZEGaZ+lQL7pHpmY5@righiandr-XPS-13-7390>
References: <20230317213333.2174969-1-tj@kernel.org>
 <20230317213333.2174969-25-tj@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230317213333.2174969-25-tj@kernel.org>
Precedence: bulk

On Fri, Mar 17, 2023 at 11:33:25AM -1000, Tejun Heo wrote:
...
> +/**
> + * scx_bpf_task_cgroup - Return the sched cgroup of a task
> + * @p: task of interest
> + *
> + * @p->sched_task_group->css.cgroup represents the cgroup @p is associated with
> + * from the scheduler's POV. SCX operations should use this function to
> + * determine @p's current cgroup as, unlike following @p->cgroups,
> + * @p->sched_task_group is protected by @p's rq lock and thus atomic w.r.t. all
> + * rq-locked operations. Can be called on the parameter tasks of rq-locked
> + * operations. The restriction guarantees that @p's rq is locked by the caller.
> + */
> +struct cgroup *scx_bpf_task_cgroup(struct task_struct *p)
> +{
> +	struct task_group *tg = p->sched_task_group;
> +	struct cgroup *cgrp = &cgrp_dfl_root.cgrp;
> +
> +	if (!scx_kf_allowed_on_arg_tasks(__SCX_KF_RQ_LOCKED, p))
> +		goto out;
> +
> +	/*
> +	 * A task_group may either be a cgroup or an autogroup. In the latter
> +	 * case, @tg->css.cgroup is %NULL. A task_group can't become the other
> +	 * kind once created.
> +	 */
> +	if (tg && tg->css.cgroup)
> +		cgrp = tg->css.cgroup;
> +	else
> +		cgrp = &cgrp_dfl_root.cgrp;
> +out:
> +	cgroup_get(cgrp);
> +	return cgrp;
> +}

^ #ifdef CONFIG_CGROUP_SCHED, otherwise we may get build errors, like:

kernel/sched/ext.c:4251:34: error: 'struct task_struct' has no member named 'sched_task_group'

> +
>  BTF_SET8_START(scx_kfunc_ids_any)
>  BTF_ID_FLAGS(func, scx_bpf_kick_cpu)
>  BTF_ID_FLAGS(func, scx_bpf_dsq_nr_queued)
> @@ -3431,6 +3803,7 @@ BTF_ID_FLAGS(func, scx_bpf_error_bstr, KF_TRUSTED_ARGS)
>  BTF_ID_FLAGS(func, scx_bpf_destroy_dsq)
>  BTF_ID_FLAGS(func, scx_bpf_task_running, KF_RCU)
>  BTF_ID_FLAGS(func, scx_bpf_task_cpu, KF_RCU)
> +BTF_ID_FLAGS(func, scx_bpf_task_cgroup, KF_RCU | KF_ACQUIRE)

Ditto.

-Andrea