Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Apr 2023 21:45:45 +0100
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Haifeng Xu <haifeng.xu@shopee.com>
Cc:     mszeredi@redhat.com, bigeasy@linutronix.de, mcgrof@kernel.org,
        xiubli@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] vfs: clean up d_backing_inode() function
Message-ID: <20230420204545.GN3390869@ZenIV>
References: <CAOssrKfCiByavRNekRUOCv==AEvWAO6B6=tAASyYdvWj9XRhBw@mail.gmail.com>
 <20230419104704.243950-1-haifeng.xu@shopee.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230419104704.243950-1-haifeng.xu@shopee.com>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk

On Wed, Apr 19, 2023 at 10:47:04AM +0000, Haifeng Xu wrote:
> d_backing_inode() does the same thing with d_inode(), so using
> d_inode() to get the inode of dentry instead of d_backing_inode().
> 
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> Suggested-by: Miklos Szeredi <mszeredi@redhat.com>

Fine by me, but generally that kind of search-and-replace is
better done differently:

1) patch replacing the definition of d_backing_inode() with
#define d_backing_inode d_inode

2) mail to Linus, asking to do mechanical search-and-replace
just prior to -rc1; see e.g. 7c0f6ba682b9 for example of
that being done.  In this case the script would be
sed -i -e "s/\<d_backing_inode\>/d_inode/g" $(git grep -l -w "d_backing_inode")
sed -i -e "/#define d_inode d_inode/d" include/linux/dentry.h