Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1463489rwr; Thu, 20 Apr 2023 15:50:21 -0700 (PDT) X-Google-Smtp-Source: AKy350ZVIBegpW+BGU1ps6db+0hk2BDJpf/hCmy2SwZvR9rnDhRMnVefsSPOWrR5DgH7X0Hk2o+w X-Received: by 2002:a05:6a20:914e:b0:ef:a7aa:6118 with SMTP id x14-20020a056a20914e00b000efa7aa6118mr4182488pzc.43.1682031021309; Thu, 20 Apr 2023 15:50:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682031021; cv=none; d=google.com; s=arc-20160816; b=OuYvyfCRTeMLqO+/+4eXcBjTEPP2z7DiP4M6pbr4WAxv+rTLnW+r+dsKUJHw9usdif zYG7h5yR7/ND7iNnlGvUimoZCxusrEJpnHGrq2TLTz0SaEIFRQcXYLOnbvK4uF4kZmSM p+aGxKc2VJnq0xyDH0lnXKGmPSXxZudZzKb78yfQfF4E4uw8LNfLzfQFHofy+XFtST9N f6TmjNv5YCAzl0nqKYLCl95kFi3HzLmmXq9zs+zrsm+5Sjlwainb+Lw/fG5P7zyFGFr4 A0tRziPUIpD/SJCijCFkzLMdc9p6SRa/cRd5ZsNksVfnGIIsyRHlQm4nW8aEAvNcTNeW iwpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=IjH8cEEb4Pdaq+7y2hXqBIVsGh4DsrKvkp8dCInMI9s=; b=dmS/VN/uvZOYo4qqTlTccQmTeNKW5JxFMLDk76o02wHfP26W/Uo4ZY0xPGdaVhLGYm +5Fi7VYHSAs0EoPnx7be+/8ZvxYF9A9FpXw7J6tq3glbSJH3Aa8LQrAH6a//c1OOeP15 63iqf73x6dYV1c3PQOAgSvRW1XLoZwObQHo9miqPMDncFs6o8u6ygyMDwcMSegdYprqF ykhuqnh7o6p5Px66gE0LipT99Ajkp//+tgSeVsPhGiyxkZl7TU0g/umKkWkIpj+BqvM5 Mgh+vvPwwqwjE4kFW2bUALYDpt1xe+/qGdDbKhVpgeS/B8aaLsoJfefDRaJNxnt09R+q xpwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=UtAWwKWD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u18-20020a63f652000000b00518fc071a25si2758664pgj.391.2023.04.20.15.50.07; Thu, 20 Apr 2023 15:50:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=UtAWwKWD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232830AbjDTWhQ (ORCPT + 99 others); Thu, 20 Apr 2023 18:37:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229736AbjDTWhO (ORCPT ); Thu, 20 Apr 2023 18:37:14 -0400 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D8A1E5E; Thu, 20 Apr 2023 15:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IjH8cEEb4Pdaq+7y2hXqBIVsGh4DsrKvkp8dCInMI9s=; b=UtAWwKWDyPwNKRQjh0mJk8KLwu z7QZ0MyjHoQxBAJlCJk6n/arszZ/jTfN1kVnlyn2tdXQogoqENYh5Ra+B4MJ03q1ZAtXMZkC71FbN xjO7kzrxT+RaqjXTwlw4wb478rm9BxBGUE77KbyOzH0Ae0t0xey94s8c9oj8dO+WQ1/Iyvj57oSgf L1zRVWcWxnRLkNZeBOJlMfuyZEaLmMdbRpUiVrMrv2vxX2mPaqcUXZRaAmzJngz5FmE+BELi2ongi rdArNeY8oylbrtGpYZLm/cFRlrv/KKSSOm4TyRtzBJ+RrEsgiju/CudreBNiOpXSow5Mw6W9xLlgn OhyGsuvw==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1ppctd-00Az06-1Y; Thu, 20 Apr 2023 22:36:57 +0000 Date: Thu, 20 Apr 2023 23:36:57 +0100 From: Al Viro To: David Howells Cc: Jens Axboe , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v18 09/15] iov_iter: Kill ITER_PIPE Message-ID: <20230420223657.GV3390869@ZenIV> References: <20230314220757.3827941-1-dhowells@redhat.com> <20230314220757.3827941-10-dhowells@redhat.com> <20230420222231.GT3390869@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230420222231.GT3390869@ZenIV> Sender: Al Viro X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 20, 2023 at 11:22:31PM +0100, Al Viro wrote: > On Tue, Mar 14, 2023 at 10:07:51PM +0000, David Howells wrote: > > The ITER_PIPE-type iterator was only used for generic_file_splice_read(), > > but that has now been switched to either pull pages directly from the > > pagecache for buffered file splice-reads or to use ITER_BVEC instead for > > O_DIRECT file splice-reads. This leaves ITER_PIPE unused - so remove it. > > Wonderful, except that now you've got duplicates of ->read_iter() for > everyone who wants zero-copy on ->splice_read() ;-/ > > I understand the attraction of arbitrary seeks on those suckers; ITER_PIPE > is a massive headache in that respect. But I really don't like what your > approach trades it for. > > And you are nowhere near done - consider e.g. NFS. Mainline has it > feed ITER_PIPE to nfs_file_read(), which does call generic_file_read_iter() - > after > result = nfs_revalidate_mapping(inode, iocb->ki_filp->f_mapping); > > Sure, you can add nfs_file_splice_read() that would do what nfs_file_read() > does, calling filemap_spice_read() instead of generic_file_read_iter(). > > Repeat the same for ocfs2 (locking of its own). And orangefs. And > XFS (locking, again). And your own AFS, while we are at it. Et sodding > cetera - *everything* that uses generic_file_splice_read() with > ->read_iter other than generic_file_read_iter() needs review and, > quite likely, a ->splice_read() instance of its own. Don't get me wrong - I'd love to kill ITER_PIPE off; it's just that tons of ->splice_read() duplicating the corresponding ->read_iter() up to the point where it would call generic_file_read_iter(), modulo ignoring O_DIRECT case and then calling filemap_splice_read() instead... Painful and asking for trouble down the road.