Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] ext4: Fix unused iterator variable warnings
To:     Nathan Chancellor <nathan@kernel.org>, <tytso@mit.edu>,
        <adilger.kernel@dilger.ca>
CC:     <linux-ext4@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230420-ext4-unused-variables-super-c-v1-1-138b6db6c21c@kernel.org>
From:   Jason Yan <yanaijie@huawei.com>
Message-ID: <d889cae1-8b16-3a2b-49b5-0f649e59f339@huawei.com>
Date:   Fri, 21 Apr 2023 09:52:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20230420-ext4-unused-variables-super-c-v1-1-138b6db6c21c@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/4/21 0:51, Nathan Chancellor wrote:
> When CONFIG_QUOTA is disabled, there are warnings around unused iterator
> variables:
> 
>    fs/ext4/super.c: In function 'ext4_put_super':
>    fs/ext4/super.c:1262:13: error: unused variable 'i' [-Werror=unused-variable]
>     1262 |         int i, err;
>          |             ^
>    fs/ext4/super.c: In function '__ext4_fill_super':
>    fs/ext4/super.c:5200:22: error: unused variable 'i' [-Werror=unused-variable]
>     5200 |         unsigned int i;
>          |                      ^
>    cc1: all warnings being treated as errors
> 
> The kernel has updated to gnu11, allowing the variables to be declared
> within the for loop. Do so to clear up the warnings.
> 
> Fixes: dcbf87589d90 ("ext4: factor out ext4_flex_groups_free()")
> Signed-off-by: Nathan Chancellor<nathan@kernel.org>
> ---
>   fs/ext4/super.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)

Thanks for the fix:

Reviewed-by: Jason Yan <yanaijie@huawei.com>