Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ryan Chen <ryan_chen@aspeedtech.com>
To:     Andi Shyti <andi.shyti@kernel.org>
CC:     "jk@codeconstruct.com.au" <jk@codeconstruct.com.au>,
        Brendan Higgins <brendan.higgins@linux.dev>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Joel Stanley <joel@jms.id.au>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Jeffery <andrew@aj.id.au>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Wolfram Sang <wsa@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jean Delvare <jdelvare@suse.de>,
        William Zhang <william.zhang@broadcom.com>,
        Tyrone Ting <kfting@nuvoton.com>,
        Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
        Conor Dooley <conor.dooley@microchip.com>,
        Phil Edworthy <phil.edworthy@renesas.com>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v10 2/2] i2c: aspeed: support ast2600 i2c new register
 mode driver
Thread-Topic: [PATCH v10 2/2] i2c: aspeed: support ast2600 i2c new register
 mode driver
Thread-Index: AQHZbzmqrA2zXnqjgUeJpYzEt+Ip7a8064OAgAANtPA=
Date:   Fri, 21 Apr 2023 02:01:28 +0000
Message-ID: <SEZPR06MB526997FBE2B216AD82986E0EF2609@SEZPR06MB5269.apcprd06.prod.outlook.com>
References: <20230415012848.1777768-1-ryan_chen@aspeedtech.com>
 <20230415012848.1777768-3-ryan_chen@aspeedtech.com>
 <20230421000529.6awtnawqgbk5orcp@intel.intel>
In-Reply-To: <20230421000529.6awtnawqgbk5orcp@intel.intel>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wPUTFMXcdCN8pZBe19nKxeIAJfvmcNgTZv1NpGGghRmhDl4AirJGf20yUjBw?=
 =?us-ascii?Q?ZbxZ87MNbAFnBEjwOIvhfP/6v69GRvol6QSANbw4DnlBQknWTopI7livhYe9?=
 =?us-ascii?Q?NMmX41dfl1qlcJXfvFUAmo5cRc3WSpNDjt0RolSRLF1bclxToedNuggSSqgC?=
 =?us-ascii?Q?yc6EhqqV3A62MEHWOaLqBhmvZsaFtGBfuidJX3Pue53beLenG1mMjVBAMngG?=
 =?us-ascii?Q?ve4HjgCqIN979NkgQZmzf5O0CkBdUeqqLb+QRXBwRup6mxLz/cKQ3iPLr/3D?=
 =?us-ascii?Q?zNsJmcoMp8ZJed2uVVUVhC2nVZMubpQ4OvLa/Kc3h2vjnJ8j4+Nfsn1GIQul?=
 =?us-ascii?Q?3Ikcme4RL/H/ttHm2ENtOtN0E7d762KWLhUrdUPmNDvlPOIbz03FjIstUJcD?=
 =?us-ascii?Q?dkoyNoo7lZ+Jy4/ly/VVyW4Hd3R5c4DgDOJ93USWgVpHXrCEKuX4ODwq1uhS?=
 =?us-ascii?Q?KXV8t4kuKQPmCwBibp0Fdq4xqesJ9x/jvaB+1grv82bBaaLsKoYpfVbAYSw1?=
 =?us-ascii?Q?7BKZKgtMGzYdEmPav2KUszbsc5Mp+xOmUA+17qNj3cgqztmQEGSPhFRVUbh7?=
 =?us-ascii?Q?71wn9qrc3FVLDv6m7ZXsHP8KiyAk9YrB4+V5wjMLiA4MxFy0zzuNK7OTsHzr?=
 =?us-ascii?Q?xhTcv0GTS81JGVm7MrVqbmnOsCT4Lc5FLGkRB9U9v3WX59HI0161t/W+W3mj?=
 =?us-ascii?Q?bn2Xstl2MgFWuMSbbGr4EhBfdaYTo2rVcOm3Heqc3ce+CrttVKNTCuX7krfG?=
 =?us-ascii?Q?cd/Lkl+mmcHfTva4sQo6FBdmNNknw1BrFVae19PAXZ7IaZfNMjeJF6Qu444x?=
 =?us-ascii?Q?L9RQrQ18tgrssRK46p3LPwRTElTDebFn/H4rNC2iQbdsYmZGNKYWP/nZwOmw?=
 =?us-ascii?Q?01y7JfjdkSg1/qu0rOSRrYyye9dGZ+/pyPzzyJKWWIltaSSmML9mCFVkRsa5?=
 =?us-ascii?Q?hZJ/AJ+tFRk29SaAKACLrXRz6mOvrxCL7kLj6DxM653C+51UJnx3gpHijP5j?=
 =?us-ascii?Q?h0oG37cO1gGg/XLivSLrQwv2OmdyMkS9WNgfW90RSA0bd/PJ8rnIII7I0C9Y?=
 =?us-ascii?Q?m+6X8isaaS5o/0GyUepz/LO/MS11gzpoquN1DGANPh1fGFzHxw5qxc9stHQh?=
 =?us-ascii?Q?MBzGrU8BY2suycr01ltHQeR3vSUqQHTHYexTC7DnqBnwO/8XgKV0mPDPm7vf?=
 =?us-ascii?Q?4dX+aEOUS4eSB7OxkCVVTZwRFQFgvGsuA4qsK2RoS6qrOHb6CPYbrVMvhkmN?=
 =?us-ascii?Q?V6j2rKMmdi4wpiFJMYgzXGf6av6fSQbhkpJU9t5bGIPhpGgGn4NgzySJh7RN?=
 =?us-ascii?Q?FgpqXzuaIOY77BZOYK+tkptFsyNkQiuWeeCuNuI0JZ+zjuzrGc4ewMpR/T4O?=
 =?us-ascii?Q?JDA1k+gtgkj37kfyOG6cj2lVBT2ku9Vyf52DGiKAVf90qf1UzYFj3QE7glMJ?=
 =?us-ascii?Q?42iRrJKieKV2IOLGNOj1wamdRkurwQdGY1Nl5Ca/K5vFtK90ivF2hybQ2O0/?=
 =?us-ascii?Q?rF4bHcaDA3QbRlY8zHpbekbRVjfJ907jFbr0VLN5gIhPq/9Vl4AntilJvhTd?=
 =?us-ascii?Q?dVO8W3Gbos9LE4m04/tJOpenxKxH+/9cuxkU4/mR?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8c5478a-6402-470e-1249-08db420c51d2
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2023 02:01:28.2655
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fhVhAVzVexs17+Kg2PoX44SFjr2EtQ1DVKbDGEaRVNwjHtkQIN1bKbiTfhWqg6me0NInPq+OezCpYiPKzl36dvlRHJ9z0rkCF6So3OtJiY8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5632
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Andi,
>=20
> On Sat, Apr 15, 2023 at 09:28:48AM +0800, Ryan Chen wrote:
> > Add i2c new register mode driver to support AST2600 i2c new register
> > mode. AST2600 i2c controller have legacy and new register mode. The
> > new register mode have global register support 4 base clock for scl
> > clock selection, and new clock divider mode. The i2c new register mode
> > have separate register set to control i2c master and slave.
>=20
> This commit message is a bit messy, could you please write it more clear?
>=20
> [...]
>=20
The more statement is in cover letter.
https://patchwork.ozlabs.org/project/linux-aspeed/cover/20230415012848.1777=
768-1-ryan_chen@aspeedtech.com/


> > +static int ast2600_i2c_probe(struct platform_device *pdev) {
> > +	struct device_node *np =3D pdev->dev.of_node;
> > +	struct device *dev =3D &pdev->dev;
> > +	struct ast2600_i2c_bus *i2c_bus;
> > +	struct resource *res;
> > +	u32 global_ctrl;
> > +	int ret =3D 0;
> > +
> > +	i2c_bus =3D devm_kzalloc(dev, sizeof(*i2c_bus), GFP_KERNEL);
> > +	if (!i2c_bus)
> > +		return -ENOMEM;
>=20
> Let's use dev_err_probe whenever possible, at least we keep a coherent st=
yle.

Will modify dev_err_probe to next patch
>=20
> [...]
>=20
> > +	ret =3D devm_request_irq(dev, i2c_bus->irq, ast2600_i2c_bus_irq, 0,
> > +			       dev_name(dev), i2c_bus);
>=20
> isn't it better to use threaded irq? You have quite an elaborate irq hand=
ler, you
> may want to use a thread for it.

Thanks, but I would prefer to stick currently implement of the IRQ request.=
 Thank you for your input.

>=20
> > +	if (ret < 0)
> > +		return dev_err_probe(dev, ret, "Unable to request irq %d\n",
> > +i2c_bus->irq);
> > +
> > +	if (of_property_read_bool(dev->of_node, "smbus-alert")) {
> > +		i2c_bus->alert_enable =3D 1;
>=20
> true;

>=20
> alert_enable is boolean, make it bool.

Will modify dev_err_probe to next patch

>=20
> > +		i2c_bus->ara =3D i2c_new_smbus_alert_device(&i2c_bus->adap,
> &i2c_bus->alert_data);
> > +		if (!i2c_bus->ara)
> > +			dev_warn(dev, "Failed to register ARA client\n");
> > +
> > +		writel(AST2600_I2CM_PKT_DONE | AST2600_I2CM_BUS_RECOVER |
> AST2600_I2CM_SMBUS_ALT,
> > +		       i2c_bus->reg_base + AST2600_I2CM_IER);
> > +	} else {
> > +		i2c_bus->alert_enable =3D 0;
>=20
> false;

Will modify dev_err_probe to next patch

>=20
> I'm not going to review any further, please send the patch after you have=
 run
> checkpatch.pl on it. Thanks!

Sure.=20

Thanks, your review.
Ryan Chen.