Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <375a82ab-7628-4895-fcda-ad19e5958d4b@zhaoxin.com>
Date:   Fri, 21 Apr 2023 18:51:26 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 2/3] xhci: Add zhaoxin xHCI U1/U2 feature support
Content-Language: en-US
To:     Sergei Shtylyov <sergei.shtylyov@gmail.com>,
        <gregkh@linuxfoundation.org>, <mathias.nyman@intel.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     <tonywwang@zhaoxin.com>, <weitaowang@zhaoxin.com>
References: <20230420172130.375819-1-WeitaoWang-oc@zhaoxin.com>
 <20230420172130.375819-3-WeitaoWang-oc@zhaoxin.com>
 <c853436a-85c7-d0f8-0990-bc64977cbd47@gmail.com>
 <f0f0d62d-edde-547d-5d6e-a02e2f8e8648@zhaoxin.com>
 <54aa1618-63b7-965a-d303-5d35cb554c20@gmail.com>
From:   "WeitaoWang-oc@zhaoxin.com" <WeitaoWang-oc@zhaoxin.com>
In-Reply-To: <54aa1618-63b7-965a-d303-5d35cb554c20@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2023/4/20 22:22, Sergei Shtylyov wrote:
> On 4/20/23 11:21 PM, WeitaoWang-oc@zhaoxin.com wrote:
> 
>>>> Add U1/U2 feature support of xHCI for zhaoxin.
>>>>
>>>> Signed-off-by: Weitao Wang <WeitaoWang-oc@zhaoxin.com>
>>> [...]
>>>
>>>> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
>>>> index 6307bae9cddf..730c0f68518d 100644
>>>> --- a/drivers/usb/host/xhci.c
>>>> +++ b/drivers/usb/host/xhci.c
>>> [...]
>>>> @@ -4938,6 +4938,27 @@ static int xhci_update_timeout_for_interface(struct xhci_hcd *xhci,
>>>>        return 0;
>>>>    }
>>>>    +static int xhci_check_zhaoxin_tier_policy(struct usb_device *udev,
>>>> +        enum usb3_link_state state)
>>>> +{
>>>> +    struct usb_device *parent;
>>>> +    unsigned int num_hubs;
>>>> +
>>>> +    /* Don't enable U1/U2 if the device is on an external hub. */
>>>> +    for (parent = udev->parent, num_hubs = 0; parent->parent;
>>>> +            parent = parent->parent)
>>>> +        num_hubs++;
>>>> +
>>>> +    if (num_hubs < 1)
>>>> +        return 0;
>>>> +
>>>> +    dev_dbg(&udev->dev, "Disabling U1/U2 link state for device"
>>>> +            " below external hub.\n");
>>>> +    dev_dbg(&udev->dev, "Plug device into root hub "
>>>> +            "to decrease power consumption.\n");
>>>
>>>      Please don't break up the message strings.
>>
>> Thanks for your advice, and I will merge this message in next patch version.
>>> [...]
>>>> @@ -4965,6 +4986,8 @@ static int xhci_check_tier_policy(struct xhci_hcd *xhci,
>>>>    {
>>>>        if (xhci->quirks & XHCI_INTEL_HOST)
>>>>            return xhci_check_intel_tier_policy(udev, state);
>>>> +    else if (xhci->quirks & XHCI_ZHAOXIN_HOST)
>>>
>>>      *else* not needed after *return*.
>> This function need a "int" type return value. If remove "else" branch,
>> vendor other than intel and zhaoxin will not get a return value.
> 
>     I didn't tell you to remove the whole branch, just the *else* keyword.

I understand what you mean this time. Here's code needs more concise.
I'll try to do more think and test.Thanks again!

weitao
> [...]
>> Best Regards,
>> Weitao
> 
> MBR, Sergey
> .