Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 04:34:56 +0100
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Haifeng Xu <haifeng.xu@shopee.com>
Cc:     mszeredi@redhat.com, bigeasy@linutronix.de, mcgrof@kernel.org,
        xiubli@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] vfs: clean up d_backing_inode() function
Message-ID: <20230421033456.GC3390869@ZenIV>
References: <CAOssrKfCiByavRNekRUOCv==AEvWAO6B6=tAASyYdvWj9XRhBw@mail.gmail.com>
 <20230419104704.243950-1-haifeng.xu@shopee.com>
 <20230420204545.GN3390869@ZenIV>
 <2b0e06e0-5dd4-8ca7-6d85-b492468fd71a@shopee.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2b0e06e0-5dd4-8ca7-6d85-b492468fd71a@shopee.com>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk

On Fri, Apr 21, 2023 at 10:50:05AM +0800, Haifeng Xu wrote:
> 
> 
> On 2023/4/21 04:45, Al Viro wrote:
> > On Wed, Apr 19, 2023 at 10:47:04AM +0000, Haifeng Xu wrote:
> >> d_backing_inode() does the same thing with d_inode(), so using
> >> d_inode() to get the inode of dentry instead of d_backing_inode().
> >>
> >> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> >> Suggested-by: Miklos Szeredi <mszeredi@redhat.com>
> > 
> > Fine by me, but generally that kind of search-and-replace is
> > better done differently:
> > 
> > 1) patch replacing the definition of d_backing_inode() with
> > #define d_backing_inode d_inode
> > 
> > 2) mail to Linus, asking to do mechanical search-and-replace
> > just prior to -rc1; see e.g. 7c0f6ba682b9 for example of
> > that being done.  In this case the script would be
> > sed -i -e "s/\<d_backing_inode\>/d_inode/g" $(git grep -l -w "d_backing_inode")
> > sed -i -e "/#define d_inode d_inode/d" include/linux/dentry.h
> 
> Thanks for your suggestion.
> 
> The file "include/linux/dentry.h" doesn't exist, do you mean "include/linux/dcache.h"?

Yes.

> By the way, why we need to add a definiton first and delete it later instead of replacing 
> the "d_backing_inode" directly?

Because it's much harder to do in a sed script ;-)  Taking out one line is
easier than doing the same to comment + definition.  Seriously, try it; it's
doable, but it's not fun to write and even less so - to read.

> In addition, there's another patch need to be reviewed.
> link: https://lore.kernel.org/all/20230419072736.172593-1-haifeng.xu@shopee.com/

No problems with that one.