Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <973e113f-e4f3-af44-a580-62e15535f542@nfschina.com>
Date:   Fri, 21 Apr 2023 13:23:11 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] firmware:Remove unnecessary (void*) conversions
Content-Language: en-US
To:     kabel@kernel.org
Cc:     llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
        linux-kernel@vger.kernel.org
From:   yunchuan <yunchuan@nfschina.com>
In-Reply-To: <202304201916.8OvkVl9W-lkp@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/4/20 19:49, kernel test robot 写道:
> Hi yunchuan,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v6.3-rc7 next-20230419]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/yunchuan/firmware-Remove-unnecessary-void-conversions/20230420-154004
> patch link:    https://lore.kernel.org/r/20230420073751.1031944-1-yunchuan%40nfschina.com
> patch subject: [PATCH] firmware:Remove unnecessary (void*) conversions
> config: hexagon-randconfig-r034-20230420 (https://download.01.org/0day-ci/archive/20230420/202304201916.8OvkVl9W-lkp@intel.com/config)
> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 437b7602e4a998220871de78afcb020b9c14a661)
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://github.com/intel-lab-lkp/linux/commit/1dee3a7afbb402fc49f0af9eeb312f221e99fab6
>          git remote add linux-review https://github.com/intel-lab-lkp/linux
>          git fetch --no-tags linux-review yunchuan/firmware-Remove-unnecessary-void-conversions/20230420-154004
>          git checkout 1dee3a7afbb402fc49f0af9eeb312f221e99fab6
>          # save the config file
>          mkdir build_dir && cp config build_dir/.config
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/firmware/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202304201916.8OvkVl9W-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>     In file included from drivers/firmware/turris-mox-rwtm.c:11:
>     In file included from include/linux/dma-mapping.h:10:
>     In file included from include/linux/scatterlist.h:9:
>     In file included from arch/hexagon/include/asm/io.h:334:
>     include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
>             val = __raw_readb(PCI_IOBASE + addr);
>                               ~~~~~~~~~~ ^
>     include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
>             val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
>                                                             ~~~~~~~~~~ ^
>     include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
>     #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
>                                                       ^
>     In file included from drivers/firmware/turris-mox-rwtm.c:11:
>     In file included from include/linux/dma-mapping.h:10:
>     In file included from include/linux/scatterlist.h:9:
>     In file included from arch/hexagon/include/asm/io.h:334:
>     include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
>             val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
>                                                             ~~~~~~~~~~ ^
>     include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
>     #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
>                                                       ^
>     In file included from drivers/firmware/turris-mox-rwtm.c:11:
>     In file included from include/linux/dma-mapping.h:10:
>     In file included from include/linux/scatterlist.h:9:
>     In file included from arch/hexagon/include/asm/io.h:334:
>     include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
>             __raw_writeb(value, PCI_IOBASE + addr);
>                                 ~~~~~~~~~~ ^
>     include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
>             __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
>                                                           ~~~~~~~~~~ ^
>     include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
>             __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
>                                                           ~~~~~~~~~~ ^
>>> drivers/firmware/turris-mox-rwtm.c:286:19: error: incompatible integer to pointer conversion initializing 'struct mox_rwtm *' with an expression of type 'unsigned long' [-Wint-conversion]
>             struct mox_rwtm *rwtm = rng->priv;
>                              ^      ~~~~~~~~~
>     6 warnings and 1 error generated.


Yes, that's an oversight, 'priv' should be unsigned long variable.I 
didn't pay attention to the structure definition in 
'include/linux/hw_random.h'.

Thanks for your quick feedbacks and sorry for being late.


>
>
> vim +286 drivers/firmware/turris-mox-rwtm.c
>
>     283	
>     284	static int mox_hwrng_read(struct hwrng *rng, void *data, size_t max, bool wait)
>     285	{
>   > 286		struct mox_rwtm *rwtm = rng->priv;
>     287		struct armada_37xx_rwtm_tx_msg msg;
>     288		int ret;
>     289	
>     290		if (max > 4096)
>     291			max = 4096;
>     292	
>     293		msg.command = MBOX_CMD_GET_RANDOM;
>     294		msg.args[0] = 1;
>     295		msg.args[1] = rwtm->buf_phys;
>     296		msg.args[2] = (max + 3) & ~3;
>     297	
>     298		if (!wait) {
>     299			if (!mutex_trylock(&rwtm->busy))
>     300				return -EBUSY;
>     301		} else {
>     302			mutex_lock(&rwtm->busy);
>     303		}
>     304	
>     305		ret = mbox_send_message(rwtm->mbox, &msg);
>     306		if (ret < 0)
>     307			goto unlock_mutex;
>     308	
>     309		ret = wait_for_completion_interruptible(&rwtm->cmd_done);
>     310		if (ret < 0)
>     311			goto unlock_mutex;
>     312	
>     313		ret = mox_get_status(MBOX_CMD_GET_RANDOM, rwtm->reply.retval);
>     314		if (ret < 0)
>     315			goto unlock_mutex;
>     316	
>     317		memcpy(data, rwtm->buf, max);
>     318		ret = max;
>     319	
>     320	unlock_mutex:
>     321		mutex_unlock(&rwtm->busy);
>     322		return ret;
>     323	}
>     324	
>