Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sunil Kovvuri Goutham <sgoutham@marvell.com>
To:     Tejun Heo <tj@kernel.org>,
        "jiangshanlai@gmail.com" <jiangshanlai@gmail.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-team@meta.com" <kernel-team@meta.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Ratheesh Kannoth <rkannoth@marvell.com>,
        Srujana Challa <schalla@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [EXT] [PATCH 07/22] net: octeontx2: Use alloc_ordered_workqueue()
 to create ordered workqueues
Thread-Topic: [EXT] [PATCH 07/22] net: octeontx2: Use
 alloc_ordered_workqueue() to create ordered workqueues
Thread-Index: AQHZc/wf5qoHZ0YhDkWGPdjOIGr5XK81RkWg
Date:   Fri, 21 Apr 2023 06:16:49 +0000
Message-ID: <BY3PR18MB47375D5899FC67F00AB11F88C6609@BY3PR18MB4737.namprd18.prod.outlook.com>
References: <20230421025046.4008499-1-tj@kernel.org>
 <20230421025046.4008499-8-tj@kernel.org>
In-Reply-To: <20230421025046.4008499-8-tj@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gcZ9hKZf6hDCVEFLuLCYqTQna+hRN65iWZ3ON5fmKMzcuecW02ZWoZffO7+z?=
 =?us-ascii?Q?Ak764t9W4HIBeDnUFSWkgRBPJZ7EvyZ7rfcW5nD1Ca1QQlOOjSy7lCNvEQWr?=
 =?us-ascii?Q?IS9dMx05XrC8t+uYU1762xcBz+s1avbCS0S5dzQGhvAHF93RWuerehznWNms?=
 =?us-ascii?Q?sRkzdDUh6hAFTOYaQbZyg8m1YBzGWRgDjlO6CWVSxmsmlT/paBBMcv5j9zaD?=
 =?us-ascii?Q?Nt1pRoiTuioxMmxxxwOXNz/6XbEr5zWGz4J74IntSrbZMLM6q1M81TOFjbwt?=
 =?us-ascii?Q?CkSvrxhBj9iwsI0V17sBMlpK6Qo92phElayCUo0UKUuNmgfMusE8N0QBlf3h?=
 =?us-ascii?Q?S7tAvimeQj27HyO6pfdR+M1S8Orjr0josYT4zUvGwIVt38c83kXobs6rabke?=
 =?us-ascii?Q?UF6YGqYKW8fF/PCo6/K75eijA0wjp63+Nq6OS1KxCBvtdrbmUr1ZA1wg42CX?=
 =?us-ascii?Q?OU+BYjN1rjxJFLdJlaRg0o3j29uIXW8+n1fkU8x3YAM5frNayhYd3Md4BJ7z?=
 =?us-ascii?Q?7wmrmEicOGsmeDHpYvqLM13Z9qUBJEImCswTJto+ktWDqCz9fftbjT1M3ieV?=
 =?us-ascii?Q?IogI8QL+90b6Vxg77+F+YRQMUvCCgW1LOuIPAtebWA3znXQaNNs1ndFah5AO?=
 =?us-ascii?Q?0VbhtEtaIstObQlKhIX7lwrFsHFSAsHEzFuhONMF+HfYnvYOSuSda9fX+UQO?=
 =?us-ascii?Q?N5phFG9XIE6STLKEg7e1a5X31tAsA0298KdKPenLef8cMjZKSRRdrEtMD5kN?=
 =?us-ascii?Q?Cu0dOiDZssKoAZKtFk7LwUCHF6SsFh7kNkeRuH65rT6tJSO7VRXuIziKHZH6?=
 =?us-ascii?Q?bSp6ahxVokqvImCvZ943HySN+rxMD6Z7cmIL220qKM3G6TaxWNM+5fOslv+b?=
 =?us-ascii?Q?PZV215ZLV5FGb0sU1HUPxzg//ACvZjcU409ZMDCJaq9dA2Wlmk3q35yzObsh?=
 =?us-ascii?Q?9KqXY2NxEqfEOObU7U81b/ZRY55zOaoplLF+G5yCWwBJxHgDwzhc5uqEfI9U?=
 =?us-ascii?Q?dArUnyOFNjUGtz/UMaasjbB0M8ePq4gJZfp/6LJk70gwZM1BuQx4yS5zuTv3?=
 =?us-ascii?Q?GcnUlU1EBwBH/mjnj+Bk6NSRsAz1YniImPVYdMmIoY6r7u8N+TvsKpjy4flR?=
 =?us-ascii?Q?nlJDGrlsNIygpzm6n76bVsMxvwtTw5AbN9B55nQm4HUHWnWqfqTTrVR4Wjtc?=
 =?us-ascii?Q?/6atlNkZGc7K6yv3uUxbOPZZNs4HTrXJSpyV+wWJGwOp6nw05hV43FIlti7b?=
 =?us-ascii?Q?9ffYrdeNDJvHH8J8IYGi1r04AFx1gZ060TN0i8wTx5xxXtdecypU2yducTNf?=
 =?us-ascii?Q?0uYeWQKjQpeP4lbmTThIb7gNLsWjnFhfk55M2ZDEED7pPUTWIEGOmARvPbRe?=
 =?us-ascii?Q?0CgNjEz6dvdi51oa1gxMgFLJRZVjlrr6/FExNAw73Wn1ZMsG2aBzV7E1EkEc?=
 =?us-ascii?Q?H5Mox19CAJjyWCbCK/hezxiqX1h0NlkCWXA11x80vhSR14NHA3Aul2cTn8gW?=
 =?us-ascii?Q?UoexB1aJau+FOIhdU+UPoc8sYbNttj8Rd5zPH5CoeN1PNpl3ttuVRaYLPy6o?=
 =?us-ascii?Q?nBFzod/0EwjsoFTrCuD64zHfT25WG5n3UyG9NZKj?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4737.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e54549c-db0f-42b8-f0f5-08db422ffdd9
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2023 06:16:49.2555
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yd1/jI2Mx7RNItfEXQFXC/GQ7Rb/3gohBLK1CBQsmFsgR7JNRUlTgtsFaVChduFiUoY3/TBp5H0BqXZRGebBpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3040
X-Proofpoint-GUID: H_ZeoBqiPJby0fcP74m-69esvinUYca1
X-Proofpoint-ORIG-GUID: H_ZeoBqiPJby0fcP74m-69esvinUYca1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-20_17,2023-04-20_01,2023-02-09_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Tejun Heo <htejun@gmail.com> On Behalf Of Tejun Heo
> Sent: Friday, April 21, 2023 8:21 AM
> To: jiangshanlai@gmail.com
> Cc: linux-kernel@vger.kernel.org; kernel-team@meta.com; Tejun Heo
> <tj@kernel.org>; David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Sunil Kovvuri Goutham <sgoutham@marvell.com>;
> Ratheesh Kannoth <rkannoth@marvell.com>; Srujana Challa
> <schalla@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>;
> netdev@vger.kernel.org
> Subject: [EXT] [PATCH 07/22] net: octeontx2: Use alloc_ordered_workqueue(=
)
> to create ordered workqueues
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> BACKGROUND
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>=20
> When multiple work items are queued to a workqueue, their execution order
> doesn't match the queueing order. They may get executed in any order and
> simultaneously. When fully serialized execution - one by one in the queue=
ing
> order - is needed, an ordered workqueue should be used which can be creat=
ed
> with alloc_ordered_workqueue().
>=20
> However, alloc_ordered_workqueue() was a later addition. Before it, an or=
dered
> workqueue could be obtained by creating an UNBOUND workqueue with
> @max_active=3D=3D1. This originally was an implementation side-effect whi=
ch was
> broken by 4c16bd327c74 ("workqueue: restore WQ_UNBOUND/max_active=3D=3D1
> to be ordered"). Because there were users that depended on the ordered
> execution,
> 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active=3D=3D1 to be
> ordered") made workqueue allocation path to implicitly promote UNBOUND
> workqueues w/
> @max_active=3D=3D1 to ordered workqueues.
>=20
> While this has worked okay, overloading the UNBOUND allocation interface =
this
> way creates other issues. It's difficult to tell whether a given workqueu=
e actually
> needs to be ordered and users that legitimately want a min concurrency le=
vel wq
> unexpectedly gets an ordered one instead. With planned UNBOUND workqueue
> updates to improve execution locality and more prevalence of chiplet desi=
gns
> which can benefit from such improvements, this isn't a state we wanna be =
in
> forever.
>=20
> This patch series audits all callsites that create an UNBOUND workqueue w=
/
> @max_active=3D=3D1 and converts them to alloc_ordered_workqueue() as
> necessary.
>=20
> WHAT TO LOOK FOR
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>=20
> The conversions are from
>=20
>   alloc_workqueue(WQ_UNBOUND | flags, 1, args..)
>=20
> to
>=20
>   alloc_ordered_workqueue(flags, args...)
>=20
> which don't cause any functional changes. If you know that fully ordered
> execution is not ncessary, please let me know. I'll drop the conversion a=
nd
> instead add a comment noting the fact to reduce confusion while conversio=
n is
> in progress.
>=20
> If you aren't fully sure, it's completely fine to let the conversion thro=
ugh. The
> behavior will stay exactly the same and we can always reconsider later.
>=20
> As there are follow-up workqueue core changes, I'd really appreciate if t=
he
> patch can be routed through the workqueue tree w/ your acks. Thanks.
>=20
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Sunil Goutham <sgoutham@marvell.com>
> Cc: Ratheesh Kannoth <rkannoth@marvell.com>
> Cc: Srujana Challa <schalla@marvell.com>
> Cc: Geetha sowjanya <gakula@marvell.com>
> Cc: netdev@vger.kernel.org
> ---
>  drivers/net/ethernet/marvell/octeontx2/af/rvu.c     |  5 ++---
>  .../net/ethernet/marvell/octeontx2/nic/otx2_pf.c    | 13 +++++--------
>  .../net/ethernet/marvell/octeontx2/nic/otx2_vf.c    |  5 ++---
>  3 files changed, 9 insertions(+), 14 deletions(-)
>=20
Reviewed-by: Sunil Goutham <sgoutham@marvell.com>=20