Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1679323449.git.william.gray@linaro.org> <ca710d14a710fee44f7911f2a84b6a55570561ee.1679323449.git.william.gray@linaro.org>
 <571b4df1-91ea-481c-9797-842974dfa922@sirena.org.uk> <ZDWopwozNjFg/9NX@fedora>
 <db1edaaa-ea56-4f21-bc69-43f648e79c5b@sirena.org.uk> <ZDXSjsjryXn0pHCz@fedora>
In-Reply-To: <ZDXSjsjryXn0pHCz@fedora>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Fri, 21 Apr 2023 10:20:50 +0200
Message-ID: <CACRpkdYNjoc=AHM_AWyyh3DbtfVd17WdmtO68GXrep87WRx5HQ@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] gpio: 104-dio-48e: Implement struct dio48e_gpio
To:     William Breathitt Gray <william.gray@linaro.org>
Cc:     Mark Brown <broonie@kernel.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Apr 11, 2023 at 11:35=E2=80=AFPM William Breathitt Gray
<william.gray@linaro.org> wrote:
> On Tue, Apr 11, 2023 at 10:15:54PM +0100, Mark Brown wrote:
> > On Tue, Apr 11, 2023 at 02:36:23PM -0400, William Breathitt Gray wrote:
> > > On Tue, Apr 11, 2023 at 09:23:55PM +0100, Mark Brown wrote:
> > > > On Mon, Mar 20, 2023 at 10:50:15AM -0400, William Breathitt Gray wr=
ote:
> > > > > A private data structure struct dio48e_gpio is introduced to faci=
litate
> > > > > passage of the regmap and IRQ mask state for the device to the ca=
llback
> > > > > dio48e_handle_mask_sync(). This is in preparation for the removal=
 of the
> > > > > handle_mask_sync() map parameter in a subsequent patch.
> >
> > > > What's the story with this patch?
> >
> > > Currently dio48e_handle_mask_sync() uses the map argument in its
> > > implementation. Once the map parameter is removed, the current
> > > implementation of dio48e_handle_mask_sync() will no longer build, so =
we
> > > must adjust the implementation to no longer depend on map.
> >
> > I mean what's the story with getting this patch applied?  It doesn't
> > seem to have been reviewed...
>
> I'm sorry, I forgot to add Linus' tag from v2 [0]. Linus, would you
> confirm you're still okay with this patch?

Oh of course.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij