Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1990974rwr; Fri, 21 Apr 2023 02:35:28 -0700 (PDT) X-Google-Smtp-Source: AKy350Ypp2MGdYu4QybT0Pf0wDscTJrhyqjH46DArtMbAu+B9eU4wG3ZY2IppFbRLqUuGz5zwiYS X-Received: by 2002:a17:902:e84c:b0:1a0:450d:a481 with SMTP id t12-20020a170902e84c00b001a0450da481mr5294032plg.35.1682069728650; Fri, 21 Apr 2023 02:35:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682069728; cv=none; d=google.com; s=arc-20160816; b=tIC+3CsMItLZGXaF2b2QxgCH3ddHXER2xLeS9ydwGFRIt1bh7ZWfW2NYRalZYj0pPP 9g8aL2+YqShU/zSMrIekXwpravLCtnyB3nu5bL5OEZ30t+gFnpsv/viuRW5Nice31zim R+hwf5/WfNGkxGQb9IpaQr1e5zJs6pxECsDan/i0DRzFVPwFVU5meAQGInvvw7pV7kV4 vnqcL/igZRtQ1ht0XCDZlHLK71HpAhl5s8MfJ1dFiIeZ+Ur8jZYGJDt+d1y5nqcxjO58 ZRCXSPBGzXCT1J5qxV0moOjLxn5XAzzrnPNTmyLr+bd9iI6eTrGBJVfHdj3uDiadCK43 BOTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=PY6X39JZjOiAR0VAgL91BgxZa/k8ZDCgkAATCGW6mlI=; b=Ry1kTbtKt4RIpACnwAhx6LDySLGTdqJtXvnnPIO+Z1wkVI+EVTdZ/5DQTTNK7gro6J CbBtXORFUbS4zx5/ULhZbP7LzzLS8/ux2rXXbBFss5ttcR370u5yuM8OpORxDrLla1zI ehXEozWEQ+TW3UDZbGH3ywfejXmpZAQMGgB/cq9VDFG/2ruA/lUZCOkApdMzxCsY6S4z O7H2ku0BFwgY5CdDATOW8xybCLzcXGN3+3uWcnLFd1dsXzcjqr+p02OpP2qtwxErpldu ILbiyQ6zSB1ydjahAiE4S2qK+mQ94Z0r6DgTI9LMPv7xXY/P+Kl1E+TA2e7U8cihmg3H hGQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020a170903244600b0019a95ab6b4esi4584226pls.407.2023.04.21.02.35.12; Fri, 21 Apr 2023 02:35:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230052AbjDUJ1t (ORCPT + 99 others); Fri, 21 Apr 2023 05:27:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbjDUJ1r (ORCPT ); Fri, 21 Apr 2023 05:27:47 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7797013E for ; Fri, 21 Apr 2023 02:27:46 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 103581480; Fri, 21 Apr 2023 02:28:30 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 559A13F5A1; Fri, 21 Apr 2023 02:27:45 -0700 (PDT) Date: Fri, 21 Apr 2023 10:27:42 +0100 From: Sudeep Holla To: Cristian Marussi Cc: Tejun Heo , linux-arm-kernel@lists.infradead.org, Sudeep Holla , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] firmware: arm_scmi: Fix incorrect alloc_workqueue() invocation Message-ID: <20230421092742.jjr4gnkswj22yt76@bogus> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2023 at 09:46:11AM +0100, Cristian Marussi wrote: > On Thu, Apr 20, 2023 at 09:33:49AM -1000, Tejun Heo wrote: > > scmi_xfer_raw_worker_init() is specifying a flag, WQ_SYSFS, as @max_active. > > Fix it by or'ing WQ_SYSFS into @flags so that it actually enables sysfs > > interface and using 0 for @max_active for the default setting. > > Thanks, good catch, very hard to notice. > > Hi Tejun, > > my bad I messed up the params in the call. > Hi Cristian, I think it deserves the fixes tag, right ? Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support") -- Regards, Sudeep