Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 10:34:44 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Drew Fustini <dfustini@baylibre.com>
CC:     Conor Dooley <conor@kernel.org>, <linux-riscv@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Atish Patra <atishp@rivosinc.com>,
        =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@rivosinc.com>,
        James Morse <james.morse@arm.com>,
        Kornel =?utf-8?Q?Dul=C4=99ba?= <mindal@semihalf.com>,
        Adrien Ricciardi <aricciardi@baylibre.com>
Subject: Re: [RFC PATCH 2/2] RISC-V: Add support for sqoscfg CSR
Message-ID: <20230421-radio-pampers-182af9ea859d@wendy>
References: <20230410043646.3138446-1-dfustini@baylibre.com>
 <20230410043646.3138446-3-dfustini@baylibre.com>
 <20230417-culinary-capillary-4f1efd496691@spud>
 <ZD2mO/2BH9Zo3iqO@x1>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="93JrebvIW3f6S90/"
Content-Disposition: inline
In-Reply-To: <ZD2mO/2BH9Zo3iqO@x1>
Precedence: bulk

--93JrebvIW3f6S90/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 17, 2023 at 01:04:11PM -0700, Drew Fustini wrote:
> On Mon, Apr 17, 2023 at 08:10:20PM +0100, Conor Dooley wrote:
> > On Sun, Apr 09, 2023 at 09:36:46PM -0700, Drew Fustini wrote:

> > >  #ifdef CONFIG_FPU
> > >  extern void __fstate_save(struct task_struct *save_to);
> > > @@ -79,6 +80,7 @@ do {							\
> > >  	if (has_fpu())					\
> > >  		__switch_to_aux(__prev, __next);	\
> > >  	((last) =3D __switch_to(__prev, __next));		\
> > > +	qos_sched_in(__next);				\
> >=20
> > Both FPU and vector do:
> > |	if (has_fpu())					\
> > |		__switch_to_fpu(__prev, __next);	\
> > |	if (has_vector())				\
> > |		__switch_to_vector(__prev, __next);	\
> >=20
> > Is it just my OCD that wants ssqosid to be the same?
>=20
> Thanks, I had not noticed those changes from the vector patch series [1]
> until you pointed it out. The handling of sqoscfg could be converted to
> that pattern too.
>=20
> > It'd also do away with that seems a bit weird to me: having
> > qos_sched_in() and __qos_sched_in().
> > Even if you don't make them similar, what's the rationale behind not
> > inverting the extension check & returning early from a single function.
>=20
> The goal was so the inline qos_sched_in() would turn into a nop when
> Ssqosid extensions not present. If Ssqosid was present, then the "real"
> function __qos_sched_in() would be called.
>=20
> However, having looked at the handling of fpu and vector in the vector
> series, I think will redo the sqoscfg handling to follow that pattern.

Aye. With the way they do it, if !CONFIG_..._SSQOSID, DCE should
remove the function call entirely & the has_extension_[un]likely() stuff
will give you your nop for kernels with CONFIG_..._SSQOSID but no
hardware support.

I think it looks "nicer"/more obvious if you copy what the fpu/vector
stuff does /shrug

Cheers,
Conor.

--93JrebvIW3f6S90/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZEJYtAAKCRB4tDGHoIJi
0koqAP9JSTnE1ituL4i8GxzmCkIFr4W2t/O2GE/Ovpu/VESQygEA2SxnDL+DnpGW
tNkEQiBeE+EYDnbfMEXNxjPF2aYelg8=
=64pG
-----END PGP SIGNATURE-----

--93JrebvIW3f6S90/--