Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp2057394rwr; Fri, 21 Apr 2023 03:46:47 -0700 (PDT) X-Google-Smtp-Source: AKy350ZP4Zhar2lBPOz3WEDvqGM6q6GA+ptKUiFZAdRtvE3Lvi55bKN/07k4jra0PHsnlP16lm1A X-Received: by 2002:a17:90b:1e07:b0:246:b2de:f13f with SMTP id pg7-20020a17090b1e0700b00246b2def13fmr5012172pjb.24.1682074006922; Fri, 21 Apr 2023 03:46:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682074006; cv=none; d=google.com; s=arc-20160816; b=HrxMk4jZ3b5lqvPIM5MnDqK3Ekw8agCpL80KNS6ldz1rYn/uSUPF3ValfCNpJfpV1r moXxl3d6514Ab7OkszDrDGngurw3zBzq5PTxZHnLoDWbyu44n8k4wvQ0OaTIqc/4MX2E zncrkn5nJsoaaxmYHovksmHnSh2Fj/I0msJ+4iQFhqI/nymi371Y4iXdpgbtQDIfyVO1 ePvhkkvYs2mg6VXobPAL60uSzGTcbYdNDYll4x93owL6AMqzfg7SE10PzPNFQCiBnTpl 7oKXyl0zeBJO/UN6iRXxhQnIdfLQS1XJQCPF7HdcljwqDGyHQHdxHYGc6uWlE+Us+g0a uOLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=mRR8QtsSmxjRIku5DkJBFiN+Snm7HpPNejtlu92e2h4=; b=NPePXvTdWNTH/6yoZDVC4K89/JqHBNL8RmIDKjDuuCJaqIB5e803uIT7UxAnEhgdkS U+BQyk8apxz07F+r6i7BE9LzlNaZ8PvvSBCUtv+U69GlElmygtqIhwFSqIsaXhaI768u /qU2YYQVUO1TBI2wXq407VY2OKRNGOO7Rc9lcobkN6uGnBjTEPYWZ0pWSImOdLBrey0i kUDRDu1xRawYHUQMund+aeANCpwIvgCpHwCxpHKrsSRECmWE9mwB8XHWlllK+ZQTW0J0 2E74FC7lxv0uuFwwuTPqJsiD8fcu1cheQNLbCOvNh+wqndUN02/hILwebG08nTbIneFw tt1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=As8nZXfV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p13-20020a17090b010d00b002496cedea8esi4242635pjz.24.2023.04.21.03.46.33; Fri, 21 Apr 2023 03:46:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=As8nZXfV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231368AbjDUKob (ORCPT + 99 others); Fri, 21 Apr 2023 06:44:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229884AbjDUKoa (ORCPT ); Fri, 21 Apr 2023 06:44:30 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 586923C07 for ; Fri, 21 Apr 2023 03:44:29 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-2fa36231b1cso966259f8f.2 for ; Fri, 21 Apr 2023 03:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682073868; x=1684665868; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=mRR8QtsSmxjRIku5DkJBFiN+Snm7HpPNejtlu92e2h4=; b=As8nZXfVquw9bOEdzULHA3Not2GSqD1l15CQ2M3BHZeFQF6QIhBuJXv4rKzXgnCf/x hwwmG7K23HRwX4QLME9tdAlnvkQ5pFHWXSMFkDCmffcB0ezeQb80rpw56nYijTG4a66Q Z2A+KWB90RYWJ6dVCC9psjN5cJ5O2DAUcyhWPFUHQ93Tz0tfx9OjOOY/jwFRD8YQMzpS fQ3cjYV1u4B8kwAGZXKUMWfP4+JLDtEtwufk39DOkVyS27SbYEGiL846EQJucn6CzKdn dMhtwuxshqN4keKtc8HQCIILdGRh/C4ZosfNLrYNh5w4F5uJ9NeQxpJlrSxHGohHVs68 YYsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682073868; x=1684665868; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mRR8QtsSmxjRIku5DkJBFiN+Snm7HpPNejtlu92e2h4=; b=jASVyUnAaIFYO11DJe2TCb8cMOuPhyloDB4jLLElYpoSg5HEwLLe6pTWc4f2ZgR4mV ok1gAzFXSShbyxW0NmcjryhQz2bN0Tkwdi35Exij3TFRNctwz6yb0Wy2BnU4ev/0i+Nd fzJeHU85VVN3o6F0p4RTcge4Jv8YpZ0X05ch9TKJT67LHjcs9tp0bq0q0Z9NGj9KYG6R 4vgALQVl+5W90pZEYPXY9cbH5/1mTQj3u46dPV6IqobBUslib2k+GETXJelvRBbDZ10k QAFfpZ2qIx8mi1h27+NM5Nb904wRpcwWXz8+O8lcVmH/p6ICcgd/kvHKplFZqlcc76LJ E2kg== X-Gm-Message-State: AAQBX9e5kzm4InWtPX0tyRFGoKp+St6om9C7pZbrrqdAx2kREnzzcAO6 Z/Ek8Oxftu8Osjh1kWPwFCzphg== X-Received: by 2002:adf:fecb:0:b0:2cb:2775:6e6 with SMTP id q11-20020adffecb000000b002cb277506e6mr3369289wrs.45.1682073867970; Fri, 21 Apr 2023 03:44:27 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id f17-20020a5d50d1000000b002e5f6f8fc4fsm4085509wrt.100.2023.04.21.03.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 03:44:27 -0700 (PDT) Date: Fri, 21 Apr 2023 13:44:21 +0300 From: Dan Carpenter To: Loic Poulain Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] soc: qcom: rmtfs: Fix error code in probe() Message-ID: <76b21a14-70ff-4ca9-927d-587543c6699c@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return an error code if of_property_count_u32_elems() fails. Don't return success. Fixes: e656cd0bcf3d ("soc: qcom: rmtfs: Optionally map RMTFS to more VMs") Signed-off-by: Dan Carpenter --- drivers/soc/qcom/rmtfs_mem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c index ce48a9f3b4c8..f83811f51175 100644 --- a/drivers/soc/qcom/rmtfs_mem.c +++ b/drivers/soc/qcom/rmtfs_mem.c @@ -233,6 +233,7 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev) num_vmids = 0; } else if (num_vmids < 0) { dev_err(&pdev->dev, "failed to count qcom,vmid elements: %d\n", num_vmids); + ret = num_vmids; goto remove_cdev; } else if (num_vmids > NUM_MAX_VMIDS) { dev_warn(&pdev->dev, -- 2.39.2