Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 13:08:55 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Stanley =?utf-8?B?Q2hhbmdb5piM6IKy5b63XQ==?= 
        <stanley_chang@realtek.com>
Cc:     Alan Stern <stern@rowland.harvard.edu>,
        Douglas Anderson <dianders@chromium.org>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Bhuvanesh Surachari <Bhuvanesh_Surachari@mentor.com>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Flavio Suligoi <f.suligoi@asem.it>,
        Ray Chi <raychi@google.com>,
        Michael Grzeschik <m.grzeschik@pengutronix.de>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] usb: phy: add usb phy notify port status API
Message-ID: <ZEJux2KTnGw-WE1A@kroah.com>
References: <20230421080333.18681-1-stanley_chang@realtek.com>
 <ZEJHLR27pVwVI3_J@kroah.com>
 <efd6e621210a407db9c153712f362366@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <efd6e621210a407db9c153712f362366@realtek.com>
Precedence: bulk

On Fri, Apr 21, 2023 at 08:32:19AM +0000, Stanley Chang[昌育德] wrote:
> > 
> > On Fri, Apr 21, 2023 at 04:03:31PM +0800, Stanley Chang wrote:
> > > In Realtek SoC, the parameter of usb phy is designed to can dynamic
> > > tuning base on port status. Therefore, add a notify callback of phy
> > > driver when usb port status change.
> > >
> > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
> > > ---
> > >  drivers/usb/core/hub.c  | 13 +++++++++++++  include/linux/usb/phy.h |
> > > 14 ++++++++++++++
> > >  2 files changed, 27 insertions(+)
> > 
> > We can not add callbacks in the kernel that are not actually used, otherwise
> > they will just be instantly removed.
> > 
> > Please submit any drivers that need this change at the same time so that we
> > can verify that the callback is actually correct and needed, otherwise we can
> > not take this change.
> > 
> 
> In this stage, we usb phy driver is not at linux upstream. 

Then obviously we can not take this change (nor would you want us to.)

> For the android GKI, we have to add this callback to upstream or use the vendor hook of android.
> I will plan to upstream the realtek usb phy driver.

As you already have this driver, why not send it to us now?

thanks,

greg k-h