Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yang Yang <yang.yang29@zte.com.cn>
To:     vbabka@suse.cz, akpm@linux-foundation.org
Cc:     hannes@cmpxchg.org, iamjoonsoo.kim@lge.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, rppt@kernel.org,
        yang.yang29@zte.com.cn
Subject: Re: [PATCH linux-next v2] mm: workingset: update description of the source file
Date:   Fri, 21 Apr 2023 19:31:30 +0800
Message-Id: <20230421113130.240586-1-yang.yang29@zte.com.cn>
In-Reply-To: <0ddb50f0-2e2d-e750-3867-3842a3ea12cc@suse.cz>
References: <0ddb50f0-2e2d-e750-3867-3842a3ea12cc@suse.cz>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

> I'm late but FWIW, not supper happy that while the updated calculations are
> now accurate wrt the actual code, the explanation (which was written at the
> time of page cache-only workinset) was more easier to follow in the simpler
> form. Now it's still mostly talking about page cache and explaining the
>balance between its active and inactive list only, and then suddenly the
> anon lists appear out of nowhere in the final equations.

Thanks for your reviewing! I should update the whole parts. Sorry for
hadn't do it better, please drop the patch, I will try to submit patchv3
to fix this.

> In other words, I think it would have been better to leave that explanation
> as it was, and then add a new part describing the extension to anon pages.

I read the description of the source file again carefully, and think that
there is no need to creat a new part, if we explain at the begining that
the word 'pages' include page cache and anonymous page, and do some minor 
adjustments. For example:
Per node, two kinds of clock lists are maintained for pages..