Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 15:17:17 +0300
From:   Sakari Ailus <sakari.ailus@linux.intel.com>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     Vaishnav Achath <vaishnav.a@ti.com>, mchehab@kernel.org,
        hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, u-kumar1@ti.com
Subject: Re: [PATCH] media: v4l2-mc: Drop subdev check in
 v4l2_create_fwnode_links_to_pad()
Message-ID: <ZEJ+zURHpGUo+Wvm@kekkonen.localdomain>
References: <20230421100430.28962-1-vaishnav.a@ti.com>
 <20230421121048.GK21943@pendragon.ideasonboard.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230421121048.GK21943@pendragon.ideasonboard.com>
Precedence: bulk

On Fri, Apr 21, 2023 at 03:10:48PM +0300, Laurent Pinchart wrote:
> Hi Vaishnav,
> 
> Thank you for the patch.
> 
> On Fri, Apr 21, 2023 at 03:34:30PM +0530, Vaishnav Achath wrote:
> > While updating v4l2_create_fwnode_links_to_pad() to accept non-subdev
> > sinks, the check is_media_entity_v4l2_subdev() was not removed which
> > prevented the function from being used with non-subdev sinks, Drop the
> > unnecessary check.
> > 
> > Fixes: bd5a03bc5be8 ("media: Accept non-subdev sinks in v4l2_create_fwnode_links_to_pad()")
> > 
> > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Sakari, the commit this patch fixes will land in v6.4, should this be
> merged as a v6.4 fix ?

I'd think so. I'll take this soonish.

-- 
Sakari Ailus