Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230421061825.2233-1-stanley_chang@realtek.com> <20230421061825.2233-2-stanley_chang@realtek.com>
In-Reply-To: <20230421061825.2233-2-stanley_chang@realtek.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Fri, 21 Apr 2023 08:04:22 -0500
Message-ID: <CAL_JsqJBDuxCAnZmHBnHuMkjTXTLet2d3o5kLRZQ_YuqVB9Pcw@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] dt-bindings: usb: snps,dwc3: Add
 'snps,global-regs-starting-offset' quirk
To:     Stanley Chang <stanley_chang@realtek.com>
Cc:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Felipe Balbi <balbi@kernel.org>, linux-usb@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 21, 2023 at 1:18=E2=80=AFAM Stanley Chang <stanley_chang@realte=
k.com> wrote:
>
> Add a new 'snps,global-regs-starting-offset' DT to dwc3 core to remap
> the global register start address
>
> The RTK DHC SoCs were designed the global register address offset at
> 0x8100. The default address offset is constant at DWC3_GLOBALS_REGS_START
> (0xc100). Therefore, add the property of device-tree to adjust this
> address offset.
>
> Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
> ---
>  v2 to v3 change:
> 1.  Fix the dtschema validation error.
>
>  v1 to v2 change:
> 1. Change the name of the property "snps,global-regs-starting-offset".
> 2. Adjust the format of comment.
> 3. Add initial value of the global_regs_starting_offset
> 4. Remove the log of dev_info.
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Docum=
entation/devicetree/bindings/usb/snps,dwc3.yaml
> index be36956af53b..4f83fa8cb6cb 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -359,6 +359,14 @@ properties:
>      items:
>        enum: [1, 4, 8, 16, 32, 64, 128, 256]
>
> +  snps,global-regs-starting-offset:
> +    description:
> +      value for remapping global register start address. For some dwc3
> +      controller, the dwc3 global register start address is not at
> +      default DWC3_GLOBALS_REGS_START (0xc100). This property is added t=
o
> +      adjust the address.
> +    $ref: '/schemas/types.yaml#/definitions/uint32'

Again, we're not going to keep adding properties for every DWC3
variation. If it is board specific, then yes a property is
appropriate. If it is SoC specific, then imply it from the compatible.
Or in this case, you could possibly add another reg entry.

Rob