Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Arnd Bergmann <arnd@kernel.org>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
        "kernel-tls-handshake@lists.linux.dev" 
        <kernel-tls-handshake@lists.linux.dev>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/handshake: fix section mismatch error for
 handshake_genl_net_ops
Thread-Topic: [PATCH] net/handshake: fix section mismatch error for
 handshake_genl_net_ops
Thread-Index: AQHZdCrJbFYwZyHCs0+AR8XiNgzQMq81wQoA
Date:   Fri, 21 Apr 2023 13:25:16 +0000
Message-ID: <01A42FB6-9391-4E31-AF58-A522F284A893@oracle.com>
References: <20230421082450.2572594-1-arnd@kernel.org>
In-Reply-To: <20230421082450.2572594-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/l5TisWfkCQEBUApl/ECmPv2PPYQ+V1ZimmNknr87Bc9susGtUfTwmCVLVXl?=
 =?us-ascii?Q?xL9MTXBnoMCWaeKqT25Pqt+WjKpI03imAn5UZaXzfV046tcdQq8Qf/bSxjAk?=
 =?us-ascii?Q?/3/V9mVq/BzQWZL5V/SmX7WqgHWB3elMXyl6RPIY1PqLlNlMopl3QKCTFS74?=
 =?us-ascii?Q?yjr624V5t5coAT6BE9mgnSxT/7Am/FjhTLgZHcYa6TtrpJolhiLhtpaZBxUc?=
 =?us-ascii?Q?FxkRdNHOYf8d02lUh+A4FVAd0lAcIB3xqHZceDRQTSbNDXMDXIf3yFPFbGVo?=
 =?us-ascii?Q?zYX7ZHTF1TsnkalpZCTahPSZCf/AXn50jqElbue3H42r/Ba1MpMv2vNEXvMd?=
 =?us-ascii?Q?F2nFKCmgGaIq502tML2nJ48yfihd3oNnm+ofHopS1Dk/eYPWFpvB/5khzjG4?=
 =?us-ascii?Q?hTTcPaI86pDMCFBXcCohgZp68r/+SI5Km67LGk6m75Bd6VLpYgm5qzsLWwJS?=
 =?us-ascii?Q?WuT9ZSiDJfSj+tcRyqiUr30x4aeb/7jWil/m7QbMAtGASTxTWa04cXs+Vk9N?=
 =?us-ascii?Q?v5RdvM7iJiTw11q/B7+RIdOvjffXk9WI6w/6gfutkrkBuQMTD6wBH5xQdZ31?=
 =?us-ascii?Q?phnAA/e7jCyTNdWtjFNYbc8hoCuxysIzIp0ubiDEXJInbPkIMcyhOK4H11VE?=
 =?us-ascii?Q?pFFm0ACl2Nn3Nk+//tvo7nQwPFD+SJD3wDT3BVNhQk6tnoLbhIEY9fh9tX7/?=
 =?us-ascii?Q?Emw5/DPa5BVT6G8qp5p6XVZKzNEfJ6XLfSro90amuqSxxzsu0x0doruTQ3a5?=
 =?us-ascii?Q?N41e1IjBa/8IdxLGqzSEPARyKaEMBrDEaAWJjJxHo7WXxtJeCuskpr2gEDUg?=
 =?us-ascii?Q?Z1PQqg9SsRvo0IN7lL6taa44U9VA7TGl1g+EGj/RE58VIvMdyPxqYQhZODz1?=
 =?us-ascii?Q?UKpwWcUAqkJay0km19vaPkDd3Ln57sDZxi82CO3l67gmuRRkzvODRDnKi0V6?=
 =?us-ascii?Q?3Sqn6sfUFU1F5o5nrLO8/dxpj/eCtGbT1+XAvk2Ga7L6wNb00u9CfJf8Jot7?=
 =?us-ascii?Q?VJsgmGLWhDz1TmTTMMeBlPwTQ/s9896v1DlGhSMjD0vBpfktZVBts4WkbDV5?=
 =?us-ascii?Q?JhkpqC+dC6v4OqJGv89FxSY28hj6mwPgO4GTFC34+MlL6MlzyuZKLwrQFe60?=
 =?us-ascii?Q?WmaH+CuXe1rTKVQMdcykbs5FKPutPgjlV33lnhrXXv7JNHZECwBAzfcCvtWG?=
 =?us-ascii?Q?B7cM0uzDon7L6oFZwgRZyiZTstlZuY8jKEIzzspQn1Ble2XKgQNHsfXLSeuI?=
 =?us-ascii?Q?Uqr4lvbPu5llKSaPpV6YMaSi92PZhO/b42Zq19xVfmAyfZsAy977LqvN3Pq+?=
 =?us-ascii?Q?uxNo58pcBqILD38pgldHEWyq/kTetHBLnEEgMjtHsDWBxH403O/cvEkTnD1E?=
 =?us-ascii?Q?bEtQEh7Ysa6lmxU2RpjHOTb3TeavCYDdGENeRVXUzS19LMIH1sI0ZUDj4Z3h?=
 =?us-ascii?Q?B9txEl0Qn+doN/w8YHn+FyHH4jN8MbXl6Q+HWaE4ebWqVOlqr+JLWl5XqozW?=
 =?us-ascii?Q?vB61lrg8BjvkYqwexrddFbQRBCWZfrFT/tD3RDa68gLWZS5DKPgrwHqbK+/p?=
 =?us-ascii?Q?q5SthmNdxfbRZq17bQqRm1Hwt5mHjPApJYvkWRnxPs3Y+XnHHBmyY8Wxko7+?=
 =?us-ascii?Q?yg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0DE7A0AC60064D4393EBAD039B57ED9D@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?EISN653DhdJWhSrUeNtrnqllL6iQuAJLqFl2IrkuB/ZUSnKltugkBrHDcm3J?=
 =?us-ascii?Q?BV/0dnA7eNfsqO8p6XfDFrsZ+ugBQt71etD7PK6TxJBdIZpiOa0xn8BLquUN?=
 =?us-ascii?Q?d0GPJRfEjX+1LUBvdmqKXwPEmga7143C3nfpT2Jqot/cP4z9VF1prRADkeww?=
 =?us-ascii?Q?b1+uZ00ETKBurAV6RZ6tDMaLIPDKISMVRKLZnmLXyeXCfxHtuEPkLOcF/kpc?=
 =?us-ascii?Q?+8B1r0Zi8wc2p3so0wSlwfn1ODaiRhKhOydn+Zye+aRpIvo9nhNES7wIc+I7?=
 =?us-ascii?Q?/eQW8nAtfck9ijYrKqTx9X8qfrPy963LEJlepDAbUNVkjY9Yx1Acd6Jp1nax?=
 =?us-ascii?Q?ZqpUHaG3+Fkk7Cs6UL3gTap9iSy0/diAKKlXg6YjTBWVRKAJecIXa7/ywlvC?=
 =?us-ascii?Q?jbcWGzG7+ftIJQNseF4v8zNW9lR+hFGMNJYQ1HjjlbLg2gDdoddmNLd66KYh?=
 =?us-ascii?Q?j4xWVt+lHoROnsILYfOIFcqfZoaoAILOtFU9n1YJI1koz105Jt6iq1YzGHht?=
 =?us-ascii?Q?F4WUf+ZZrakp4/m29Dla6D0XrP1DNjC/DdMxn3bL2WXyY17pnaoQJ+XlUV+5?=
 =?us-ascii?Q?T0W6tz+krR985Xuq894W8kqqklfOfO0QiYwHwfAh3yyOHMCm8H65eA22DxzR?=
 =?us-ascii?Q?XXMjEoMcDAyLcFTNbe+nZ4R5955L3NOUjY/xMtBqeBZNH4Zp9eWvMMO7LCRe?=
 =?us-ascii?Q?2xrX03AM4T/QGLHemhP+YPIp1BNXy/bMeFjvtR4fKE/CEVV0MRGWDo49rUKA?=
 =?us-ascii?Q?8zWSrmRSKYXGh0RpR4uzVfeRAAMO255jkMrNgpxltrkNJYlZuhknqTd96TCa?=
 =?us-ascii?Q?8QhWpuxQU5J9CV7nSnIRKj6LlC42b//jgAjRn01cq7ClLbECrRj759mmGBAk?=
 =?us-ascii?Q?uZS/2MKMeo7HkxLHMtOhBf8ERzZzkB5nLicbPXr7d+i1Nb3JaqXeAgHp/Sy0?=
 =?us-ascii?Q?PywVlPBisyhi989SvZJeKw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dbcde1f6-0d9c-44e2-25cc-08db426bd8b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2023 13:25:16.7488
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XD1GkiLTl1h+KObeZO7QRxEjlRpdM+qSoP3MyRO3liaVC1mjFIyETXMGDovIcFSP1hlB/OykrzyL1HLfCLwBBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6883
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-21_06,2023-04-21_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304210117
X-Proofpoint-ORIG-GUID: bx2lHGbrpnXkNARhjDJSqEBijwkgakl6
X-Proofpoint-GUID: bx2lHGbrpnXkNARhjDJSqEBijwkgakl6
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Apr 21, 2023, at 4:24 AM, Arnd Bergmann <arnd@kernel.org> wrote:
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> The new netlink interface causes a link-time warning about the use of
> a discarded symbol:
>=20
> WARNING: modpost: vmlinux.o: section mismatch in reference: handshake_exi=
t (section: .exit.text) -> (unknown) (section: .init.data)
> ERROR: modpost: Section mismatches detected.
>=20
> There are other instances of pernet_operations that are marked as
> __net_initdata as well, so I'm not sure what the lifetime rules are,
> but it's clear that any discarded symbol cannot be referenced from an
> exitcall, so remove that annotation here.
>=20
> Fixes: 3b3009ea8abb ("net/handshake: Create a NETLINK service for handlin=
g handshake requests")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thank you, Arnd. We received two other patches yesterday
with the same build error report and suggested fix.


> ---
> net/handshake/netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/net/handshake/netlink.c b/net/handshake/netlink.c
> index 8ea0ff993f9f..35c9c445e0b8 100644
> --- a/net/handshake/netlink.c
> +++ b/net/handshake/netlink.c
> @@ -249,7 +249,7 @@ static void __net_exit handshake_net_exit(struct net =
*net)
> }
> }
>=20
> -static struct pernet_operations __net_initdata handshake_genl_net_ops =
=3D {
> +static struct pernet_operations handshake_genl_net_ops =3D {
> .init =3D handshake_net_init,
> .exit =3D handshake_net_exit,
> .id =3D &handshake_net_id,
> --=20
> 2.39.2
>=20

--
Chuck Lever